From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id LNs9MvgHrF/0LwAAWB0awg (envelope-from ) for ; Wed, 11 Nov 2020 10:49:12 -0500 Received: by simark.ca (Postfix, from userid 112) id C0CFD1F08B; Wed, 11 Nov 2020 10:49:12 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 33CB01E58F for ; Wed, 11 Nov 2020 10:49:12 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 947D93851C18; Wed, 11 Nov 2020 15:49:11 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 2A7CF3851C18 for ; Wed, 11 Nov 2020 15:49:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2A7CF3851C18 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 06A881E58F; Wed, 11 Nov 2020 10:49:07 -0500 (EST) Subject: Re: [PATCH][gdb/testsuite] Use clean_restart where possible To: Tom de Vries , gdb-patches@sourceware.org References: <20201105164017.GA26390@delia> <09afb982-34dc-0488-1df7-7534042b787f@simark.ca> <1fe630a0-0d44-8e04-b905-09a727ba7c56@suse.de> From: Simon Marchi Message-ID: Date: Wed, 11 Nov 2020 10:49:07 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1fe630a0-0d44-8e04-b905-09a727ba7c56@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-11-11 4:18 a.m., Tom de Vries wrote: > [ was: Re: [PATCH][gdb/testsuite] Add > gdb.dwarf2/fission-multi-cu-clang.exp ] > On 11/10/20 8:21 PM, Simon Marchi wrote: >>> +gdb_exit >>> +gdb_start >>> +gdb_reinitialize_dir $srcdir/$subdir >> >> clean_restart? > > Hmm yes, that's one of those things I just pick up by starting a > test-case using a copy of another test-case. > > So, let's fix this in those other test-cases as well. > > FWIW, I'm open to suggestions to do this in an easier way than using awk. > > Thanks, > - Tom > I don't know awk, so that looks very impressive to me! I think it's a good idea to fix them once and for all. It would be worth grepping for gdb_reinitialize_dir, to catch more spots that can be changed. For example, in gdb.base/overlays.exp we have the sequence without gdb_exit: 49 gdb_start 50 gdb_reinitialize_dir $srcdir/$subdir 51 gdb_load ${binfile} Those can also be changed with clean_restart. Simon