From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id RHamLuZAxV9YLwAAWB0awg (envelope-from ) for ; Mon, 30 Nov 2020 13:58:46 -0500 Received: by simark.ca (Postfix, from userid 112) id B26E71F0AC; Mon, 30 Nov 2020 13:58:46 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 32E9C1F0AA for ; Mon, 30 Nov 2020 13:58:46 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C2C86384A02B; Mon, 30 Nov 2020 18:58:45 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 3E198385782A for ; Mon, 30 Nov 2020 18:58:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3E198385782A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BF4E01E590; Mon, 30 Nov 2020 13:58:42 -0500 (EST) Subject: Re: [PATCH 11/12] gdb: make displaced stepping implementation capable of managing multiple buffers To: Pedro Alves , Simon Marchi , gdb-patches@sourceware.org References: <20201110214614.2842615-1-simon.marchi@efficios.com> <20201110214614.2842615-12-simon.marchi@efficios.com> <7cfcdcb4-f70f-a774-3378-e324735d1fe8@palves.net> From: Simon Marchi Message-ID: Date: Mon, 30 Nov 2020 13:58:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <7cfcdcb4-f70f-a774-3378-e324735d1fe8@palves.net> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-11-24 8:41 p.m., Pedro Alves wrote: > Call: > > m_buffers.reserve (buffer_addrs.size ()); > > before. > > > But even better, the caller is allocating a temporary std::vector > and passing that: > > + std::vector buffers; > + for (int i = 0; i < gdbarch_data->num_disp_step_buffers; i++) > + buffers.push_back (disp_step_buf_addr + i * buf_len); > > So how about making the ctor above be instead: > > displaced_step_buffers (std::vector &&buffer_addrs); > > and make the caller move the vector into displaced_step_buffers? > > + per_inferior->disp_step_bufs.emplace (std::move (buffers)); displaced_step_buffers' ctor takes a vector of CORE_ADDR, but it contains a vector of displaced_step_buffer. So it can't just move and use directly the vector passed by its caller. I'll call reserve though. Simon