From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112761 invoked by alias); 13 Jan 2020 15:59:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112513 invoked by uid 89); 13 Jan 2020 15:59:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1046 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Jan 2020 15:59:41 +0000 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 81FF91E4B2; Mon, 13 Jan 2020 10:59:39 -0500 (EST) Subject: Re: [PATCH v2 18/24] Multi-target support To: Pedro Alves , gdb-patches@sourceware.org, Andrew Burgess References: <20191017225026.30496-1-palves@redhat.com> <20191017225026.30496-19-palves@redhat.com> <113c6953-3621-c61b-e318-19806805e878@simark.ca> <5a65f85e-89cb-fd6c-469d-250348f6c295@redhat.com> From: Simon Marchi Message-ID: Date: Mon, 13 Jan 2020 16:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <5a65f85e-89cb-fd6c-469d-250348f6c295@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00327.txt.bz2 On 2020-01-13 10:10 a.m., Pedro Alves wrote: > On 1/12/20 7:57 PM, Simon Marchi wrote: >> On 2019-10-17 6:50 p.m., Pedro Alves wrote: >>> This commit adds multi-target support to GDB. What this means is that >>> with this commit, GDB can now be connected to different targets at the >>> same time. E.g., you can debug a live native process and a core dump >>> at the same time, connect to multiple gdbservers, etc. >>> >>> ... >> >> remote-sim.c needs to be updated to. The patch below makes it build, although >> I have not tried it (I don't have time right now to re-figure out again how do >> do it :)). >> > > Sorry about this. I don't know how I missed it. > > The patch look good to me. One nit: > >> /* Callback for iterate_over_inferiors. Called (indirectly) by >> gdbsim_close(). */ > > This comment is now stale. I changed it to: /* Helper for gdbsim_target::close. */ The comment on gdbsim_target::close already explains what is done when closing. Pushed with that fixed, thanks. Simon