From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aQK7L/nw/2i2dgwAWB0awg (envelope-from ) for ; Mon, 27 Oct 2025 18:23:53 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=MEnhGoMz; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BEFFC1E057; Mon, 27 Oct 2025 18:23:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5D2011E057 for ; Mon, 27 Oct 2025 18:23:53 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D8F1B3858C20 for ; Mon, 27 Oct 2025 22:23:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D8F1B3858C20 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=MEnhGoMz Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id 0A25B3858D37 for ; Mon, 27 Oct 2025 22:23:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A25B3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0A25B3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::329 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761603799; cv=none; b=R3uimurn5Nt+F77Pbf+xnMCUbXc+9mxAKF4MgLaORoOLG9Ys1xX3pWZnzd+KohaVgWK/uu6wtgv5ie+Z2U2kU+jZWGAhxivJWfLs5s6n3xSqMZb70uECk0CcLVfKLUsZaQnEjsHmR6KqeBosORu7qDRupuQk7ziWNtlgwYvw5pA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761603799; c=relaxed/simple; bh=WcOWqNuhEDWLq03RU/PtptcoDJHES77tjqvSLn7DG70=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=w6e+isjU8uMrO0AtQov1+BSwz3AYzGH1jDWhyFbEFSbntKWKsIU3WXDNidOAD/wkWhdBijEF1H1gNU+Ec1BVTHIseiB5yemEGK34lgl5gXcRZ08Q99CdLBCtQdYnDUMcuFc0oXpfNkY5XLln/DeQrHII41xbm4IkhC0XALrwQK0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0A25B3858D37 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4711b95226dso65076845e9.0 for ; Mon, 27 Oct 2025 15:23:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761603798; x=1762208598; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qcTwCfot4LqQ2nuMP9h8HxrWv8tG+KamvWiDcgp+nAQ=; b=MEnhGoMzxLzD9ksfHUdf/LQB2doU2oCL8YmaZqV+eFzhQWDi1PDSTBk7U1BVceRxBi S4p7Ms6aQRhcqcogJ3pcF+Vj59fw8hW0GwaYWmbMqv9a0mp8pGU/qlK3T+/c1X9pqicM Pt57JEry4FiiJGm1CsQoXKmF/ffrnLIr3J8t6mGqm0WZ95P8sn5/g6kyBQGAXITVl8u1 L4StFTa5J3ohUJL8LUqh7233nKMy6YNPbfzvXcwqVRsLF03VQhAn/qTufuLdepw1V++s QyDsxq1Ud9TIEVn6CqiRFegcbxpVAVkxsiIlhWtR2OXArSwHIACIYkDhrBAwdP4vZbku +ZXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761603798; x=1762208598; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qcTwCfot4LqQ2nuMP9h8HxrWv8tG+KamvWiDcgp+nAQ=; b=X2Yim5SLkVlxv/79KOHBGGHkBHhBR/xcHLQJrvGB2gpMcE+Giz1uSZnnAperTW6a3N fkVVBnpNPkoDEGMdpogGY/zzjTRj5yv03LhPZS0qlpAjv/VTUt1YhLURh5VhLLFJ0J8V YxraDEs1bAeLDHRNS30NA8EHi1UpE6LIan3dNZao42zayMlbcLwhqk21GsQlNEKwzGzb jYxsm9CykgofyjAjo7m7esSQr0cjg7/8GVCU5GoX3tAJYzvrOr2aqUGsNmRh12iDd9OJ Kgi/mIbmJqv00AQvzw3hdUcQrdeKPG4Xw2b2ZJ8oM3sRuhBHVdo9K1hkJootTeYnhAAn BF4Q== X-Forwarded-Encrypted: i=1; AJvYcCWHmzLIaSaup9b/o6qnBTJkiHw/PT0hXZten7KRRPPwMR6ybZmqy7vcaTvqz+iNmxkRxhVRaF/M2m4H0g==@sourceware.org X-Gm-Message-State: AOJu0YxkoGoOa3hbBDfaYxicrsS8W4at89tMu3hMsXSQ7gxR3VcuUxGJ P0qBhxewT4wac+2plAQSXX77jdMAegoSjYUiJmDRtBricOGVZ5mXsjZD X-Gm-Gg: ASbGnctKXqehWvXqchDeTeVur6ka6QtxEAU3DO1EgJ1KbODxlQP7zvjYqEitfgOhF63 F6Mh3AyVP5bRNL/Wc2uwrh8aTliqV5vryW3EvKtZ+Yq5ehNSVe69++xDSCE86RF0LKSbhfzBRLJ wudfbMA25S+z37Cos7iwTPS4uu3F5LF/iOzQY737/fkuqN3A7XQjqugEyZKQLUG4VdfAXeCkP8V 7ZjspcyEuPGQ5rY5kLDXV7YYENnwj8r+LQjKByfCZi0j+oenq71fzab1gZnWgad8alleufVeZ2s Ys2bXtG2DV2sgFUaJf6G/pOD53W9e3k4l2l30Ip88JQtVweEKDBeHvLivthd0QG63s7gDRcBlzx RhTrhsHLiSckNtqDW/Z+yHmM47eQgQ/M7OgpgpI5+/mHYx8ipxFLVPJ8iEMD47zp43gb517wScM 51boDrhoU4SQzsCE7x5nsOFxo= X-Google-Smtp-Source: AGHT+IFcw6hKJY9Szfuao6rQR4hcIhDoyZlfM137Y9wEFxxUWxzYZIzTM4Hx2n8Q6W2IIR60My5ehA== X-Received: by 2002:a05:600c:5295:b0:45d:f81d:eae7 with SMTP id 5b1f17b1804b1-47717e6aa8bmr12069745e9.28.1761603797476; Mon, 27 Oct 2025 15:23:17 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475dd4e30f5sm159319835e9.17.2025.10.27.15.23.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Oct 2025 15:23:17 -0700 (PDT) Message-ID: Date: Mon, 27 Oct 2025 22:23:16 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/6] gdb/aarch64: core file support for FPMR Content-Language: en-US To: Ezra.Sitorus@arm.com, gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20251021150300.59860-1-Ezra.Sitorus@arm.com> <20251021150300.59860-5-Ezra.Sitorus@arm.com> From: Luis In-Reply-To: <20251021150300.59860-5-Ezra.Sitorus@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 21/10/2025 16:02, Ezra.Sitorus@arm.com wrote: > From: Ezra Sitorus > > Add support for FPMR dumps/reads for core files. > --- > Changes from v1->v2: > * Addressed comments/whitespace/formatting issues. > * gdb/arch/aarch64.h: operator() takes fpmr into account now. > * Defined HWCAP2_FPMR in gdb/arch/aarch64.h > > Changes from v2-v3: > * Formatting fixes. > * Moved initialisation of fpmr variables closer to where they are used. I think the above update is not from this patch. Maybe it is from the one that touches gdbarch? > > Ezra > > gdb/aarch64-linux-tdep.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c > index 5346ae39eda..6966dc1ab0f 100644 > --- a/gdb/aarch64-linux-tdep.c > +++ b/gdb/aarch64-linux-tdep.c > @@ -1635,6 +1635,23 @@ aarch64_linux_iterate_over_regset_sections (struct gdbarch *gdbarch, > } > } > > + if (tdep->has_fpmr ()) > + { > + const struct regcache_map_entry fpmr_regmap[] = > + { > + { 1, tdep->fpmr_regnum, sizeof (uint64_t) }, > + { 0 } > + }; > + > + const struct regset aarch64_linux_fpmr_regset = > + { > + fpmr_regmap, regcache_supply_regset, regcache_collect_regset > + }; > + > + cb (".reg-aarch-fpmr", sizeof (uint64_t), sizeof (uint64_t), > + &aarch64_linux_fpmr_regset, "FPMR", cb_data); > + } > + > if (tdep->has_pauth ()) > { > /* Create this on the fly in order to handle the variable location. */ In any case, this is OK. Thanks! Approved-By: Luis Machado