Re: [Patch v5] Add -file-list-shared-libraries MI command

Marc-André Laperle
2017-03-20T19:07:46Z

Thank you. Pushed with the typo fixed.

Marc-André

From: gdb-patches-owner@sourceware.org <gdb-patches-owner@sourceware.org> on behalf of Pedro Alves <palves@redhat.com>
Sent: Friday, March 17, 2017 12:55 PM
To: Marc-André Laperle; gdb-patches@sourceware.org
Subject: Re: [Patch v5] Add -file-list-shared-libraries MI command

On 03/02/2017 02:55 PM, Marc-Andre Laperle wrote:

> -The corresponding @value{GDBN} command is @samp{info shared}.
> +The corresponding @value{GDBN} command is @samp{info shared}.  The fields
> +have a similar meaning to the @code{=library-loaded} notification.
> +The @code{ranges} field specifies the muliple segments belonging to this

Typo "muliple".

>      /* Record the range of addresses belonging to this shared library.
>         There may not be just one (e.g. if two segments are relocated
> -       differently); but this is only used for "info sharedlibrary".  */
> +       differently).  This is used for "info sharedlibrary" and
> +       the MI command "-file-list-shared-libraries".  The later has a format

Typo: "latter".

> +       that supports outputting multiple segments once the related code
> +       supports them.  */
>      CORE_ADDR addr_low, addr_high;
>    };
>

Fix those, and you're good to go.  Please push.

Thanks,
Pedro Alves

From gdb-patches-return-137703-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Mar 20 19:55:23 2017
Return-Path: <gdb-patches-return-137703-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Delivered-To: listarch-gdb-patches@sources.redhat.com
Received: (qmail 103957 invoked by alias); 20 Mar 2017 19:55:23 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Delivered-To: mailing list gdb-patches@sourceware.org
Received: (qmail 103932 invoked by uid 89); 20 Mar 2017 19:55:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1015
X-HELO: rock.gnat.com
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Mar 2017 19:55:21 +0000
Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A4153298A8; Mon, 20 Mar 2017 15:55:20 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id uQK1QYBuWQ0L; Mon, 20 Mar 2017 15:55:20 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 74F6D298A7; Mon, 20 Mar 2017 15:55:20 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000) id C31B06077E; Mon, 20 Mar 2017 12:55:18 -0700 (PDT)
Date: Mon, 20 Mar 2017 19:55:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Nitish Kumar Mishra <mishra.nitish.88@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [PR build/21187] Static linking of libstdc++ and libgcc with GDB leads to broken exception handling on AIX platform
Message-ID: <20170320195518.zz2dbrnr72rh55yz@adacore.com>
References: <CACC+hkjOGW5d+5Q5wbkS8x7G0Y+QcksoM=8MaSTxjA3T-Oa8_Q@mail.gmail.com> <CACC+hkihgrrthwHnjaTbA33W3o0wLJyJC3W0BPQqqLfJPcCjwA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACC+hkihgrrthwHnjaTbA33W3o0wLJyJC3W0BPQqqLfJPcCjwA@mail.gmail.com>
User-Agent: Mutt/1.6.2-neo (2016-08-21)
X-SW-Source: 2017-03/txt/msg00347.txt.bz2
Content-length: 914

> This defect is marked for GDB-8.0 branching.
> I have sent the patches earlier and got some review comments, changed
> the patch accordingly and sent again, but didn't get any feedback.
> I have uploaded the patch to the defect 21187 as well on bugzilla.
> Defect: https://sourceware.org/bugzilla/show_bug.cgi?id!187
> Consider this mail as reminder and I am attaching the proposed patch once again.

Where did you send the patches? I thought you'd have sent them to
gcc-patches, but I couldn't find it in the gcc-patches mailing-list
archives...

> 2016-03-01 Nitish K Mishra <nitismis@in.ibm.com>
>
> * configure.ac: Include one more option "--disable-staticlib"
> to link libstdc++ and libgcc dynamically.

Your ChangeLog will need to include the following piece of info:

* configure: Regenerate.

Can you send us an update on the patch submission process?

Thank you,
--
Joel