From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id im+qFHuKQmiu1QIAWB0awg (envelope-from ) for ; Fri, 06 Jun 2025 02:28:11 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=i0atvs8G; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qcpncdBc; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=i0atvs8G; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qcpncdBc; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 453FB1E11C; Fri, 6 Jun 2025 02:28:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A85431E089 for ; Fri, 6 Jun 2025 02:28:10 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 558353858D33 for ; Fri, 6 Jun 2025 06:28:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 558353858D33 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=i0atvs8G; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qcpncdBc; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=i0atvs8G; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qcpncdBc Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 9BCBD3858D33 for ; Fri, 6 Jun 2025 06:27:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9BCBD3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9BCBD3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749191258; cv=none; b=CJvNpk6Rkpf3x8rsBF1AxaaZUtLBrtWJFXAbx6aZTftleWO5edm0pQdVHO1lE7PBsTo9Fmu1Fd5UQD0sJ4xfLZ4VBCd0q9st2Wbu/Yn3uuI30JQh9nxfXXkB6yOOUKuUADm5gXx662s+KaIFSsq6u09aWZ0TwJDpxkFFDvXpoHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749191258; c=relaxed/simple; bh=28IsEqaVT0XLwE+IRdqKdxZaDqs+rUXrGST5cdrHEXI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=uO7hEyeQOGtBrhKn3JyFVYAkpa3tn5+RUvNaYviZ4C/0JCS9H/uXS5qCodBo8Ox9mvj79/5F+ulJZmOW6sYxm46sM5v2VqJAFoZ6KwRxQjyoVPfyxAIbJ5NLMy29v5xR62ohhukUmUkaLAx4Jf7PQo+TnMY2RkWcKd5iZ+F8pCw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9BCBD3858D33 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 76A791F46E; Fri, 6 Jun 2025 06:27:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749191257; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QdTqUBdds6vQo09+XKir0Z2weoVTe27ki8EgThrYEyk=; b=i0atvs8GlBJVSmE3yTHwza0xk5ToYaItP/9EGFSv77Te8DiPwbVyg8sXVkVnvdg1FGq3vy 7ozOY2oQiSp3KYOnXvQSYtKlr0jLUwGEKfqLYN9wR9mWq75Dkl/zmMbCf3zqw9NekFGhnC Geg6+FxjGJ79Yk5fdeNquo/L/C74ePs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749191257; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QdTqUBdds6vQo09+XKir0Z2weoVTe27ki8EgThrYEyk=; b=qcpncdBcAO8W+0grAOmYO9siwAQJIhhvBrCFiQtRpqLPrJ21PAfMnJoEJeU/RubQBff9Ov GPWO73JUhBh2qdAQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=i0atvs8G; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qcpncdBc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749191257; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QdTqUBdds6vQo09+XKir0Z2weoVTe27ki8EgThrYEyk=; b=i0atvs8GlBJVSmE3yTHwza0xk5ToYaItP/9EGFSv77Te8DiPwbVyg8sXVkVnvdg1FGq3vy 7ozOY2oQiSp3KYOnXvQSYtKlr0jLUwGEKfqLYN9wR9mWq75Dkl/zmMbCf3zqw9NekFGhnC Geg6+FxjGJ79Yk5fdeNquo/L/C74ePs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749191257; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QdTqUBdds6vQo09+XKir0Z2weoVTe27ki8EgThrYEyk=; b=qcpncdBcAO8W+0grAOmYO9siwAQJIhhvBrCFiQtRpqLPrJ21PAfMnJoEJeU/RubQBff9Ov GPWO73JUhBh2qdAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5D6741369F; Fri, 6 Jun 2025 06:27:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id fP5OFVmKQmixWwAAD6G6ig (envelope-from ); Fri, 06 Jun 2025 06:27:37 +0000 Message-ID: Date: Fri, 6 Jun 2025 08:27:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tdep] Don't call WaitForSingleObject with INFINITE arg To: Pedro Alves , gdb-patches@sourceware.org References: <20250605150330.26246-1-tdevries@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 76A791F46E X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_TLS_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/5/25 18:25, Pedro Alves wrote: > On 2025-06-05 17:15, Pedro Alves wrote: >> On 2025-06-05 16:03, Tom de Vries wrote: > >>> Fix this by avoiding calling WaitForSingleObject with INFINITE argument. >> >> Approved-By: Pedro Alves >> > > Actually, can you add a comment to the code, please, explaining why we're avoiding INFINITE? > > LGTM with that. :-) > Hi Pedro, thanks for the review. I've added a comment, and pushed as v2 ( https://sourceware.org/pipermail/gdb-patches/2025-June/218402.html ). Thanks, - Tom > On 2025-06-05 16:03, Tom de Vries wrote: >> while (true) >> { >> - DWORD r = WaitForSingleObject (handle, howlong); >> + DWORD milliseconds = howlong == INFINITE ? 100 : howlong; >> + DWORD r = WaitForSingleObject (handle, milliseconds); >> + if (howlong == INFINITE && r == WAIT_TIMEOUT) >> + continue; >> if (r == WAIT_OBJECT_0) >> return;