From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80526 invoked by alias); 8 Jan 2019 14:29:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80516 invoked by uid 89); 8 Jan 2019 14:29:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=dear, HContent-Transfer-Encoding:8bit X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Jan 2019 14:29:36 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x08ETURv030609 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 8 Jan 2019 09:29:34 -0500 Received: by simark.ca (Postfix, from userid 112) id 287101E7B7; Tue, 8 Jan 2019 09:29:30 -0500 (EST) Received: from www.simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id E0FD81E4C0; Tue, 8 Jan 2019 09:29:28 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 08 Jan 2019 14:29:00 -0000 From: Simon Marchi To: Nick Clifton Cc: gdb-buildbot@sergiodj.net, gdb-patches@sourceware.org Subject: Re: Oh dear. I regret to inform you that commit 053af8c9034f92d6e36a1180655ba22a65c56437 might be unfortunate In-Reply-To: References: <053af8c9034f92d6e36a1180655ba22a65c56437-master-breakage@gdb-build> <3f3e538c74685b15579bf913aa764067@polymtl.ca> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00148.txt.bz2 On 2019-01-08 06:24, Nick Clifton wrote: > Hi Simon, > >>> As you can see, GDB needs to be adjusted to stop using > > Sorry - I totally forgot to check the effect that the change would > have on GDB. Mea culpa. > >>> test it, get it reviewed).  Would you mind reverting this patch, just >>> the time we adjust the GDB code? > > Not at all. In fact I see that you have now done so. > >> I ended up reverting this patch to unbreak the build.  I'll try to >> update the GDB code shortly to unblock it (or if somebody else is >> motived, I don't mind). >> >> When re-syncing the code with GCC, note that there are corresponding >> changes to include/demangle.h that should be imported too. > > Yes, I missed that too. :-( There is also an update to the > binutils/testsuite/binutils-all/cxxfilt.exp file that needs to go in > to fix the tests for targets that use an > underscore prefix to their symbol names. Also, once demangle.h is > synchronized the > binutils/cxxfilt.c source file will fail to build because it checks > for redacted demangling > styles. I have patches locally to fix both of these problems, which I > can supply to > a committer or else check in myself. Ok, thanks for the update. You can check in the binutils bits right now if you want. Simon