From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Oj/oGRGR9miPmAAAWB0awg (envelope-from ) for ; Mon, 20 Oct 2025 15:44:17 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=fX7qeYrn; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 592241E047; Mon, 20 Oct 2025 15:44:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BADEB1E047 for ; Mon, 20 Oct 2025 15:44:16 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 405C93858D21 for ; Mon, 20 Oct 2025 19:44:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 405C93858D21 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=fX7qeYrn Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 9F4983858C20 for ; Mon, 20 Oct 2025 19:41:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F4983858C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9F4983858C20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760989303; cv=none; b=ebPhcysdMUUmZJsDmCJgjxL+DKIJmNCBmkL6JnQtuj9tDsmqPkGc5G1qDyBYFoYxO4oTR5GmDAu035jpscIPLn+Lzck/rfIE51mJXVlr+YIvMwkdhYtakdNbgPEBK7IeSIM/NFlLUerIoO4DW4RDc6LXOjw8iU0q1viA19cka6M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760989303; c=relaxed/simple; bh=hxY/MJGMzMKHec5p1+1VI2pLRCxMxtCHX7tSQsHU/cs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=q0izE5D5irUmDSYnmt3b4ph0C5sst7YIDV9kEyHNCMZbvnjDW/AZYhGkCLe48mfvaq4feqx8cJYhkKVrGQP9fv4KKc+OuYHgAETK1TLL9OXKjp48C2Z2/cme2HTQcw7nawdNFQtOGRzhRrvcHjsqN65t3iRRZDsL+84FsKu17oU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9F4983858C20 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 59KJfVSE014503 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Oct 2025 15:41:36 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 59KJfVSE014503 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1760989296; bh=T6m4FUrTYW1S9y3XTbZ5UBo6ByQFg1m9wppr/2OMaG8=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=fX7qeYrnXn8dVh4Gsm9EvWDs/pYSK80bNCXIfu38nNIKmoZW/L2VMvLUahLKGNfxK x/pdHC+1kP4BWCagpH7D4x/re30DVEA4D5rdDrKVYTOwOSYlRyGLUvt+whM+04l+yA AtgrFbFLB1RBzPpcZ3J3hNfJWddHesXbkJG7jGPqd1Ou5I5Y36a7zbNGW5/VreBwCt cwEMWIDLCPKfm/6gCIaElXMpLSMmOIYSUUbEKwuovkREV2AVzGSNrrQS+nXB8tR6HK 8I+lO3u68308H1vSUUFMGLVpjcZhRxESn61DzcKMJQW1u1At5OHyN3RNy4b5xeaF2w JT3OXqrz+PStQ== Received: by simark.ca (Postfix) id BE9C91E047; Mon, 20 Oct 2025 15:41:31 -0400 (EDT) Message-ID: Date: Mon, 20 Oct 2025 15:41:31 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/10] Rename some symtab find functions To: Kevin Buettner Cc: gdb-patches@sourceware.org References: <20251016001154.3969223-1-simon.marchi@polymtl.ca> <20251018210702.18409872@f41-zbm-amd> Content-Language: fr From: Simon Marchi In-Reply-To: <20251018210702.18409872@f41-zbm-amd> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 20 Oct 2025 19:41:32 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/19/25 12:07 AM, Kevin Buettner wrote: > On Wed, 15 Oct 2025 20:07:54 -0400 > simon.marchi@polymtl.ca wrote: > >> From: Simon Marchi >> >> I have long been confused by the names of the functions to look up >> things in symtab. For a function named find_foo_bar, it's not obvious >> if it finds a foo from a bar or vice-versa (answer: it finds a bar for a >> given foo). When asking around on IRC a while ago, a few people agreed. >> I'm therefore proposing to rename those functions to be of the form >> find_bar_for_foo. >> >> Simon Marchi (10): >> gdb: rename find_pc_function -> find_symbol_for_pc >> gdb: rename find_pc_sect_function -> find_symbol_for_pc_sect >> gdb: rename find_pc_sect_containing_function -> >> find_symbol_for_pc_sect_maybe_inline >> gdb: rename find_pc_compunit_symtab -> find_compunit_symtab_for_pc >> gdb: rename find_pc_sect_compunit_symtab -> >> find_compunit_symtab_for_pc_sect >> gdb: rename find_pc_line_pc_range -> find_line_pc_range_for_pc >> gdb: rename find_pc_line -> find_sal_for_pc >> gdb: rename find_pc_sect_line -> find_sal_for_pc_sect >> gdb: rename find_pc_line_symtab -> find_symtab_for_pc >> gdb: rename find_line_pc_range -> find_pc_range_for_sal > > I wholeheartedly approve of these name changes. Over the years, I've > been confused by these names too. > > Approved-by: Kevin Buettner > Thanks, pushed. Simon