Re: [PATCH] Fix "set debug parser"

[Tom de Vries <tdevries@suse.de>]

On 4/27/25 01:12, Tom Tromey wrote:
> +gdb_test_no_output "set debug parse 1"
> +set saw_start 0
> +gdb_test_multiple "print 23" "print with debugging" -lbl {
> +    "Starting parse" {
> +	set saw_start 1
> +	exp_continue
> +    }
> +    -re ".$decimal = 23" {
> +	gdb_assert $saw_start $gdb_test_name
> +    }
> +}

Hi Tom,

I looked at the test-case part, and noticed a few things:
- the "Starting parse" is without -re prefix (I didn't realize that was
   allowed)
- the gdb_test_multiple doesn't consume the prompt, which causes
   problems for subsequent tests (currently none)
- the matching strings allow sub-line matching.

I initially fixed the prompt consumption part by adding -wrap to '-re 
".$decimal = 23"', but that makes it a two-line pattern which doesn't 
work with line-by-line matching.

So, I get to this fixup patch:
...
diff --git a/gdb/testsuite/gdb.base/exprs.exp 
b/gdb/testsuite/gdb.base/exprs.exp
index 81e78e50e62..99bb277913c 100644
--- a/gdb/testsuite/gdb.base/exprs.exp
+++ b/gdb/testsuite/gdb.base/exprs.exp
@@ -287,12 +287,17 @@ gdb_test "print v_short =}{= 3" \

  gdb_test_no_output "set debug parse 1"
  set saw_start 0
+set saw_val 0
  gdb_test_multiple "print 23" "print with debugging" -lbl {
-    "Starting parse" {
+    -re "\r\nStarting parse(?=\r\n)" {
  	set saw_start 1
  	exp_continue
      }
-    -re ".$decimal = 23" {
-	gdb_assert $saw_start $gdb_test_name
+    -re "\r\n.$decimal = 23(?=\r\n)" {
+	set saw_val 1
+	exp_continue	
+    }
+    -re -wrap "" {
+	gdb_assert { $saw_start && $saw_val } $gdb_test_name
      }
  }
...

I suppose I would do:
...
set re_var [string_to_regexp "$"]$decimal
...
and use it here:
...
     -re "\r\n$re_var = 23(?=\r\n)" {
...
but I guess that's personal preference.

Thanks,
- Tom