From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id jg3cJz3O2GmAYhAAWB0awg (envelope-from ) for ; Fri, 10 Apr 2026 06:17:33 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Mv78Va0b; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2IR/srNb; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Mv78Va0b; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2IR/srNb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 875D81E0BC; Fri, 10 Apr 2026 06:17:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A8EE91E08C for ; Fri, 10 Apr 2026 06:17:32 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 6B5A14BA23C0 for ; Fri, 10 Apr 2026 10:17:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6B5A14BA23C0 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Mv78Va0b; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2IR/srNb; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Mv78Va0b; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2IR/srNb Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 6243E4BA2E19 for ; Fri, 10 Apr 2026 10:17:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6243E4BA2E19 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6243E4BA2E19 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775816226; cv=none; b=GPzUuhT7H3rD4XbtmxvgXtRJM4jKOlMgeCi8IoJiQmXmKWwO4Qq1R204DSfZfPRxnSvlkl8sx5jjencX+t1aMOiTzCPrwqJD6Fa2rbdoo6XzfPrQVvJuG6oKf7MLWbH3pe+gfmwzlLa5S0m2LH6OUmhJ30Om838oRBljm/Ut1mQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775816226; c=relaxed/simple; bh=rjRqBGFUXxRyKA5qQDmeBz4uePTNHeYRciMsS2N/6Oo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=hpbaM+2ZrRV+R7WODt+Zuom/Hm6WrNOA2nljX85xaM9SS5m2tHLQEIdoUl8aqN6odjjYlTiaL89q1cxkKAZh6VN4T+Si33XS6pJs+XaJtSkukqaYTe4g6Qnr5DT8g8ZONMz+X1F7i8MCCJihoUjiIh4y4MpiPxHkgh4xDc7j+BU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6243E4BA2E19 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 625E16A7EC; Fri, 10 Apr 2026 10:17:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775816225; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j8vqPuz5v3mfIAv1P7ZKDxrHSNNiP88jfe3zPCQBBBA=; b=Mv78Va0bvgIcK529BIGL6pW/Ym/OjyBHNYxJSn09LWjDaneX/+mAn15Vj3phOxG1fWVV1P JVqv9zXn3S7ouf4ETKC/b3PoDgZADd3239PeMGjpJH4gNhbo4SHaSUrDhOBrGGjxLNe1Kz qPSYxV1fnJLF9L3RsPtZzg7PxzYvODM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775816225; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j8vqPuz5v3mfIAv1P7ZKDxrHSNNiP88jfe3zPCQBBBA=; b=2IR/srNbwVtTp7tjt9+b/u2m8w/ffsiesZIrSNI2o+aSe4yFyaaU0+40hIgAsRZM1Uho2d VQlQw4KiEhdvXLAw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775816225; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j8vqPuz5v3mfIAv1P7ZKDxrHSNNiP88jfe3zPCQBBBA=; b=Mv78Va0bvgIcK529BIGL6pW/Ym/OjyBHNYxJSn09LWjDaneX/+mAn15Vj3phOxG1fWVV1P JVqv9zXn3S7ouf4ETKC/b3PoDgZADd3239PeMGjpJH4gNhbo4SHaSUrDhOBrGGjxLNe1Kz qPSYxV1fnJLF9L3RsPtZzg7PxzYvODM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775816225; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j8vqPuz5v3mfIAv1P7ZKDxrHSNNiP88jfe3zPCQBBBA=; b=2IR/srNbwVtTp7tjt9+b/u2m8w/ffsiesZIrSNI2o+aSe4yFyaaU0+40hIgAsRZM1Uho2d VQlQw4KiEhdvXLAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4A9164A0B2; Fri, 10 Apr 2026 10:17:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id jUvLECHO2Gk0bQAAD6G6ig (envelope-from ); Fri, 10 Apr 2026 10:17:05 +0000 Message-ID: Date: Fri, 10 Apr 2026 12:17:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb: use get_current_frame consistently in print_stop_location To: Andrew Burgess , gdb-patches@sourceware.org References: <20260331132342.1050954-1-tdevries@suse.de> <640943dbfd2e2d6555be950b04a4c50288e3334a.1775383137.git.aburgess@redhat.com> <337213ec-dce2-47d2-b04a-21aaf3d849dc@suse.de> <87o6js4ipn.fsf@redhat.com> <4a5043ae-0554-4d09-b426-d42d5d66d972@suse.de> <87fr5342gs.fsf@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87fr5342gs.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo,sourceware.org:url]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:mid, suse.de:email] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/10/26 10:57 AM, Andrew Burgess wrote: > Tom de Vries writes: > >> On 4/9/26 10:54 AM, Andrew Burgess wrote: >>>> So I'm proposing a change to this patch (attached below, doesn't apply >>>> to the first but to the second patch) that: >>>> - introduces a variable print_frame >>>> - assigns get_selected_frame (nullptr) to print_frame >>>> - adds a comment explaining how print_frame relates to the stop frame >>>> - uses print_frame everywhere in the function >>>> >>>> I tested the series in combination with the attached patch on >>>> x86_64-linux, and found no regressions. >>> Thanks for the great analysis, and explanation, I wasn't aware of this >>> aspect of bpstat_print. Given this new information, I think your patch >>> is the right solution. >>> >>> Approved-By: Andrew Burgess >> >> Hi Andrew, >> >> my initial idea here was that the patch I posted could be trivially >> merged with the first patch, but upon attempting this I ended up >> re-editing the series. I'm currently testing this, and will submit if >> that goes ok. >> >> The content of the patch series should be what you posted plus >> aforementioned patch, the changes I made are merely refactoring. > > The patch you posted applies on top of my patch #1, but I think it would > be best if you just merged those two patches together. As you point > out, my patch moves in the wrong direction. You're patch basically > reverts mine and does something different, which is the right thing to > do. The problem with doing so is that it makes the first patch nonsensical, in the sense that it results in using the selected frame in one part of the condition, and the stop pc (corresponding to the current frame or stop frame) in another part of the condition. So I ended up moving the patch to the end of the series. Submitted here ( https://sourceware.org/pipermail/gdb-patches/2026-April/226422.html ). Thanks, - Tom