From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102854 invoked by alias); 17 Dec 2019 19:41:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102844 invoked by uid 89); 17 Dec 2019 19:41:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Dec 2019 19:41:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576611695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=emZ/atXxqpRnUhY7/RiunPDfqEp6afYHF8K9L+isfzk=; b=iz/Gi+524MgdKajI/wIk9Hdf+QKp2R0/DpCHy1gdxtu4ZPJZu63DJFCUdC+zmriVy4uzuD X6IYgBGiFOqhcTdMRIVcQ41j/shXd4ZUAAKaJPimE7fjdR6xs7pufRVeIejHU44mMgOuhl twl8ApdS5USjztGQfgR6WT49bRcO8ck= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-122-aTbIN750OnOWCZonATOo2w-1; Tue, 17 Dec 2019 14:41:32 -0500 Received: by mail-wm1-f71.google.com with SMTP id p2so1270826wma.3 for ; Tue, 17 Dec 2019 11:41:31 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id o66sm4244928wmo.20.2019.12.17.11.41.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Dec 2019 11:41:30 -0800 (PST) Subject: Re: [PATCH] Fix indentation (and clang warning) in c-lang.c To: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org References: <20191216233637.29925-1-simon.marchi@efficios.com> <6663a453-29d5-e38f-4f47-30c2ff18c331@simark.ca> From: Pedro Alves Message-ID: Date: Tue, 17 Dec 2019 19:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <6663a453-29d5-e38f-4f47-30c2ff18c331@simark.ca> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-12/txt/msg00754.txt.bz2 On 12/17/19 7:39 PM, Simon Marchi wrote: > On 2019-12-17 2:24 p.m., Pedro Alves wrote: >> Curious. Are you saying that that changed recently in clang? I wonder >> whether clang's warning catches this case on purpose, or whether it's >> a regression. I asked David Malcolm, who added that warning to GCC, and he >> said that GCC's implementation respects tab stops, so small numbers of >> leading spaces before a tab are effectively ignored. > > The warning appears to be new in clang 10, because it doesn't exist in clang 9: > > $ clang++ test.cpp -Wmisleading-indentation > warning: unknown warning option '-Wmisleading-indentation'; did you mean '-Wbinding-in-condition'? [-Wunknown-warning-option] > > I can't tell if it's on purpose or not. I wonder if it's worth opening a bug > on clang's bugzilla to ask whether it's intentional or not, it might help them > tweak the warning before it's officially released... Yes, I think it's worth it. Part of the point of using pre release compilers is to catch&fix issues before they are released. Thanks, Pedro Alves