From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69325 invoked by alias); 9 Oct 2016 17:01:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69302 invoked by uid 89); 9 Oct 2016 17:01:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sbrk, business X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 09 Oct 2016 17:01:51 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7001685543; Sun, 9 Oct 2016 17:01:50 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u99H1mNc003468; Sun, 9 Oct 2016 13:01:49 -0400 Subject: Re: [RFA 11/22] Change command stats reporting to use class To: Tom Tromey , gdb-patches@sourceware.org References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-12-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: Date: Sun, 09 Oct 2016 17:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474949330-4307-12-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00196.txt.bz2 On 09/27/2016 05:08 AM, Tom Tromey wrote: > This removes make_command_stats_cleanup in favor of an RAII class. > The patch is reasonably straightforward, but keeping the same > semantics required reindenting much of captured_main. Did you try splitting the reindented code to a separate function instead? Like: -captured_main () +captured_main_1 () { ... existing code, except the command stats business } captured_main () { #ifdef HAVE_SBRK /* Set this before constructing scoped_command_stats. */ lim_at_start = (char *) sbrk (0); #endif { scoped_command_stats stat_reporter (0); captured_main_1 (...); } /* NOTE: cagney/1999-11-07: There is probably no reason for not moving this loop and the code found in captured_command_loop() into the command_loop() proper. The main thing holding back that change - SET_TOP_LEVEL() - has been eliminated. */ while (1) { catch_errors (captured_command_loop, 0, "", RETURN_MASK_ALL); } } I imagine that results in a much smaller diff, and probably clearer code. Once someone fixes that NOTE, then we can even remove the extra scope around scoped_command_stats. Or if we fixed that NOTE before this patch, then we wouldn't need the separate function nor the reindenting at all. Thanks, Pedro Alves