Re: [PATCH 1/2] typeprint.h: reorder struct declaration

[Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>]

Hi

On 31/12/2020 12:53, Lancelot SIX via Gdb-patches wrote:
> Move the declaration of struct type_print_raw_options before struct
> print_offset_data to ease upcoming changes. This is a helper commit
> intended to make it easier to build a print_offset_data object from
> configurations given by a type_print_raw_options.
>
> gdb/ChangeLog:
>
> 	* typeprint.h (struct type_print_options): move before
> 	  print_offsetdata

Just realized I had formatting issues here. I’ll change that ASAP, with 
other elements that might come with reviews.

When doing such modification, do I re-send the entire patches series or 
just the one affected? (I am not yet familiar with working with 
mailing-list based workflows).

BR

Lancelot

> ---
>   gdb/typeprint.h | 60 ++++++++++++++++++++++++-------------------------
>   1 file changed, 30 insertions(+), 30 deletions(-)
>
> diff --git a/gdb/typeprint.h b/gdb/typeprint.h
> index d595cbe208..b75fa4d9f2 100644
> --- a/gdb/typeprint.h
> +++ b/gdb/typeprint.h
> @@ -26,6 +26,36 @@ struct ui_file;
>   struct typedef_hash_table;
>   struct ext_lang_type_printers;
>   
> +struct type_print_options
> +{
> +  /* True means that no special printing flags should apply.  */
> +  unsigned int raw : 1;
> +
> +  /* True means print methods in a class.  */
> +  unsigned int print_methods : 1;
> +
> +  /* True means print typedefs in a class.  */
> +  unsigned int print_typedefs : 1;
> +
> +  /* True means to print offsets, a la 'pahole'.  */
> +  unsigned int print_offsets : 1;
> +
> +  /* The number of nested type definitions to print.  -1 == all.  */
> +  int print_nested_type_limit;
> +
> +  /* If not NULL, a local typedef hash table used when printing a
> +     type.  */
> +  typedef_hash_table *local_typedefs;
> +
> +  /* If not NULL, a global typedef hash table used when printing a
> +     type.  */
> +  typedef_hash_table *global_typedefs;
> +
> +  /* The list of type printers associated with the global typedef
> +     table.  This is intentionally opaque.  */
> +  struct ext_lang_type_printers *global_printers;
> +};
> +
>   struct print_offset_data
>   {
>     /* The offset to be applied to bitpos when PRINT_OFFSETS is true.
> @@ -73,36 +103,6 @@ struct print_offset_data
>   			 const char *for_what);
>   };
>   
> -struct type_print_options
> -{
> -  /* True means that no special printing flags should apply.  */
> -  unsigned int raw : 1;
> -
> -  /* True means print methods in a class.  */
> -  unsigned int print_methods : 1;
> -
> -  /* True means print typedefs in a class.  */
> -  unsigned int print_typedefs : 1;
> -
> -  /* True means to print offsets, a la 'pahole'.  */
> -  unsigned int print_offsets : 1;
> -
> -  /* The number of nested type definitions to print.  -1 == all.  */
> -  int print_nested_type_limit;
> -
> -  /* If not NULL, a local typedef hash table used when printing a
> -     type.  */
> -  typedef_hash_table *local_typedefs;
> -
> -  /* If not NULL, a global typedef hash table used when printing a
> -     type.  */
> -  typedef_hash_table *global_typedefs;
> -
> -  /* The list of type printers associated with the global typedef
> -     table.  This is intentionally opaque.  */
> -  struct ext_lang_type_printers *global_printers;
> -};
> -
>   extern const struct type_print_options type_print_raw_options;
>   
>   /* A hash table holding typedef_field objects.  This is more