From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77404 invoked by alias); 26 Apr 2017 18:43:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77382 invoked by uid 89); 26 Apr 2017 18:43:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Apr 2017 18:43:56 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1d3Ruu-0004qs-TN from Luis_Gustavo@mentor.com ; Wed, 26 Apr 2017 11:43:56 -0700 Received: from [134.86.105.110] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 26 Apr 2017 11:43:54 -0700 Reply-To: Luis Machado Subject: Re: [PATCH v2] Make environ.exp run on all platforms (and create info-program.exp) References: <20170331172901.23402-1-sergiodj@redhat.com> <20170425204727.19158-1-sergiodj@redhat.com> To: Sergio Durigan Junior , GDB Patches From: Luis Machado Message-ID: Date: Wed, 26 Apr 2017 18:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170425204727.19158-1-sergiodj@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-08.mgc.mentorg.com (147.34.90.208) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00711.txt.bz2 On 04/25/2017 03:47 PM, Sergio Durigan Junior wrote: > Changes from v1: > > - Fixed regex of "show environment". > > - Make regexes of "info program" more flexible (for bare-metal > targets). > > > This has been on my TODO list for a while. There's a really old bug > about this (PR testsuite/8595), and there was no reason for > environ.exp to be specific for hppa* targets. So this patch removes > this constraint, modernizes the testcase, and cleans up some things. > Most of the tests remained, and some were rewritten (especially the > one that checks if "show environment" works, which is something kind > of hard to do). > > As a bonus, I'm adding a separated info-program.exp file containing > all the tests related to "info program" that were present on > environ.exp. > > Tested locally, everything still passes. > > gdb/testsuite/ChangeLog: > 2017-04-25 Sergio Durigan Junior > > PR testsuite/8595 > * gdb.base/environ.exp: Make test available in all architectures. > Move bits related to "info program" testing to > gdb.base/info-program.exp. Rewrite tests to use the two new > procedures mentione below. > (test_set_show_env_var) New procedure. > (test_set_show_env_var_equal): Likewise. > * gdb.base/info-program.exp: New file. > --- > gdb/testsuite/ChangeLog | 11 ++ > gdb/testsuite/gdb.base/environ.exp | 302 ++++++-------------------------- > gdb/testsuite/gdb.base/info-program.exp | 45 +++++ > 3 files changed, 105 insertions(+), 253 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/info-program.exp I get full passes with gdb.base/environment.exp now, but gdb.base/info-program.exp is still failing. FAIL: gdb.base/info-program.exp: info program after run to main FAIL: gdb.base/info-program.exp: info program after next FAIL: gdb.base/info-program.exp: info program after deleting all breakpoints By removing the initial \t from the patterns of these 3 tests, i get full passes for gdb.base/info-program.exp as well. Luis