From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ST58DH1N4ml8AR8AWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 11:10:53 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=QH5I8CY8; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2E42E1E093; Fri, 17 Apr 2026 11:10:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A22DD1E093 for ; Fri, 17 Apr 2026 11:10:52 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 43B024CCCA30 for ; Fri, 17 Apr 2026 15:10:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 43B024CCCA30 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=QH5I8CY8 Received: from YT5PR01CU002.outbound.protection.outlook.com (mail-canadacentralazon11021085.outbound.protection.outlook.com [40.107.192.85]) by sourceware.org (Postfix) with ESMTPS id 257544CCCA13 for ; Fri, 17 Apr 2026 15:04:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 257544CCCA13 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 257544CCCA13 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.192.85 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776438299; cv=pass; b=bKc9CWdHj3rHeLEL0GgGtPdQ0yJ1O+L1EjM0kYLs8La/GhTm2uYei1AYJPhEIYsk6vdCq+X4Tu7KO8Qwco53b+3TFtg2qFRNKdZ7AwrNLaXXhens2/eGJJxcuptuFKNM7mxH36nnb+uLTNyRzRqs77juCw9qD0dMVwWMVyWVeck= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776438299; c=relaxed/simple; bh=0PW8y4Dnypk+8YiRMrIsw8WzBOxfKwJd/HY7/Suh+pk=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=U653BQI8axc8HC9ZxkxMwLEn4F0ewOUs0H77EUf0Jg8xtNlNES0jNe0rg6ok8TWZYs3IEMi18W/eQ+/67vlovLnpYVj7OALQRLxMVwuTzsAfG1UjHAllz0iQh3nbm1j9F54bHvKiLN+gV3qxChI4fKYYu6KTNSWrPoI/CoFl4f0= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 257544CCCA13 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GBFu8KYPV2l1sr2QFXRn9IvOj/ZxlEO+KzBQuDOU2J9ep4J4tLML41PdC4LzLWNTe+b5aP0mXXToulDYFGshN8SDdlGDjBP4Cd9/CHqEmKGUAX6HW0eIbQTXhywItpKQS4UrKXh19bUa37IcaOZyjGnHY6ZMJ/zNujb134DDE3tnW+gn5YvDprK0q/fl/u4e4DUjporfpOYHerFdwffLxxH5fN50DbO3ifkle5H96xCSqt1OJ/tMgYJbOtpGb1mwSJ7cRp0jyn1Cgk4kRTol5WqEURlbU4SmxV5C2LyJZEhek/4bM9+tuGpXqKXOCzAMAb6k+fY1epgYZX4QeZThhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TeqBj9r6rcECzehxRqu6pBHecc/9JKp90YUhO9VIFEc=; b=r/ngBAAaCiwdukv9eycmBhKKI9r6dOPswRYbXWOpMGJYjR3v6cFT8VpUDSBBjMV/P8BcoRb3ZoqxBOSHIBZ8NEcwphsFJIMRsOAK5Ref7R6IL14ev3kf5geOMtZNbvB5PGQ+i5By6E1ki5u/EbEffJCqDHl3CZbdI5Tdop38BYyUTC9Wmk3lpzS9sgvb3SScKC6yhkYsqvYWUcJ8gTBXnRMkXHl8eJP94btlwMrrIreuzxogXS+banoZsv4tb51zNTr7Ezy57dzf5VJd/qmWaqz1whxLYTUdPc+A9xt3jP4EeiA4/UzhUpf7TW1rsYx+WPa403Q798yC84pT7/TRAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TeqBj9r6rcECzehxRqu6pBHecc/9JKp90YUhO9VIFEc=; b=QH5I8CY8r0nRqTl5i/GjjRLAgx/IIR5PAl1uCjZbEuDKfoIY0Y1p6L97Sn1FYjbPbZRF9nd/8wvcNV0LNn7pHzsaBnKkXatn5ZooQBtEJyc2a/F3bU0e0h9fU208yJ0PSeczO1pUkJhf+E1nv+EHXpDzClQkNZyQSvDMMDDES3++/nS2ytyLT2EczhT+UDqePB5t8xAQffBTM8DBXvzp4Fo/w07seecL1Z5K2y+nN99mp32TKCvhWeJYIaj7cqHMcD8/lNoCSJX/016sdFyI+dMExIvl6+QvrC45XjAvS+/yDwk9J9hj+J/0iq8fr07ntuLCmJQWoVOQmWm2hMQqkw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YTZPR01MB11974.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:16e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.25; Fri, 17 Apr 2026 15:04:55 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%5]) with mapi id 15.20.9818.023; Fri, 17 Apr 2026 15:04:55 +0000 Message-ID: Date: Fri, 17 Apr 2026 11:04:53 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/11] gdb: make symbol_found_callback_ftype a function_view To: Andrew Burgess , gdb-patches@sourceware.org Cc: Simon Marchi References: <20260416202408.422441-1-simon.marchi@efficios.com> <20260416202408.422441-11-simon.marchi@efficios.com> <875x5pelne.fsf@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <875x5pelne.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0349.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:6b::14) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YTZPR01MB11974:EE_ X-MS-Office365-Filtering-Correlation-Id: a8e57e49-d14f-42cd-1a25-08de9c92af73 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|1800799024|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: 8vcAkXG+2np0Pehl7hSppCm4z//N7k8cMvpYVmQLsFpAfwOCCYAGgiyq0bJyecbRvLNFLhj1PwKGz4aTX6dojgGDZF4ivuNpggGQyZguAw2Skg6VEVQRCSvCugTQo+9LDQrubs7DtI8Z1TsW8a8kMIEOsNXaq5shCbihol9AAuKKV7VmOg0Ct9+hYa1blBYLP9BsRYLSW5vsiOqWHEogeKFSAcYz6j/I9K01p++TP9vMXSgBEecXvtO44cMWYq8W9pfvKGulW7izpKWrfbjCjl/9zauny4HcaTHhonKUYRqsTPgGUwVjRV+57/zPI8eAO69PGwD/UrPrknbJbHifnvB9k4FVB3JV2j3hQH403A1846mewSBApx4j8h9n+xWFR3JwQZs6gM2yh7SyLSRIFQqUjiw28QbZLF6E/xGjYdFhMUgir3FJoMfLSJGYv50IdMHIdQ8SxHw9LwBvXimq2os9jtDHkyB1u6wlOah6ccjq8MN/ix0A+TZ0oOQfvO3HVHPUHugnxMXAPAgoYjukS9SKqiOSl+6c6kd2cMIR+Pz2/AVQKZxC4E5H5wgPw4xPp8N25W61ifS7GrGKtRI9L3rAxFjCPRXnme5MXnJGH3SHW54NMdoLY7xV33sNqc58O4b1soxCVVd5WjTUenbsiqBsel7LufN97Yvg9oHCBs1wtrZLBwBCRiulhqWeKndXvJSONxH26QRs7LY/5A3l5MrEgz5Eaa7wdnRIKO07mws= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(18002099003)(56012099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cW43cUpqdW1jcDV4ZW01TVBLbGhJUGQxei9qSnE5aHBkNk9WcnZkcUIyc09P?= =?utf-8?B?djg5d2dieElDem1Zd0JjZS9hdThTdTZONlBaTjRjZXpmeFNEdWRBZWg4a3lX?= =?utf-8?B?d2dPRUdReXBpdkxCU3d4MlF2QXlKTThDQnAwak9SQ0pVZHpoNkNwYWxaUXow?= =?utf-8?B?UFYrK3dCalhyTWR0ai9OMUZTRzVtMjEzaDNHSzRzaGhIby9UalJIemo1VnJj?= =?utf-8?B?WWxwR0IyNW9VVUJzemtwbzVVbkxFMVg2clR3TGxnbGV5eEQzakxJTkIyUDRj?= =?utf-8?B?QUt6MlAwSUhwWG9lWDl5Y3NzdzRJZk5zMVdtWUprdU1zVTFMV2NyVFR6RU5V?= =?utf-8?B?NTFVRVdVOE1BajFRbURKLzRCeHBCb1QvdHdlUnFveVFYSjZwS3pwWjNMbEl4?= =?utf-8?B?MXRKQzhiRWxwV1lFZjIrL1RIK3BuZ3dSMDRtKzJwUG1XSW5zZGRTZjJUQk0w?= =?utf-8?B?dlZQMFg0ZVNTbU9uQWVJQkhCMzRDTHZwa1dWdnRNdXB3aWhBemFoY3BDenVm?= =?utf-8?B?NWRQYm1jMGwzdWt2QzlzRzlLWDM4NnNpNWg4N2NIeFozVmlvVURCR0tOMG51?= =?utf-8?B?TUo2QUN3ZGowTm02a3JQVnhBTXZGNGgyb1psQ0RXU2xkTHp0ZmR3ZW1ObmFo?= =?utf-8?B?aTl0eTlEVkZLa3k0WXduaWJBOHRzYTBBTU5LaTlDSjFKYlIranUvamtPUzNS?= =?utf-8?B?WEpNMXNTTjlId2dSYm1GK3l6OUFoVDNFdDVBUk51L1E3MW1Xa0hic09INU1Q?= =?utf-8?B?MnIvVXJEYTlUamkrTmVkMG9KMHZZOEVwSStqZ0xUYnVpY09uQWtzbVc4Z0h3?= =?utf-8?B?UmovODBNRG1jTTdiby9qdlRpVUhZZ1dkU09TMytwVzdtUGRIZW45NXpyYnZm?= =?utf-8?B?TlhwMmtCRTFJUDVDcndvamNpb0JHZ09ZSzBraVV4TXhMeU9wbjVucktMdk1M?= =?utf-8?B?dnhRNExkZ1V4akpXWlVyYUIydnFlcUpiQlAxeDNTaU9PR1dqQWhlQVN1blg5?= =?utf-8?B?S3hiajZtRW1ES2ZoK25UOU9pZHF5aGRBM240Y255QXIwdVY4dnA2WXUyQkdF?= =?utf-8?B?OXNyVFRobWtuUkFrUXFDNU84TEtNdnVtd0dPUVNwaVJ3N0xtTzBHeXM5Q2lD?= =?utf-8?B?UmtxQjZiUSt3UU9rZkg1UStYNUl6Q09EdGVlbHFyalQ5aWNOeWxtYTBSLzVa?= =?utf-8?B?QkRNOERob2FpYUc3bHhLQmFCMHdiL1EyTnZUZDV2TlVMd3pHVFJOdkR6NHNu?= =?utf-8?B?VkE4aHZ4ckFPY2RxTVgwQUxSeUZWOUx5U3NBTEtLNlFlMVV4VWQwbjJkbHVT?= =?utf-8?B?WlFxeVRoOEZqb3p1N3ZlSCtUM1J0N0xXSEMybmhrUGpkc0oxbTVYWVBZaDV3?= =?utf-8?B?SlZpNnFnNkJiY2pnSWZKQm1BRVlHSnpxRGI0SER5ekRkK2RjdnpWR1FWREFG?= =?utf-8?B?YitrT0JKaCtFRlNQTWpPYUtnL0tKTkpMRHhGcjdOMHYxdjNJeG9qOUpKZ2VB?= =?utf-8?B?ZHhLdmJybThiN2MzNk9la0hiTzhoVU5xeTcvc2l6ZmFVQjJ1TmZnS2R3NXYv?= =?utf-8?B?enNTTWZKNlZYNmhndTltTGoxa2Fjbk9vTStQcEZKYkxiYTUyaFU2bzR5R2VZ?= =?utf-8?B?alZrWWZ4Y0J6dFFxNE5SakJHVW8xeEg5SjMwSnJScHVyUDVpM2lmQksrOVJ6?= =?utf-8?B?ajdteTNPUVV5eDJicXFhbUk3R0xidnM1aTgwTE1WUmN3R2kyT1RYKzlPUHdx?= =?utf-8?B?bmEyVG9JdUsrVHV4MERsS1FxVjNLQVFMWGRKQjJad0Rod3N2Snc4RVAwcCsy?= =?utf-8?B?K2toNVhINXFEU3ZoWU9RdEhtRFAzejlMbEIyaE5Zb1hmV2ozZmlLMVdhdm5V?= =?utf-8?B?S1hFa3JpclJna0U0VWN0dWNQYUdXV0g5K1NKS0VldUxoVVdIMEF5WWJ1ODNC?= =?utf-8?B?TzhqRFdMTHByNEtzOXQ1UUt5SjFERFVpTEN5bjdKVWpsSUl0WDlGdjdkdHJh?= =?utf-8?B?RlhjcVB2a3k0b01EM0ZOL1pBVmJOS3YyK0hmNkNwTm5UYisyYXUySlpEazlE?= =?utf-8?B?eGtETEM1ejMrenlGYU1iY3UwZjFkMzR5T0ZYQlIxZmlReVpTcmw5RGhyOWRj?= =?utf-8?B?UFJzOTZaZjdMcGg0TGRHdStDZm1kQ24xRUlDN2M4aDNDazU2MU12c1diU1Bh?= =?utf-8?B?R2ljZ3dlcEFRK2J6UUMzeHNtZ2RmUnovM00wREFqWjZKNjluSDR6V3hhT1dm?= =?utf-8?B?a3lIM0hkcDNnS25aUVZyb3VkVjV0amkzWEVDK1N5Z1ZhWTIzbXlmUzZFSjdN?= =?utf-8?B?OEtQL0dOak12UVdiUUhLMUo2WlFiVlozRndGVzdSQUExdHFUYWZpQT09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8e57e49-d14f-42cd-1a25-08de9c92af73 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2026 15:04:55.7308 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oNnr/gn5GT2TVjzmuT1oxiZzLScbYiI/bZYSr7+DT49u4oO3hrExFTGRiFKQiZpP34ci0WEnTDr6C2Gh+lXbqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTZPR01MB11974 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/17/26 9:55 AM, Andrew Burgess wrote: > Simon Marchi writes: > >> From: Simon Marchi >> >> All uses of symbol_found_callback_ftype use it within a function_view, >> so factor out the function_view into the type alias. >> >> Change-Id: I24a1d2fc233aa5d593c9c68581a9912bfee3a348 >> --- >> gdb/ada-lang.c | 2 +- >> gdb/language.h | 2 +- >> gdb/linespec.c | 6 +++--- >> gdb/symtab.c | 2 +- >> gdb/symtab.h | 4 ++-- >> 5 files changed, 8 insertions(+), 8 deletions(-) >> > >> diff --git a/gdb/symtab.h b/gdb/symtab.h >> index 3936052706f1..3217d00914ce 100644 >> --- a/gdb/symtab.h >> +++ b/gdb/symtab.h >> @@ -2811,7 +2811,7 @@ std::vector find_linetable_entries_for_symtab_line >> true to indicate that LA_ITERATE_OVER_SYMBOLS should continue >> iterating, or false to indicate that the iteration should end. */ >> >> -typedef bool (symbol_found_callback_ftype) (struct block_symbol *bsym); >> +using symbol_found_callback_ftype = gdb::function_view; > > The comment on this type is very out of date, the referenced > LA_ITERATE_OVER_SYMBOLS no longer exists. Any by dropping the argument > name in the new type it's no longer possible to reference the argument > in the command, which is unfortunate. Though again, the comment > previously referenced SYM when the argument was BSYM. > > I know none of this is your fault, but would you mind bringing the > comment up to date please. Removed in the next patch, as you mentioned, so I'll skip it. > > Approved-By: Andrew Burgess Thanks, Simon