From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 07E213857C47 for ; Wed, 5 Aug 2020 10:33:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 07E213857C47 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 95F90AD79; Wed, 5 Aug 2020 10:34:00 +0000 (UTC) Subject: [committed][gdb] Fix prop->const_val uses in gdbtypes.c From: Tom de Vries To: Simon Marchi , gdb-patches@sourceware.org References: <20200801235935.1110640-1-simon.marchi@polymtl.ca> <20200801235935.1110640-4-simon.marchi@polymtl.ca> <57dcb18b-d120-845e-6b90-e4a8f853f2cb@suse.de> Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: Date: Wed, 5 Aug 2020 12:33:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <57dcb18b-d120-845e-6b90-e4a8f853f2cb@suse.de> Content-Type: multipart/mixed; boundary="------------AED767CF31055D276E9BE9D7" Content-Language: en-US X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Aug 2020 10:33:46 -0000 This is a multi-part message in MIME format. --------------AED767CF31055D276E9BE9D7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit [ was: Re: [PATCH 3/3] gdb: remove TYPE_DYN_PROP_ADDR ] On 8/5/20 11:20 AM, Tom de Vries wrote: > On 8/2/20 1:59 AM, Simon Marchi via Gdb-patches wrote: >> Remove TYPE_DYN_PROP_ADDR, replacing its uses with calling >> dynamic_prop::const_val directly. >> >> gdb/ChangeLog: >> >> * gdbtypes.h (TYPE_DYN_PROP_ADDR): Remove, replace uses with >> dynamic_prop::const_val. >> > > > This patch causes the following regression for me: > ... > FAIL: gdb.fortran/class-allocatable-array.exp: print this%_data%b > ... > (and 185 more, all for fortran test-cases). > >> return (prop != nullptr && prop->kind () == PROP_CONST >> - && !TYPE_DYN_PROP_ADDR (prop)); >> + && prop->const_val () != 0); >> } >> > > Hmm, isn't that supposed to be "== 0" ? Committed patch that fixes the regressions. Thanks, - Tom --------------AED767CF31055D276E9BE9D7 Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-Fix-prop-const_val-uses-in-gdbtypes.c.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-gdb-Fix-prop-const_val-uses-in-gdbtypes.c.patch" [gdb] Fix prop->const_val uses in gdbtypes.c After commit 66d6346b25 "gdb: remove TYPE_DYN_PROP_ADDR", I run into: ... FAIL: gdb.fortran/class-allocatable-array.exp: print this%_data%b ... (and 185 more FAILs, all for fortran test-cases). The commit replaces "!x" by "x != 0". Fix this by using "x == 0" instead. Build and tested on x86_64-linux. gdb/ChangeLog: 2020-08-05 Tom de Vries * gdbtypes.c (type_not_allocated, type_not_associated): Use "prop->const_val () == 0" instead of "prop->const_val () != 0". --- gdb/gdbtypes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index 0cd4b194d9..da1c58c65c 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -4134,7 +4134,7 @@ type_not_allocated (const struct type *type) struct dynamic_prop *prop = TYPE_ALLOCATED_PROP (type); return (prop != nullptr && prop->kind () == PROP_CONST - && prop->const_val () != 0); + && prop->const_val () == 0); } /* Associated status of type TYPE. Return zero if type TYPE is associated. @@ -4146,7 +4146,7 @@ type_not_associated (const struct type *type) struct dynamic_prop *prop = TYPE_ASSOCIATED_PROP (type); return (prop != nullptr && prop->kind () == PROP_CONST - && prop->const_val () != 0); + && prop->const_val () == 0); } /* rank_one_type helper for when PARM's type code is TYPE_CODE_PTR. */ --------------AED767CF31055D276E9BE9D7--