From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FMsGESfBpWmU+RAAWB0awg (envelope-from ) for ; Mon, 02 Mar 2026 11:56:07 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OKFafKQf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2BC7D1E0DD; Mon, 02 Mar 2026 11:56:07 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7F5451E089 for ; Mon, 02 Mar 2026 11:56:02 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 613304BA23D7 for ; Mon, 2 Mar 2026 16:56:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 613304BA23D7 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OKFafKQf Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 436E14BA23C3 for ; Mon, 2 Mar 2026 16:55:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 436E14BA23C3 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 436E14BA23C3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772470536; cv=none; b=R+39rWiMPhezLGAFimyQlYkPqTb6gBWJcGWVolDEGathSYfE6dnhEY4i/kYNUPXuTjCDhQYrT/XQhf6n6NjE4Ky1Lt1MtcR090B/4UiNf8eE1aTQU0QDrIu9a1czeNBytHQi/fMGBXeW8xESLMqqqzwOJqFrwX6KJSFEMyk85kQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772470536; c=relaxed/simple; bh=ZDOTY5F57WJYxBy8OaY8EW/mocrKZ7MP5ME7EHEVRHg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=wXqLdF86FSrBmAoBOM0zN6qgwzMD6ORa+xoY1YQA00TFqMdU1xicG1H0UX0wen8PC0t4pkqjqgMpJcPTkdwbhfOGRttkSJSzdkaaeZErGtB1rr1Z8qhQEySo6dCu+Fk1igpPxjWqgQqGsqgB5dYrT5toGTxNJWjAzrdgtUkNFPg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 436E14BA23C3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772470535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sHnsextYPFD+i/jJjYvEBXhi+ugQvxjW5vfQ9GiPoZY=; b=OKFafKQfHQ6cfOx5bBe31v6HzdeaLQ3aBxVa5Zq45Uhf6/PpvRYJt9w693X+5Ss+WyjNbb CsQh1y+qDHf9UonaMaCHOvud5OGcKxkYackypA5B4HcmVrG9TJTiX3+l6Y47x7P1BjceZ4 SckKwBl06UhXPSOn8W2jyBFCndDv0iI= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-660-ZNh7B64BN4e9U0vgxzhweQ-1; Mon, 02 Mar 2026 11:55:34 -0500 X-MC-Unique: ZNh7B64BN4e9U0vgxzhweQ-1 X-Mimecast-MFC-AGG-ID: ZNh7B64BN4e9U0vgxzhweQ_1772470534 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-354c0234c1fso3654839a91.2 for ; Mon, 02 Mar 2026 08:55:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772470533; x=1773075333; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sHnsextYPFD+i/jJjYvEBXhi+ugQvxjW5vfQ9GiPoZY=; b=DkdTPRsIxhKjMreBp/oqJzBt+X6WMUV9W84edR1LDlULVcqFUxaR8Iu0Vm4XAad/Ft lumEiMAsppzzXOlJXVz6+jkFcN7SP6hx2lTEn0HfEIPZHtdMVQa4SmhyrK/a/6F+9tX4 bhNKfLXhH+B5RrSkffdHeUYTmqz7ivS+lWcGLr+SXGrB9+sdaQHrVk5GljzQIvGHCKl5 Mo41sbkOSR2/ngPFAGLRO1aBUM/XQ9bbp3rV1aVGTnD1p91P47QxnKgN0/o1isYSW2LD MEpj0MycI8Uz/Vfi0c0BZT612rmv55/BFSFF/k7Cb4jm0RBdkGxiA6rT98jNuYraq42S XDfg== X-Forwarded-Encrypted: i=1; AJvYcCWRhQKXwu4FBaZqNIMAu5NMmBoN2Kz6sT0cVSqnEjXByPqVhgqAO+nYWbJqRpgoNzxq4tNGFhL8lWsQKQ==@sourceware.org X-Gm-Message-State: AOJu0YxoWFd+8h4DkCOmJec7gs6WmIgjMU0k/ZsTk2JaQVLA2t6nfLjK xuWUv5SKfehdDj/RdRYcOsEUOxTcQgh40dBiywLOv+oMVeQlVxsLLX3c/G2UwiBsBP8qwSg2n7+ k3llsByN8twu3H6k7BM3UTMhSzeCqTKjxHnVgPzq0j6Oa17I3OV13ZhY038gqiW3sxny9N3o= X-Gm-Gg: ATEYQzwGPgSW8+AKDc5Hj5g5qpJSEIxtfd058TF+Yz/Z6X0sQrd7vXVkkIFyDKzqHBn jlmMj703riFKPdt+GLRU3LPeEUU8pa5wcTnQFRsr3NT7/PuPgoR25Q4qle8tnoEo3eRSq9gqa2a Cv+Yu388a8BQND9mKSWm8FbpmkZ1Rgm5nCS2G+dd929aWWIjysU0ccpOn/STqM5iU2mSOP3nycV giuikeQx5bLQaoO7G8F6MTgz5uV3zf3zPUohnd4J941moELJEWNidMErwrmJ24mPUZLNsRXGH9B glt9SedGh5i3/3WZt2NGQdDtKLMImX/mExfXR+7gA+6W0ygqOgWOkKpefPwIAZswrZtL6mr7/QZ LuOcR92UcAOGiQsxh3cV8p1Hy7o8I X-Received: by 2002:a17:90a:e18f:b0:340:be44:dd0b with SMTP id 98e67ed59e1d1-35965ce44f6mr11560198a91.34.1772470532917; Mon, 02 Mar 2026 08:55:32 -0800 (PST) X-Received: by 2002:a17:90a:e18f:b0:340:be44:dd0b with SMTP id 98e67ed59e1d1-35965ce44f6mr11560173a91.34.1772470532127; Mon, 02 Mar 2026 08:55:32 -0800 (PST) Received: from [150.1.200.157] ([172.56.105.212]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359851a5216sm5659105a91.8.2026.03.02.08.55.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 08:55:31 -0800 (PST) Message-ID: Date: Mon, 2 Mar 2026 08:55:30 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Use gdb_bfd_openr in corelow.c To: Tom Tromey , gdb-patches@sourceware.org References: <20260302163129.610391-1-tromey@adacore.com> From: Keith Seitz In-Reply-To: <20260302163129.610391-1-tromey@adacore.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xyWw11YBLIFVdNiy1ukD1da5u3SGs5-qqbyO6rMh0yk_1772470534 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/2/26 8:31 AM, Tom Tromey wrote: > corelow.c has a couple of calls to bfd_openr, each followed by a call > to new_reference. It's cleaner to use the provided gdb_bfd_openr > wrapper. LGTM. Reviewed-By: Keith Seitz Keith