Re: [RFC] Apply compilation dir to source_path lookup

[Mike Gulick <mgulick@mathworks.com>]

On 9/14/19 11:54 AM, Eli Zaretskii wrote:
>> Date: Sat, 14 Sep 2019 11:28:47 -0400
>> From: Andrew Burgess <andrew.burgess@embecosm.com>
>> Cc: mgulick@mathworks.com, gdb-patches@sourceware.org
>>
>> If we have:
>>
>>    DW_AT_name:  	c:/project/foo.c
>>    DW_AT_comp_dir:	d:/project/build/
>>
>> And if the directory search path is:
>>
>>    g:/mnt/project;$cdir;$cwd
>>
>> And the current directory is:
>>
>>    h:/home/
>>
>> Then this is what I think the search order will be:
>>
>>    c:/project/foo.c
>>    g:/mnt/project/project/foo.c
>>    d:/project/build/project/foo.c
>>    h:/home/project/foo.c
>>
>>    d:/project/build/project/foo.c
>>    g:/mnt/project/project/build/project/foo.c
>>    d:/project/build/project/build/project/foo.c
>>    h:/home/project/build/project/foo.c
>>
>>    g:/mnt/project/foo.c
>>    d:/project/build/foo.c
>>    h:/home/foo.c
>>
>> The first and third block is what we currently (pre-patch) do, and the
>> second block is what I think the patch should provide after Mike's
>> last suggested update.
> 
> SGTM, thanks.
> 

Thanks Andrew and Eli for the clarification on the proper behavior on
DOS paths.  The only remaining questionable case for me is whether to
check $cdir/COMP_DIR/FILENAME, which in your example above is
'd:/project/build/project/build/project/foo.c'.  It seems reasonable
to me to leave this out of the search, although one could argue
leaving it on the source path may make the documentation slightly more
straightforward (one less special case).

Please let me know if you would like me to provide an updated version
of the patch.

Thanks,
Mike