From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mUB6KkTnK2q7DwMAWB0awg (envelope-from ) for ; Fri, 12 Jun 2026 07:02:28 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=JcBJXBJc; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=PoVAl8Ry; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gkseIfGK; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=0rGBYtkp; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A99541E098; Fri, 12 Jun 2026 07:02:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 357971E024 for ; Fri, 12 Jun 2026 07:02:28 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AD8E94BA798E for ; Fri, 12 Jun 2026 11:02:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AD8E94BA798E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=JcBJXBJc; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=PoVAl8Ry; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gkseIfGK; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=0rGBYtkp Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id E081D4BA23C8 for ; Fri, 12 Jun 2026 11:01:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E081D4BA23C8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E081D4BA23C8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781262119; cv=none; b=qw6/c+f4SM22KSPpp6ThyvhSXSHC+fOvOOyEugOpXXTCysF0f/7cPNza4Rhjses7TycQJjmxXFROWc0SQJ9QdETKZdiaq5XkJE916kSlulGCfTIdub0f/wUF1D1CVkY5I3L9V6S1P10B5kM0Br3RVkFu9bhrYD7OEIo9RI5Vruw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781262119; c=relaxed/simple; bh=eNBF0SkYIK/H6/cbiUdD+m2KmBnCPegeT1l7vN1s3To=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=CHxCfLdxeati/VOM3RsQtOrdDzeRwnB+RJEJ/pDyGom0Xq3CA/fILSHcgoCILKbyFYCZJhoe/1+Oh93alcJmEZzw/Juf8LAhF/8jvubPPFzfpgPOR94BJPPl5WWO7+jdzC0jwVV53PKRx57TBfg8N1etvlJXrM0E4VMH6Chmf54= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=JcBJXBJc; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=PoVAl8Ry; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gkseIfGK; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=0rGBYtkp DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E081D4BA23C8 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CCA3D76224; Fri, 12 Jun 2026 11:01:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781262118; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=62bRN/HbjocVbkSu8yV/iZeMLeWD3YOhda1Nfd/KjqI=; b=JcBJXBJcbp0Y6pwlgwWkg2VVxBVW9xoyRF5ZNpiHh9RPcQ0t2abRm1vyAGSUhGKRiM/+sS 758w0ZxIWVfPdNQ+/9Ru15DhktfDG7OVb8kH8NmbuWp8S+xggvAUwLS5C396A/QW4CCu83 XqvpeYrlq4ZCf1wjzyqinO6rjFtLkF8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781262118; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=62bRN/HbjocVbkSu8yV/iZeMLeWD3YOhda1Nfd/KjqI=; b=PoVAl8RyHDUzcoQIShqzNsqCw7yIM4Ip+fzcLbA4lcvR4Kdrm6OajmR2UZh1qFmIv4ns1a ATAwmbAhJN7JgXBw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gkseIfGK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0rGBYtkp DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781262117; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=62bRN/HbjocVbkSu8yV/iZeMLeWD3YOhda1Nfd/KjqI=; b=gkseIfGKnTrhjeIV19c2Lcp1j40+s4IFnFILWm5qBfRmuxmIhVg3St2COxAYTBmlEWQqJa DFpV28keTbwsY9bgzWueSssY5wXbtoAQ6XEjadnMXCpBterw1cA1X7BkKqAkI+GuHx60VI t1g/uygibciTUxxoo//i+hh7pWJEXs4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781262117; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=62bRN/HbjocVbkSu8yV/iZeMLeWD3YOhda1Nfd/KjqI=; b=0rGBYtkpRomUWvCiqBYf9mm9AskxK6Vo17w0MZIRqWy4hW0i8C6cDER65ZmHi9PYIDL7Ig s+VBcJQdYx7u8uCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A4456779A9; Fri, 12 Jun 2026 11:01:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id efG5JiXnK2pzWwAAD6G6ig (envelope-from ); Fri, 12 Jun 2026 11:01:57 +0000 Message-ID: Date: Fri, 12 Jun 2026 13:01:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb] Use using instead of typedef To: Lancelot SIX Cc: Andrew Burgess , Tom Tromey , Simon Marchi , gdb-patches@sourceware.org References: <20260609162257.1674992-1-tdevries@suse.de> <87pl1zfymw.fsf@tromey.com> <871peeqtsi.fsf@redhat.com> <9b6adbb6-7d5c-4125-a77a-dfd393766beb@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: CCA3D76224 X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,suse.de:email,suse.de:mid,tromey.com:email]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/12/26 1:00 PM, Lancelot SIX wrote: > On Thu, Jun 11, 2026 at 08:57:48AM +0200, Tom de Vries wrote: >> On 6/10/26 5:50 PM, Andrew Burgess wrote: >>> Tom Tromey writes: >>> >>>>>>>>> "Tom" == Tom de Vries writes: >>>> >>>> Tom> After commit 1eed06ae51d ("[gdbsupport] Use using instead of typedef in >>>> Tom> next_iterator") I wondered if I could do something similar using sed. >>>> >>>> First of all, thanks for doing this. >>>> >>>> I don't know how anyone else feels but I normally find 'using' simpler >>>> to understand, I suppose because I don't need to try to decode the right >>>> hand side to find the name being defined -- it's right there before the >>>> '='. >>>> >>>> So, I am in favor of this patch. I'm going to approve it but I think >>>> you should wait for a bit before checking it in, in case someone wants >>>> to object. >>> >>> I also think this is a good idea. >>> >>> +1 >>> >> >> Thanks all for the upvotes. I've pushed this. >> >> Thanks, >> - Toma > > Hi Tom, FYI when building with clang on ubuntu (clang 18.1.3), I see the > following failure: > > ../../gdb/nat/amd64-linux-siginfo.c:610:16: error: static assertion failed due to requirement 'sizeof(compat_x32_siginfo_t) == 128' > 610 | static_assert (sizeof (compat_x32_siginfo_t) == GDB_SI_SIZE); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../../gdb/nat/amd64-linux-siginfo.c:610:46: note: expression evaluates to '136 == 128' > 610 | static_assert (sizeof (compat_x32_siginfo_t) == GDB_SI_SIZE); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~ > > I traced this back to this part of your patch: > > --- a/gdb/nat/amd64-linux-siginfo.c > +++ b/gdb/nat/amd64-linux-siginfo.c > @@ -203,7 +203,7 @@ struct compat_siginfo_t > }; > > /* For x32, clock_t in _sigchld is 64bit aligned at 4 bytes. */ > -typedef long __attribute__ ((__aligned__ (4))) compat_x32_clock_t; > +using compat_x32_clock_t = long __attribute__ ((__aligned__ (4))); > > struct __attribute__ ((__aligned__ (8))) compat_x32_siginfo_t > { > > I do not think this part is wrong, it seems that clang miss-behaves and > drops the attribute. > > Should we keep typedef just for this case just to keep compatibility > with other compilers? > Hi Lancelot, I've just pushed a patch, please let me know if the problem is not fixed for you. Thanks, - Tom > Best, > Lancelot. > >> >> >>> Thanks, >>> Andrew >>> >>