From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id JxxmOPq7HGArEwAAWB0awg (envelope-from ) for ; Thu, 04 Feb 2021 22:31:06 -0500 Received: by simark.ca (Postfix, from userid 112) id D99731EFCB; Thu, 4 Feb 2021 22:31:06 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2E35E1E945 for ; Thu, 4 Feb 2021 22:31:06 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A38EE393D03C; Fri, 5 Feb 2021 03:31:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A38EE393D03C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1612495865; bh=EM7mpOKRYH2JfWTivhzsSg/P4DFY0fkgmM+YDkziUIQ=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=XO2IIsiD2VFEBsodDfnHeSFJZwKAheU2Z96Bs6/5T9KJAX0EQvNUr8xDy9v6XXn5K JBbGenOrWL4TJcWhaD4CgJFg3PJhpXlAPNd9ZhcrMqF5U6ERD230/4z4R8iROVqLSq 0ftWGQ20vdmM6JYJ0B6exAQXjDsPwSg7jBaXK2yo= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id CF8EA385483C for ; Fri, 5 Feb 2021 03:31:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CF8EA385483C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1153UujI019923 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 4 Feb 2021 22:31:01 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1153UujI019923 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 92F701E945; Thu, 4 Feb 2021 22:30:56 -0500 (EST) Subject: Re: [PATCH v5 12/25] AArch64: Implement memory tagging target methods for AArch64 To: Luis Machado , gdb-patches@sourceware.org References: <20210127202112.2485702-1-luis.machado@linaro.org> <20210127202112.2485702-13-luis.machado@linaro.org> Message-ID: Date: Thu, 4 Feb 2021 22:30:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210127202112.2485702-13-luis.machado@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 5 Feb 2021 03:30:56 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > +/* Implement the "supports_memory_tagging" target_ops method. */ > + > +bool > +aarch64_linux_nat_target::supports_memory_tagging () > +{ > + return (linux_get_hwcap2 (this) & HWCAP2_MTE) != 0; > +} > + > +/* Implement the "fetch_memtags" target_ops method. */ > + > +bool > +aarch64_linux_nat_target::fetch_memtags (CORE_ADDR address, size_t len, > + gdb::byte_vector &tags, int type) > +{ > + int tid = get_ptrace_pid (inferior_ptid); > + > + /* Allocation tags? */ > + if (type == static_cast (aarch64_memtag_type::mte_allocation)) > + return aarch64_mte_fetch_memtags (tid, address, len, tags); We don't use a space before template parameters, so `static_cast`. > + > + return false; > +} > + > +/* Implement the "store_memtags" target_ops method. */ > + > +bool > +aarch64_linux_nat_target::store_memtags (CORE_ADDR address, size_t len, > + const gdb::byte_vector &tags, int type) > +{ > + int tid = get_ptrace_pid (inferior_ptid); > + > + /* Allocation tags? */ > + if (type == static_cast (aarch64_memtag_type::mte_allocation)) > + return aarch64_mte_store_memtags (tid, address, len, tags); Likewise. > + > + return false; > +} > + > /* Define AArch64 maintenance commands. */ > > static void > diff --git a/gdb/arch/aarch64-mte-linux.c b/gdb/arch/aarch64-mte-linux.c > new file mode 100644 > index 0000000000..ede5f5f2b9 > --- /dev/null > +++ b/gdb/arch/aarch64-mte-linux.c > @@ -0,0 +1,34 @@ > +/* Common Linux target-dependent functionality for AArch64 MTE > + > + Copyright (C) 2020 Free Software Foundation, Inc. 2021, I'll stop mentioning these, please apply to all new files Otherwise, LGTM. Simon