From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41632 invoked by alias); 12 Feb 2019 15:53:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41603 invoked by uid 89); 12 Feb 2019 15:53:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=his X-HELO: mail-wm1-f68.google.com Received: from mail-wm1-f68.google.com (HELO mail-wm1-f68.google.com) (209.85.128.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Feb 2019 15:53:34 +0000 Received: by mail-wm1-f68.google.com with SMTP id r17so3473923wmh.5 for ; Tue, 12 Feb 2019 07:53:33 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:75e6:857f:3506:a1f4? ([2001:8a0:f913:f700:75e6:857f:3506:a1f4]) by smtp.gmail.com with ESMTPSA id y1sm5303650wrh.65.2019.02.12.07.53.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 07:53:31 -0800 (PST) Subject: Re: [RFAv2 3/3] Make symtab.c better styled. To: Ulrich Weigand References: <20190212145443.E2799D8028D@oc3748833570.ibm.com> Cc: Philippe Waroquiers , gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 12 Feb 2019 15:53:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190212145443.E2799D8028D@oc3748833570.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-02/txt/msg00141.txt.bz2 On 02/12/2019 02:54 PM, Ulrich Weigand wrote: > Pedro Alves wrote: > >> So the question becomes a simple cosmetic one. In this case: >> >>> (gdb) info variables >>> [...] >>> Non-debugging symbols: >>> 0x0000000010020088 main >> >> Should "main" be printed with function style, or variable style. >> This basically affects the color used to print the symbol. >> >> In Philippe's patch, we'd print it in variable style. If we used >> msymbol_is_function instead of his "is text symbol" check, we'd >> print it in function style. > > Ah, I see. I guess that doesn't really matter that much at this > point. Since we're already showing it under "variables" we might > as well use the variable style. But in the end either way would > be fine with me ... OK, in that case, let's just use with Philippe already has. Thanks, Pedro Alves