Re: [PATCH v4 2/2] MI: Add new command -complete

Jan Vrany
2019-05-16T11:27:58Z

Polite ping.

The v5 - hopefully good - is here:

https://sourceware.org/ml/gdb-patches/2019-04/msg00323.html

Thanks! Jan

On Thu, 2019-04-18 at 15:54 +0100, Jan Vrany wrote:
> On Thu, 2019-04-18 at 15:14 +0100, Pedro Alves wrote:
> > This version is OK, with the tiny issue below addressed.
> >
> > Can you push this yourself, or do you need someone to do it for you?
>
> No, I can't. I'll send a v5 with two more fixes shortly - if all is OK,
> can you push it, please?
>
> Thanks! Jan
>
> > > +/* Implement the "-complete" command. */
> > > +
> > > +void
> > > +mi_cmd_complete (const char *command, char **argv, int argc)
> > > +{
> > > + if (argc != 1)
> > > + error (_("Usage: -complete COMMAND"));
> > > +
> > > + if (max_completions == 0)
> > > + error (_("max-completions is zero, completion is disabled.\n"));
> >
> > errors should not end in \n.
> >
> > Thanks,
> > Pedro Alves