From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15169 invoked by alias); 3 May 2019 21:17:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15157 invoked by uid 89); 3 May 2019 21:17:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=expectations, our X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 May 2019 21:17:23 +0000 Received: from [172.16.0.120] (192-222-157-41.qc.cable.ebox.net [192.222.157.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id DAEDB1E47D; Fri, 3 May 2019 17:17:21 -0400 (EDT) Subject: Re: [PATCH][gdb/testsuite] Fix index-cache.exp with CC_WITH_TWEAKS_FLAGS=-i To: Tom de Vries , gdb-patches@sourceware.org References: <20190503104352.GA7789@delia> From: Simon Marchi Message-ID: Date: Fri, 03 May 2019 21:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190503104352.GA7789@delia> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-05/txt/msg00082.txt.bz2 On 2019-05-03 6:43 a.m., Tom de Vries wrote: > Hi, > > When running gdb.base/index-cache.exp with target board cc-with-tweaks with > CC_WITH_TWEAKS_FLAGS set to "-i", we run into: > ... > FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: at least one file \ > was created > FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: expected file is there > FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: check index-cache stats > FAIL: gdb.base/index-cache.exp: test_cache_enabled_hit: check index-cache stats > ... > > The problem is that the target board makes sure that the generated executable > contains a .gdb_index section, while the test assumes that the executable > doesn't contain this section. > > Fix this by removing the .gdb_index section from the generated executable. > > Tested on x86_64-linux with native and CC_WITH_TWEAKS_FLAGS=-i config. > > OK for trunk? > > Thanks, > - Tom Hi Tom, I would slightly prefer that instead of doing this, we would notice that that file already has an index (in the form of .gdb_index or .debug_names), and adjust our expectations in the test. In other words, we currently assert that loading the file in GDB will produce some files in the cache. However, if we know that the file already has an index, we should verify that no file was produced, as this is the behavior we expect when loading a file which already has an index. Stripping the index makes the test pass, but it just goes back to testing the same thing as with the default board file. Adjusting our expectation to the presence of an index makes the test cover a different use case. Simon