From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WS4NH65rQWkz1gMAWB0awg (envelope-from ) for ; Tue, 16 Dec 2025 09:24:46 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=JjB9Wsau; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 50C0E1E0BC; Tue, 16 Dec 2025 09:24:46 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 126021E048 for ; Tue, 16 Dec 2025 09:24:45 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 7D55F4BA2E05 for ; Tue, 16 Dec 2025 14:24:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D55F4BA2E05 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=JjB9Wsau Received: from us-smtp-delivery-114.mimecast.com (us-smtp-delivery-114.mimecast.com [170.10.133.114]) by sourceware.org (Postfix) with ESMTP id 8C0AA4BA2E04 for ; Tue, 16 Dec 2025 14:24:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C0AA4BA2E04 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=labware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=labware.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8C0AA4BA2E04 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.114 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765895056; cv=none; b=XlUu6QLNKKjGUurgmG796/rjRJXz8MIGFUpnOzzcJuxHvIPdTPV6mFLSAcjTEMCi4FmfW3GZIQQC3+FfTIMRNBQtbxsnoq03pQa5Cc9F/9AaQOMZYexHxaKs/8Jbwom8AGekjXD0LyVtltmFXHawIDwZclEXjncT01sPvcx9IuA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765895056; c=relaxed/simple; bh=yEVll9Phu+DKtjXcg39hqsW9TvNbeTRsLtyTtmhunS4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bjjynQyB/8FN9hAjpEHqVUyaU/9L7aKj95sPE1zMjjdPb2ygJMpKQhwLBi05DE5LH7lwqctlU/ib+faDtJ/HnccisaY7gbu4xXej7tVnz87kIFXu3RyYg++/B0cm7kY/N5/sHo9p/lqaU+Kd3+oIScJAATeSqw020vKs3A8IAZ4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8C0AA4BA2E04 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labware.com; s=mimecast20220511; t=1765895056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yEVll9Phu+DKtjXcg39hqsW9TvNbeTRsLtyTtmhunS4=; b=JjB9WsauoFnjNpSqHWK2WXn7zSCJGtUU4pUpyCrJ2oeWsYfvIfYR4CMLN4gqd/EE+8F6Fp 0mfFWMdizNJqqi6eUidWjTF54SLv1D1dlOkU9cwvitheMS9POeI+V6OSFnyy5ucDyovhTG DtbOt1ZhLtBHIKeWcWrvkTkvpZjX9Dk= Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11020139.outbound.protection.outlook.com [52.101.201.139]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-402-n9d77m2wO4-DAUf7o8oPgA-2; Tue, 16 Dec 2025 09:24:15 -0500 X-MC-Unique: n9d77m2wO4-DAUf7o8oPgA-2 X-Mimecast-MFC-AGG-ID: n9d77m2wO4-DAUf7o8oPgA_1765895053 Received: from SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) by MW4PR17MB4812.namprd17.prod.outlook.com (2603:10b6:303:10d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.6; Tue, 16 Dec 2025 14:24:11 +0000 Received: from SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e]) by SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e%3]) with mapi id 15.20.9434.001; Tue, 16 Dec 2025 14:24:10 +0000 From: =?iso-8859-15?Q?Jan_Vran=FD?= To: "tom@tromey.com" CC: "gdb-patches@sourceware.org" , "vries@gcc.gnu.org" , "tromey@sourceware.org" , "thiago.bauermann@linaro.org" , "simon.marchi@efficios.com" Subject: Re: [PATCH] Revert "gdb: change blockvector::contains() to handle blockvectors with "holes"" Thread-Topic: [PATCH] Revert "gdb: change blockvector::contains() to handle blockvectors with "holes"" Thread-Index: AQHcaG2TzHPp1ARtzkOM6k5Jjj4VZLUi02DegAGK8IA= Date: Tue, 16 Dec 2025 14:24:09 +0000 Message-ID: References: <20251208180717.176567-1-jan.vrany@labware.com> <87y0n3zto2.fsf@tromey.com> In-Reply-To: <87y0n3zto2.fsf@tromey.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR17MB5365:EE_|MW4PR17MB4812:EE_ x-ms-office365-filtering-correlation-id: 4606c38b-7e99-440e-76de-08de3caec794 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|376014|1800799024|38070700021 x-microsoft-antispam-message-info: =?iso-8859-15?Q?SLQL84ttnQWoVPYV5IyEGggKH4TMftMYRDvepyeNq4zYxf+gQ/X+l7iAc?= =?iso-8859-15?Q?41C1YWZwO9K5a0vnSIOwqAYeaXGL9vJif6B5n51T66TpbEL/HMwx1G3SB?= =?iso-8859-15?Q?Y/Aim6BYAB+ks3EUOF1s22/aQ86Dk2qXVQotvlSctoVvukg1SdiX/2d2I?= =?iso-8859-15?Q?X80I3N/KeIcnZ6hyqm3Lm7SNN/kKKZOiVy5C/AMIKyeo+yZZjN/OdqViY?= =?iso-8859-15?Q?h6Pe6MRGuXauVZTM6kE0+ekOXIn8cpzGl1OI3GdLJEfU/EWkCr8NYKz8F?= =?iso-8859-15?Q?1j7MYm+P4MDI6wzmEpE4FzbPeH151glRVKf3xB2Voao0QaaVOD59BV8p1?= =?iso-8859-15?Q?+nlsHpkE9hHjoFAkc633OzsNNCvUsHtowCKrZG2LnrjEWnxv4am3F8l4o?= =?iso-8859-15?Q?Y5qnl1UphenhRv9xLNU1pnqwCzffCiTA8TpaoTkXd419pfl1pGeB1YcEm?= =?iso-8859-15?Q?G/3ELtObwEccy3FswPP2UMpE03NsK4bW9EWK/AT2NJGy0AQbkBfDI+tkg?= =?iso-8859-15?Q?8SfXiiRaAJWgAeGQy/y/iqwcVO0TnXbZEDMaUoB7SGdBBuSjXe6vCxPdA?= =?iso-8859-15?Q?69YhWjMdQTDSV2umK5nv3Dq1dcEjmtqIURAEzNPehL1Y3ky/uEmIHtGOy?= =?iso-8859-15?Q?ITa+IOALTCyGwuc3Z1hcYhDT5IcuMFgtVCCNVJaSOH1rPFqq31KMr1p5R?= =?iso-8859-15?Q?UpI+QvY4BvE3rHe+8IHoVOO7zrsP7jqKWASjuNTH70bLFsT5u7OZMPi7x?= =?iso-8859-15?Q?/c/Io+8g//CtHkq3tnssBoXqWmf9Z5aeXhokelapJlMHWM+Yjq6sEny57?= =?iso-8859-15?Q?YX6mOxJc5CIclnBtXXtJ1DWaoHuGxWBZwtNN1GMm42DWu1cWYF42eP86y?= =?iso-8859-15?Q?8/3IvADz0oF/XVa6idI8bKCpWnDqHcLioYVAh/ysmV7b1YJrxsLr18KDS?= =?iso-8859-15?Q?vzRsKwyoVejUrGCxUMxsfqGtrulKMH6x+OWbG+9nmNEiHaH/1ZD5IUxyf?= =?iso-8859-15?Q?5xHeZdQIyHIgrKyEmirkhNHSRs3yNqBCg05RpYa1mA9UTIEzwihTz9+rC?= =?iso-8859-15?Q?Yf+RX1/11ntMjenc0DBQGi189KlAKDPBZhIrxDX2it4JtENgPQR6GSoaL?= =?iso-8859-15?Q?/2kRH8ry1Mbu8H2FvQHsV5MO6eE/KYriRmRMy2uxK3AYwXrP0wuFUqeaI?= =?iso-8859-15?Q?1/6BLKaF9gERqOvfXdlLcWXMSDXpHVthGP9rCJcIkPt2nMpfrfOI1QxKm?= =?iso-8859-15?Q?9s8wubrYvfjadBFtlQBeMsMEezvjqImZ9R0oi2eFAydSeGLdtXDAfxyvW?= =?iso-8859-15?Q?APcDCNSqo+e1zHcSNaP7cDEdRGhIvKykRyQeyRSijDQ3P/FNvh6dbvj5T?= =?iso-8859-15?Q?/bnTOEyygPD1w3SDL89y3R8FQlg80LbGkIqTg41JgHj2DO40YtyN+Ezzx?= =?iso-8859-15?Q?4VeqJqN7XktHs0lnpj62Goj4sa1WI5LmmosFggXxqSxBlXFe8BP8Lvgbw?= =?iso-8859-15?Q?faSjxL/hgDh4mhLZiauHZhDoCVAKugw4Uf4E5aK6pH5QTGg+x+jeM+Uiv?= =?iso-8859-15?Q?b9qJdPpyIkDZ5JYN90f7FKoK5ASSYLh8onxotR4FFdRmz+qoRFp8sM?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR17MB5365.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700021); DIR:OUT; SFP:1102 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-15?Q?bZH8V6ZK6SAVR6VTVhbrSzgiHX0zOLfo6dG1XULPWtt6GbpncDD9bNKYK?= =?iso-8859-15?Q?ptD2/sgysDXN1eHhktiEre7tdLNvu03t0M79h4jPcf/Onh+slVpMP2u3C?= =?iso-8859-15?Q?JidPJm+fuQKQeVFnDqeU0mthAFYG9AZLqQzZCqb+xbbsa6GN7DQiV0Qo8?= =?iso-8859-15?Q?zwIQHItGFQYayVu3VBZwh15xxpkslSd0y6OOn5mQIh4YnSS1xkHjgZQLi?= =?iso-8859-15?Q?Uy1Ou8dtCNlVs3V9X1SlEhSub85SKaXiGECa0hSyp9HRNj8xr2hhhcOHQ?= =?iso-8859-15?Q?d3TQ2ReX5NapjvLJxB3TGHbutt0ktyFIQPMn2fUrn94CvBk9P6anwmCkl?= =?iso-8859-15?Q?JjFMA34kKGupUevXJ2+S2rZ7bqVM/RW0wix/rPUMS3BjbAHhfxGvdSYlE?= =?iso-8859-15?Q?9Qlg5XEBxPgKBp6g/bG0tO6Xlclgem1EPlS0JQs649DKWJqEHpP9e/5u7?= =?iso-8859-15?Q?tIFbAeQRB5WdIuiZAi5FjVLZIH95+OzEYAuMBJ6Ih+VXjL3ZqLpJkrL9I?= =?iso-8859-15?Q?UIPukX5uyyLgSboc6Vw19JlKSchOSFCWx5Hu6qC3cg/nehekQpgomAW2u?= =?iso-8859-15?Q?V/mnC2yYKRt4Dkk4poLPku5hCBbtPQgiE2ud0OtcZi3TI+O1sM61K0GKd?= =?iso-8859-15?Q?gMhHlDYPMuLeuJTFXn5UANXuEY9/rJ/a9A8b5hj8IBFQQnyVsDCp2gdNy?= =?iso-8859-15?Q?JtxyieLs58MdndDNMfCveS9hIoVkZFybAIdS+DL59t62LEHnS4/VxzbCE?= =?iso-8859-15?Q?vknkVXu54NPJel+CYekVpPH6CxBFhgfXYeqg7l2Uz3bWBL1FhV2m9khIz?= =?iso-8859-15?Q?6GYAEVExNVoQhTZncynHjQ5Y9ZXYyjekRg7DLTSE2HxIF9t7wRhdX8WPu?= =?iso-8859-15?Q?tSc5vVYmUF6dHgrilEeOVTkL1gaHsXn4OVb6wp8wt54TFqb94HFUHvRcI?= =?iso-8859-15?Q?F3u8yL+QZXEltm7bTCaNde7p5DwZJ5vQ3Jfzas08XX1rhG8FTii3XT+kN?= =?iso-8859-15?Q?q02znuLPl3rFanOZm71x/ED+U3wJ7o2dMNDeQfQIRC6aAfjfgjJgwXFTU?= =?iso-8859-15?Q?rfxli3u7Kh4P9u15uA3Dg0Je1iFzj5Qn3+W/cP7H1pqDRe2WInwNlLRBy?= =?iso-8859-15?Q?p3lRkpU1Dw28zeRWhWuLKwIdbgm8Oh4SErZLPLXtrwtWE5KjmWuvi5zbp?= =?iso-8859-15?Q?ELenQhmnfgPR3DpCC15KJ3JxufaU1pNlpUBMLDx8Yu5Hgsg6Jb81Tww7o?= =?iso-8859-15?Q?ZwoQCIWib2bskQ9keMMo0/1aTFUq2/sS5xgSG35uIsBAjkTE0fcFEMh4R?= =?iso-8859-15?Q?L/VTLK+d5/PTxCQn1gzkrQft1JD0uCN092U3+4h1KQFBu8trSZPZLMcC9?= =?iso-8859-15?Q?503bURpQTM3D9f5+bzWEGs5M5XndC1YFdZVY9sXb7oFJ9tBCn9V4ZyXJ3?= =?iso-8859-15?Q?ARQ5HL4LUQa//2/VB1TAYvHgT8Sfg1ktKBSOR8ZULJ0pWiZSa4iK/7Pqk?= =?iso-8859-15?Q?qsifBt0Hsiw2XSO6QeuTS0quP2/qCuSsaOUdydhMlMT3akPaYcYOeTM2P?= =?iso-8859-15?Q?IRGalVqEHE/UFRy13+aok5WKo3PNmbhhIAwMGVjEm66K81Wua1Okchnto?= =?iso-8859-15?Q?0i5wRczDQMixYFd2dMkRjpXnwdF4wTp759Gm1IhwZtJQr95NiwcjPBmzt?= =?iso-8859-15?Q?5BiR?= MIME-Version: 1.0 X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR17MB5365.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4606c38b-7e99-440e-76de-08de3caec794 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2025 14:24:10.3091 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wyg8sIVfnr7jzdQKPV66th9iB33NP2CYGlZdDpEnb6pcEv/PCYQnpHObJVljelZHlOPlOaaPMwNju1rO25weNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR17MB4812 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lTMoUsOxu8lgS-kqv9ci6VRIGkD6bASMUyXFM9BUpR8_1765895053 X-Mimecast-Originator: labware.com Content-Language: en-US Content-Type: text/plain; charset=ISO-8859-15 Content-ID: <668B5481C182C34DB5928D9FDB060B29@namprd17.prod.outlook.com> Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Mon, 2025-12-15 at 07:49 -0700, Tom Tromey wrote: > > > > > > "Jan" =3D=3D Jan Vrany writes: >=20 > Jan> This reverts commit cc1fc6af4150b19f9c4c70d0463ff498703fb637, since = it > Jan> causes a number of regressions that seem not to be easily fixable. >=20 > I hate to revert this since I think it's a better direction for gdb. Yeah, me too. >=20 > I guess I think the 'lookup' and 'contains' methods should be > equivalent, and neither should ever return the global or static block -- > only real code blocks. >=20 > Jan> The problem lies in existence of "freestanding" code, a code that is > Jan> part of a CU but does not have any block associated with it. Conside= r > Jan> following program: > ... > Jan> When compiled, the foo function has no block of itself: >=20 > FWIW this is what I would expect.=A0 It's just like any other case where = a > function does not have debug info: no debug info mean no block. >=20 > Jan> Thiago suggested to use minsymbols to tell whether or a CU contains > Jan> given address. I do not think this would work reliably as minsymbols= do > Jan> no know to which CU they belong. In slightly more complicated case o= f > Jan> interleaved CUs it does not seem to be possible to tell for sure to = which > Jan> one a given minsymbol belongs. >=20 > The don't know the CU but at you should still be able to set a > breakpoint on them. >=20 > Anyway, I'd be willing to approve the backout on the basis that it > causes some regression.=A0 But still I question whether it really makes > sense, and if it would be better instead to change the test. We can change tests but I think GDB would still be broken - the problem is = that this change confuses unwinder in a way I do not really understand yet. So i= t seems to me that if we keep this, we need "fix" some other part of GDB too. I spent = some time debugging this and tried again yesterday but so far the more I debug the le= ss=A0 I understand :-( I do not know what's the policy regarding regressions. If everyone can tole= rate=A0 these regressions for longer, I can try to do some more debugging and see. Jan >=20 > Tom