From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46557 invoked by alias); 31 Dec 2019 20:12:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46548 invoked by uid 89); 31 Dec 2019 20:12:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 31 Dec 2019 20:12:21 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5A2901E092; Tue, 31 Dec 2019 15:12:20 -0500 (EST) Subject: Re: [PATCH v2] Fix install-strip for cross-compilation To: Hannes Domani , Gdb-patches References: <20191231184222.34267-1-ssbssa.ref@yahoo.de> <20191231184222.34267-1-ssbssa@yahoo.de> <64c719e2-df88-6cd8-3f5b-246f0f7b7d58@simark.ca> <1134374112.8470290.1577819135686@mail.yahoo.com> From: Simon Marchi Message-ID: Date: Tue, 31 Dec 2019 20:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <1134374112.8470290.1577819135686@mail.yahoo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-12/txt/msg01093.txt.bz2 On 2019-12-31 2:05 p.m., Hannes Domani via gdb-patches wrote: > Am Dienstag, 31. Dezember 2019, 19:50:47 MEZ hat Simon Marchi Folgendes geschrieben: > >> On 2019-12-31 1:42 p.m., Hannes Domani via gdb-patches wrote: >> >>> The variable INSTALL_PROGRAM_ENV sets up STRIPPROG for the cross-compiler. >>> >>> If this is not done, the host 'strip' is used, and fails: >>> >>> /bin/sh /c/src/repos/binutils-gdb.git/install-sh -c -s gdb.exe \ >>>   /gdb/gdb64-git/bin/$transformed_name.exe >>> strip.exe:C:/gdb/gdb64-git/bin/_inst.33599_: file format not recognized >>> >>> With this change, it's fine: >>> >>> STRIPPROG='x86_64-w64-mingw32-strip' \ >>>   /bin/sh /c/src/repos/binutils-gdb.git/install-sh -c -s gdb.exe \ >>>   /gdb/gdb64-git/bin/$transformed_name.exe >> >> >> Thanks for updating the change log, this LGTM.  I believe you don't have write access >> to the repo, is that right?  Would you like me to push the patch on your behalf, or >> would you like to get a write access (useful if you plan on sending patches regularly)? > > Yes, I don't have write access, and I do plan to send more patches in the future. > > With write access, is there more to it than just push the patch? Ok, if you do not yet have a Sourceware account, please fill this form to get one: https://sourceware.org/cgi-bin/pdw/ps_form.cgi You can mention me as your sponsor. If you already have an account, you need to contact the Sourceware overseers mailing list so they can adjust the permissions to give you write access to binutils-gdb. To push a patch, it's indeed just a matter of pushing the git commit. However, you need to insert the ChangeLog entries in the actual ChangeLog files and amend your commit before pushing. Also, it's good to triple check that there is only what you intend to push in the branch you are about to push. Once you have write access, you can add yourself to the MAINTAINERS file, in the "write after approval" section and then send a "FYI" patch to this list, that gives you a chance to practice. I won't push this patch, I'll let you do it once you have your account. Also, I see that you already have a copyright assignment files with the FSF, that's perfect. Simon