From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53731 invoked by alias); 10 Jan 2017 15:50:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53023 invoked by uid 89); 10 Jan 2017 15:50:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=pedro, Pedro, Alves, alves X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jan 2017 15:50:46 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 659C961BA4; Tue, 10 Jan 2017 15:50:46 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0AFoiRi028659; Tue, 10 Jan 2017 10:50:44 -0500 Subject: Re: [PATCH] Change return type of ui_out redirect to void To: Simon Marchi , Luis Machado References: <20161222220728.15146-1-simon.marchi@ericsson.com> <81609b60-0821-3f1b-7613-5bf691727d5f@codesourcery.com> <4270f5e03af2b1e554fc4ddaf1a0a8c7@polymtl.ca> Cc: Simon Marchi , gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 10 Jan 2017 15:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <4270f5e03af2b1e554fc4ddaf1a0a8c7@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg00166.txt.bz2 On 01/03/2017 04:17 PM, Simon Marchi wrote: > Right, now that I re-read it, it does sound funny. Fixed locally to: > > /* There is a former output pushed on the ui_out_redirect stack. We > want to replace it by OUTPUT so we must pop the former value > - first. We should either do both the pop and push or to do > - neither of it. At least do not try to push OUTPUT if the pop > - already failed. */ > + first. Ideally, we should either do both the pop and push or do > + neither of them. */ > > Thanks! OK with that change. BTW, also spotted a spurious whitespace after "*" here: > @@ -163,7 +163,7 @@ class ui_out > ATTRIBUTE_PRINTF (2,0) = 0; > virtual void do_wrap_hint (const char *identstring) = 0; > virtual void do_flush () = 0; > - virtual int do_redirect (struct ui_file * outstream) = 0; > + virtual void do_redirect (struct ui_file * outstream) = 0; Thanks, Pedro Alves