From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50372 invoked by alias); 5 May 2017 04:01:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50126 invoked by uid 89); 5 May 2017 04:01:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=Hx-languages-length:1228 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 May 2017 04:01:30 +0000 Received: by simark.ca (Postfix, from userid 33) id 13FC91E4C7; Fri, 5 May 2017 00:01:31 -0400 (EDT) To: Kevin Buettner Subject: Re: [PATCH v2 3/7] Documentation for gdb.thread_from_thread_handle X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 05 May 2017 04:01:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org, eliz@gnu.org In-Reply-To: <20170408230700.3754771e@pinnacle.lan> References: <20170408224959.67164a27@pinnacle.lan> <20170408230700.3754771e@pinnacle.lan> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.5 X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00134.txt.bz2 On 2017-04-09 02:07, Kevin Buettner wrote: > gdb/doc/ChangeLog: > > * python.texi (Threads In Python): Add description for function > gdb.thread_from_thread_handle. > --- > gdb/doc/python.texi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi > index ce5810e..81543d3 100644 > --- a/gdb/doc/python.texi > +++ b/gdb/doc/python.texi > @@ -3008,6 +3008,12 @@ This function returns the thread object for the > selected thread. If there > is no selected thread, this will return @code{None}. > @end defun > > +@defun gdb.thread_from_thread_handle (thread_handle) > +Return the thread object corresponding to the thread handle, > +@var{thread_handle}, a thread library specific data structure such as The comma before @var{thread_handle} feels unnecessary. And I think you could shorten it to "... corresponding to @var{thread_handle}, ..." without loss of clarity. > +@code{pthread_t} for pthreads library implementations. > +@end defun > + > A @code{gdb.InferiorThread} object has the following attributes: > > @defvar InferiorThread.name Eli, do you have something to say about this patch? Thanks, Simon