From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48698 invoked by alias); 10 Aug 2017 13:35:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48687 invoked by uid 89); 10 Aug 2017 13:35:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Hx-languages-length:1331 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Aug 2017 13:35:39 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9C40680D; Thu, 10 Aug 2017 06:35:37 -0700 (PDT) Received: from [10.2.206.198] (e104437-lin.cambridge.arm.com [10.2.206.198]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2399C3F577; Thu, 10 Aug 2017 06:35:36 -0700 (PDT) Subject: Re: [AArch64][3/6] DWARF unwinder support for signed return address To: Pedro Alves , GDB References: From: Jiong Wang Message-ID: Date: Thu, 10 Aug 2017 13:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00215.txt.bz2 On 10/08/17 12:08, Pedro Alves wrote: > On 08/09/2017 01:17 PM, Jiong Wang wrote: >> + >> + /* Only DW_CFA_GNU_window_save is expected on AArch64. */ >> + if (op != DW_CFA_GNU_window_save) >> + return false; >> + > Was there any progress in giving this an Aarch64-specific name > to avoid confusion? FYI, I was confused by this again for a couple > minutes when I read it, until I remembered the previous discussions. Hi Pedro, Yes, We can add DW_CFA_AARCH64_negate_ra_state to dwarf2.def, with the same number of DW_CFA_GNU_window_save, then need to introduce a new DW_CFA_DUP to avoid duplicated case value trouble when auto-generate switch/case for returning CFA name. Will post patch to GCC then can be synced to binutils-gdb onced approved. > >> +/* Implement the execute_dwarf_cfa_vendor_op method. */ >> + >> +static bool >> +aarch64_execute_dwarf_cfa_vendor_op (struct gdbarch *gdbarch, gdb_byte op, >> + struct dwarf2_frame_state *fs) >> +{ >> + struct dwarf2_frame_state_reg *ra_state_column; >> + static unsigned char exp_0 = 0x30; /* DW_OP_lit0. */ >> + static unsigned char exp_1 = 0x31; /* DW_OP_lit1. */ > Can these be static const? (likewise elsewhere in the patch.) > > Also, gdb_byte. Will fix in the next update. Thanks. Regards, Jiong