Re: [PATCH 10/13] Remove gdbarch_remote_breakpoint_from_pc

Pedro Alves
2016-10-27T14:55:37Z

On 08/31/2016 04:06 PM, Yao Qi wrote:
> --- a/gdb/mips-tdep.c
> +++ b/gdb/mips-tdep.c
> @@ -7050,7 +7050,18 @@ gdb_print_insn_mips_n64 (bfd_vma memaddr, struct disassemble_info *info)
> return gdb_print_insn_mips (memaddr, info);
> }
>
> -/* Implement the breakpoint_kind_from_pc gdbarch method. */
> +/* Implement the breakpoint_kind_from_pc gdbarch method.
> +
> + Determine the remote breakpoint kind suitable for the PC. The following
> + kinds are used:
> +
> + * 2 -- 16-bit MIPS16 mode breakpoint,
> +
> + * 3 -- 16-bit microMIPS mode breakpoint,
> +
> + * 4 -- 32-bit standard MIPS mode breakpoint,
> +
> + * 5 -- 32-bit microMIPS mode breakpoint. */
>

Isn't this duplicating info that's now on the enum?
I was surprised to find this in this mostly unrelated patch.

> static int
> mips_breakpoint_kind_from_pc (struct gdbarch *gdbarch, CORE_ADDR *pcptr)
> @@ -7178,15 +7189,6 @@ mips_sw_breakpoint_from_kind (struct gdbarch *gdbarch, int kind,

Thanks,
Pedro Alves