Re: [PATCH 00/13] Split brekapoint_from_pc to breakpoint_kind_from_pc and sw_breakpoint_from_kind

Yao Qi
2016-10-27T15:41:37Z

Hi Pedro,
Thanks for the review,

On Thu, Oct 27, 2016 at 3:58 PM, Pedro Alves <palves@redhat.com> wrote:
>
> My only question is what happens to the GDBARCH_BREAKPOINT_MANIPULATION
> / SET_GDBARCH_BREAKPOINT_MANIPULATION macros? I was hoping they'd
> disappear in the end, but looks like not? (I find the "manipulation"
> name to be very opaque here, btw.)

Both are the intermediate structure during the the process of conversion.
I didn't remove them as I think they two can "simplify" the code, because
a lot of gdbarch have one breakpoint instruction. Their
breakpoint_kind_from_pc and sw_breakpoint_from_kind look quite similar.

--
Yao (齐尧)