From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aHDIG0o+4WJxbhsAWB0awg (envelope-from ) for ; Wed, 27 Jul 2022 09:31:54 -0400 Received: by simark.ca (Postfix, from userid 112) id 611A91E9ED; Wed, 27 Jul 2022 09:31:54 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=GRbxK+6X; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B22E11E87E for ; Wed, 27 Jul 2022 09:31:53 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C51C6385702B for ; Wed, 27 Jul 2022 13:31:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C51C6385702B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1658928712; bh=k15pn0Hmu2JxMg2GRQEMgDYuP3CENl0Q/XhIJhNe8O0=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=GRbxK+6XFEkiPJ2yETj5IOmAsAGosZmf5IhUumUrfo9aV1Oe5i8QyE7LbJailf6Ds VW/VQMdnOPl7bGaQvCfhg4FKYAw15U7wEKktsIiUQ02FLwIMZvWvPpFgoTi6bnG92W 3JTewRkHozABRiu/uTaet07gPcDLuD3rbLfDsyFo= Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2052.outbound.protection.outlook.com [40.107.21.52]) by sourceware.org (Postfix) with ESMTPS id DB5623857001 for ; Wed, 27 Jul 2022 13:31:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DB5623857001 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BUuTbLJ1wgPA7vuUT43/UeJVsi1KFIC6uG/zmNYX49MI1oStrku14HrCk7+yGeQ+h9NnIcgObv+ToRWz9rfUuXbvOoWdUiUpXDBH7hxCHXRIkGLa2gaNskxq7weUq2XowgbJRy086GW8/K9DVFxJcnWZz8U2KUn2eHUIk+vK8xgC4tN3K9CMpF/XxwNqp3xJuBzw0bjKJ+ydar4buaK2/4/tBRYmWbUjY325Bj5BI6q2rnQiH0m54FL/zngHUVUuAiuyrBPe5OeBE1GxzEw5KXwz7H8lt4TIqWyl/kp6P7AH16hMli4OP5OcqIHzH2J4ReBa+Uw2Ztdnrp4vDle7Tw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k15pn0Hmu2JxMg2GRQEMgDYuP3CENl0Q/XhIJhNe8O0=; b=YRD8DJmy2rAfMMThCXat0N6WcTXlEtn9LSgf/3lIQAWP/A4d4AyFTCjNQPybPdCKNjrcZh6v2gkdZPSqPxczGcRBmN6dM/Ih3OeZuG7gqNzbvgzFL7+3zoKrcL/mxPiKErYUop4U7eFmWfgaHczflJRAYSmaQGv+XPA8mmvYuA2I10+h6kuCO54Ylvum5UeBycZlnFlOMpIVMXXGuu+Nz33/6/JyimdKVTtobliueBF3qE6IzSUQbB2ETPxrAYhgKWC7zwxARJBFlifnUZqlFhVxItc7NXxxH6RuHPOjWfflWYvQ3AE4z4fTBOsNhUBziQMjtiuDBOtWpb4CfRt89g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from FR3P281CA0117.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::8) by AM9PR08MB6244.eurprd08.prod.outlook.com (2603:10a6:20b:2d4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.21; Wed, 27 Jul 2022 13:31:28 +0000 Received: from VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a3:cafe::a3) by FR3P281CA0117.outlook.office365.com (2603:10a6:d10:a3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.1 via Frontend Transport; Wed, 27 Jul 2022 13:31:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT054.mail.protection.outlook.com (10.152.19.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Wed, 27 Jul 2022 13:31:28 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Wed, 27 Jul 2022 13:31:27 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4e0b3b511977708f X-CR-MTA-TID: 64aa7808 Received: from 020e88c3c5fb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7A2F7E56-17DF-4A7E-BE34-E58E70863754.1; Wed, 27 Jul 2022 13:31:21 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 020e88c3c5fb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 27 Jul 2022 13:31:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S9K8vTkBi6NT+Jt5M9I2SP41URho4fFE87qa3dk4nMvyBtzX4skDxuoMH3ef3NWSpiQYgq683oAvobZrPt10oZHPSRc9mohS4XhMjxKNlhafH3pDvbLUI8EIEv0TaebnWyJzRZdcHI33vGIBQzTZv4wJy0KNZK73BjUbsDLmTstuJeqM0LUIrDPAt+sOE29138tShQJy1dqLSaB24LOMSSAaMDJpZHtMypMjd+vDU2lnVdKhYBgovlLrwx967+Tfq0+1l4gIOY3vdQJTg7+ikXiwxBOOngBjix3aAhR83SOPBOAE24zHGuEzD5ay8i0U6GzoYhF0oJ6/9sjOkUSEzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k15pn0Hmu2JxMg2GRQEMgDYuP3CENl0Q/XhIJhNe8O0=; b=b0DtPOYDzG/Dkf4hwm+ULpcA2O1Q3AwT+Hf0FfD5e3amnvN7FhVzY3U3MeEyjikngks21xzqtnEdLMqv1YgB4imfA5iOdtc4sBot3rw+b0bmkGST8GloRg9JIElRcfAR5D+EJm2R7B+d0aoK+wANbmfnkwDB4hL76kFQf87xUad5S/N9+qi0Opn+Gh5O4BhUkMKu+cswgFwe1rOBwZG7NQV8yrmjJ/qKVhjldiO4pWG8GYAsQaWcWjAVnXDVsLFwqx+5+Pk1oa35dn+JIgaca7uaW4PBgmPWBffpZtqKUdInzKdZ2F7s/yNWy4W4YpoHf7UBNlGn2Typ25npn/wApQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by VI1PR08MB3007.eurprd08.prod.outlook.com (2603:10a6:803:4a::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Wed, 27 Jul 2022 13:31:08 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::e866:af0e:2168:5ca7]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::e866:af0e:2168:5ca7%5]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 13:31:08 +0000 Message-ID: Date: Wed, 27 Jul 2022 14:31:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH][gdb/testsuite] Fix gdb.ada/literals.exp with aarch64 Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <20220727103447.GA9310@delia> In-Reply-To: <20220727103447.GA9310@delia> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0487.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::6) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 0cbb0167-ab8b-4e07-6b53-08da6fd44f6a X-MS-TrafficTypeDiagnostic: VI1PR08MB3007:EE_|VE1EUR03FT054:EE_|AM9PR08MB6244:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 63QCIYbT0SietTODWWS7Ku3xs++9FUmABVXWgFT8ffjYjsIImXTwMqfg6z7nC8/q1JW5q0NKwL3GRLKXKnmezFjCmx76Y8CsmeNRdgQkH+9XlXy2lTFx/xHJW6ffZK15CdxaAywx0/7UjRxn48XGDvOcP49gwWL/6uGsYDGDsst2tVb45IPDOc6fkEuAqalL0q/i5Zk/hfw5V5qqmKxdUEm2GvXozOT2XIcoAEQoWccUuMm8VywOK4dr45MVPZTESxuDCcFjWdRT3YvhU30IkPVXcinpqKbCWRLA5/HY96aZU9YNMMKoHl/dXmf6MzAJTHEOVa156NCES426DDtcgLDy8KQ/ARcmJ9OKRwC5CjbH8kd99wM/zzFJl4LWPWHxU0Mv2eDlnxkw6TGSD6xz52V+aQ3qw0TWM5gXfEtp2Dkh7laKwXkL+V4z9Ro9yCGIxyaQ30Yo+m5lGU0M7DGCkwsSklqZ/UKEszp499Z3rxPOZjX52Yc7a8V+7h5CCQpKvn1GklNAwLwcsU2raPvrhml1eM1DK3f9+d8H37kGAoid4PVsjD5hBf+80k2lh9K4AvKO1fULJ3DxVfh141A5JsKOuRssVXwoAU7tPD4y0HCUta0scxUOoG6qmqXdWGy3n92uES18rX7SskgGVT1C+s43lOCUMfl3dZZY07cQgyfGgtpagDr4uuyknTvO/4H33Lhhp17p7YkznVkQtkEoVjQmhqA5P3ymdSn9TlfQYXJhm/tpdfQArIo4i7Ozgln0vff/0FXxBTGv//3zQyVIHNUiJSDsshMZpdqFevfsC6XwSIABqagH4zVaSPjnBrGq4SLG0Wv+N5PriBGteLgmU5zulfGdhjQuKHGwe/0qHXs= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(39860400002)(136003)(346002)(396003)(376002)(4326008)(2906002)(54906003)(66556008)(316002)(31686004)(31696002)(36756003)(86362001)(84970400001)(478600001)(966005)(6486002)(41300700001)(66476007)(66946007)(186003)(38100700002)(2616005)(83380400001)(26005)(6512007)(6506007)(53546011)(8936002)(8676002)(5660300002)(44832011)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3007 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 656cc7b0-4366-4603-cf22-08da6fd44354 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HpT3pVs/t7QgvGRgqenDl7bpa0Qg6lcm+iAW6E01xsgoiYZzcM0XtNy+4bCO16V7OTdSY1X2Jviiy6zWrCjKAWMVwVk6/kylZXuMTMiRo+cB/vro6Q2C4VXE0CLeh7G1PqX7CpqZD/nTU5iFhQaF/CkZo67q2xzYJuF4p2Ts8yk3ANlwZmoVMLFVzXAWnpe5t+/wAq2rKtbCXyC1Y+8F5AOQwj/Cf0hCNeb9BnZjnfmpbxqkSGtXm1AYLMHHFziwAW37UpW31WykzpCisl9OXz661XFkwegQy+N6eJQwPVPrZfFP+sZJeOdEhYB5g5YUj3TEXD+qiBkEANX+Ls0XGfmin1RbkD/2ObbU1zPgi+fSIj8gdIlJjqIWgPYGhGYExdddkEZ7V6fVrQhXa+j4RdcAvbZe7TMHHeaxBhHhRSU8tARG6VKcFKTBkZ/L3TsxucncVdeo5NRL71JUSGeAutISrrFK1nkFkGMXJJ9NDpHy80gtlvTpH5Pfd5W1dcoCA2Z24ytNeVUgri8iIzd/kd8wsRi4c7wmSEEhh+A+N1nAK27dhzdN+SmJNKBBqxL5UvrNsR1U3SL2UIKWX0vzFGEz4UJ9NomQ+W9Mb9jGve9wyEMFMwXynHKy1aWLGRFoul9jNSc7FQQ16cMFic+Z9w4GVFaIpgL//cNnm6n//iIPLI640aAaBMmXxY5+wUSU89JJsmzWzoNzuc261eI5r9GMr9Z0m9O/xbFcPW/dyZKXYyVzw1LSbpw0rfoBTkk6DQG5xllicq/Ltdpn5qCL5xBbeINkF50++1wIGEtLYkrnqRTZQgeMUvU2ydQU+SeWAc8dDqEKZR87SFuNRKo1k6AuE7nwWIS5Ck1QqPq5LEL+Z+sHLDdjdp2OW+5vj+eS X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(376002)(346002)(136003)(39860400002)(36840700001)(46966006)(40470700004)(86362001)(54906003)(81166007)(6506007)(40480700001)(316002)(82740400003)(2616005)(31686004)(53546011)(356005)(36756003)(36860700001)(82310400005)(31696002)(47076005)(83380400001)(5660300002)(2906002)(4326008)(84970400001)(336012)(478600001)(6512007)(40460700003)(107886003)(70206006)(966005)(186003)(26005)(70586007)(41300700001)(8936002)(8676002)(6486002)(44832011)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 13:31:28.1377 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0cbb0167-ab8b-4e07-6b53-08da6fd44f6a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6244 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Cc: Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 7/27/22 11:34, Tom de Vries wrote: > Hi, > > On aarch64-linux, I run into: > ... > (gdb) print 16#ffffffffffffffff#^M > $7 = 18446744073709551615^M > (gdb) FAIL: gdb.ada/literals.exp: print 16#ffffffffffffffff# > ... > while on x86_64-linux instead, I get: > ... > (gdb) print 16#ffffffffffffffff#^M > $7 = -1^M > (gdb) PASS: gdb.ada/literals.exp: print 16#ffffffffffffffff# > ... > > We can easily reproduce this on x86_64-linux using: > ... > $ gdb -q -batch -ex "set lang ada" -ex "set arch i386" \ > -ex "print 16#ffffffffffffffff#" > $1 = -1 > $ gdb -q -batch -ex "set lang ada" -ex "set arch aarch64" \ > -ex "print 16#ffffffffffffffff#" > $1 = 18446744073709551615 > ... > > With i386, we have: > ... > (gdb) p int_bits > $3 = 32 > (gdb) p long_bits > $4 = 32 > (gdb) p long_long_bits > $5 = 64 > ... > and so in processInt we hit the fits-in-unsigned-long-long case where we use > as type long long: > ... > /* Note: Interprets ULLONG_MAX as -1. */ > yylval.typed_val.type = type_long_long (par_state); > ... > > With aarch64, we have instead: > ... > (gdb) p int_bits > $1 = 32 > (gdb) p long_bits > $2 = 64 > (gdb) p long_long_bits > $3 = 64 > ... > and so in processInt we hit the fits-in-unsigned-long case where we use > as type unsigned long: > ... > yylval.typed_val.type > = builtin_type (par_state->gdbarch ())->builtin_unsigned_long; > ... > > Fix this by updating the test-case to accept 18446744073709551615 as well. > > Tested on x86_64-linux and aarch64-linux. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29416 > > Any comments? > > Thanks, > - Tom > > [gdb/testsuite] Fix gdb.ada/literals.exp with aarch64 > > --- > gdb/testsuite/gdb.ada/literals.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.ada/literals.exp b/gdb/testsuite/gdb.ada/literals.exp > index a6ac89b540f..744a6bc573c 100644 > --- a/gdb/testsuite/gdb.ada/literals.exp > +++ b/gdb/testsuite/gdb.ada/literals.exp > @@ -36,4 +36,4 @@ gdb_test "print 16#f#e1" " = 240" > gdb_test "print 16#1#e10" " = 1099511627776" > > gdb_test "print/x 16#7fffffffffffffff#" " = 0x7fffffffffffffff" > -gdb_test "print 16#ffffffffffffffff#" " = -1" > +gdb_test "print 16#ffffffffffffffff#" " = (-1|18446744073709551615)" LGTM Thanks for investigating this.