From: Flavio Cruz <flaviocruz@gmail.com>
To: gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simark@simark.ca>,
Samuel Thibault <samuel.thibault@gnu.org>
Subject: [PATCH] Hurd: do not include defs.h when compiling MiG stubs since they are compiled as C files
Date: Wed, 3 Jul 2024 23:05:06 +0100 [thread overview]
Message-ID: <cw5yn6mfyjxdxv4kzhmqy76tjclttc3cykptidqwdfd5syrw36@r6j6p4cewhs6> (raw)
Otherwise, GDB will fail to compile for Hurd.
---
gdb/Makefile.in | 3 ++-
gdb/config/i386/i386gnu.mn | 4 +++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 6f7f2af31e5..65910d9774d 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -603,11 +603,12 @@ CONFIG_DEP_SUBDIR = $(addsuffix /$(DEPDIR),$(CONFIG_SRC_SUBDIR))
# your system doesn't have fcntl.h in /usr/include (which is where it
# should be according to Posix).
DEFS = @DEFS@
+GDB_INCLUDED_HEADER = -include $(srcdir)/defs.h
GDB_CFLAGS = \
-I. \
-I$(srcdir) \
-I$(srcdir)/config \
- -include $(srcdir)/defs.h \
+ $(GDB_INCLUDED_HEADER) \
-DLOCALEDIR="\"$(localedir)\"" \
$(DEFS)
diff --git a/gdb/config/i386/i386gnu.mn b/gdb/config/i386/i386gnu.mn
index b7414e3bcb4..e90c7fe8d40 100644
--- a/gdb/config/i386/i386gnu.mn
+++ b/gdb/config/i386/i386gnu.mn
@@ -21,7 +21,9 @@ MIGCOM = $(MIG) -cc cat - /dev/null
| $(MIGCOM) -sheader /dev/null -server /dev/null -user $*_U.c -header $*_U.h
# MIG stubs are not yet ready for C++ compilation.
-%_S.o %_U.o : COMPILE.post += -x c -include gnu-nat-mig.h
+%_S.o %_U.o : COMPILE.post += -x c
+# Do not include defs.h since it requires C++. Rather include our own gnu-nat-mig.h
+%_S.o %_U.o : GDB_INCLUDED_HEADER = -include gnu-nat-mig.h
NAT_GENERATED_FILES = notify_S.h notify_S.c \
process_reply_S.h process_reply_S.c \
--
2.45.2
next reply other threads:[~2024-07-03 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 22:05 Flavio Cruz [this message]
2024-12-17 16:45 ` Tom Tromey
2024-12-17 17:06 ` Flávio Cruz
2024-12-17 17:39 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cw5yn6mfyjxdxv4kzhmqy76tjclttc3cykptidqwdfd5syrw36@r6j6p4cewhs6 \
--to=flaviocruz@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=samuel.thibault@gnu.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox