From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6KpCNdO/UGptkAEAWB0awg (envelope-from ) for ; Fri, 10 Jul 2026 05:48:03 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MpwRO+br; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B514C1E0A3; Fri, 10 Jul 2026 05:48:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 10D0F1E070 for ; Fri, 10 Jul 2026 05:48:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1F7044BA2E26 for ; Fri, 10 Jul 2026 09:48:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F7044BA2E26 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MpwRO+br Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id AD38B4BA5439 for ; Fri, 10 Jul 2026 09:47:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AD38B4BA5439 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AD38B4BA5439 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783676844; cv=none; b=El1JYn0Fc0RfQLgYcK5Shx6y7wy+EMGVgbxJC3BTDmzZ6KiQEGQeV9jMfDghDHubmPiM62CqcbCSU3OROqkvY2ojvFB5B6D8qFGvASmW84RTytB3iIZ8q5J9soZM+SxJwwLmiwosHB3KmHlbZAtfE9FpyWx00U0iGkbrjCRBsak= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783676844; c=relaxed/simple; bh=xN3fs79B72ZJM7nIPoP8GeLCHQmDGX/FLqvu4XEfKMg=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=SUqDcXWji+Q7RwPTzz9jeuMYQ8/4We+NuGtLpBZTGpWDhPIqPluy0BdXr/tda8gV0ZZYKiJsZLhYDUy9xWmtjD43B5vjfMpgIMXsmOJsIqIUBN9wXeLDFsTqhkr7ersXUaicbBsYn6N5d3dM2YZBvp1nGpuAB8sF+XHAKmULnmE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MpwRO+br DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AD38B4BA5439 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783676844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rykWMJCzm9aVhSmKFpkjJ0OMQELSsO9Egkj587U72TA=; b=MpwRO+brxLJh4svW0SbAucrwLoohc2lJPcxf4dbVRXStFiTf84Coh3UHN7++wpBt2YjX1+ CnE1ouYX+Y/ji3972FMb/QK393MOK7dRWHFWLSVoVHo9wdTh38ua6YapZ72R5W6qSQHVYG NHRqKtOY7uxONkhuoMMONPdj0Cfa1pM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-9rTpo6SlMGmDjFugZJA2-w-1; Fri, 10 Jul 2026 05:47:22 -0400 X-MC-Unique: 9rTpo6SlMGmDjFugZJA2-w-1 X-Mimecast-MFC-AGG-ID: 9rTpo6SlMGmDjFugZJA2-w_1783676842 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4629f312a67so567879f8f.2 for ; Fri, 10 Jul 2026 02:47:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783676842; x=1784281642; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=rykWMJCzm9aVhSmKFpkjJ0OMQELSsO9Egkj587U72TA=; b=oUyaWn/yHRU2t4qNcOo006JAG/5Abf2A0gbfXJWQG9Wnu2lDIZCuayr+GNdDbNpocI ehhiQMU1rC9AEbzOU4rGHQfBV0WYUzK/nlmtEV27vBlPHX++pVU2cEJvPgiDzTew1Zup gHwFJIqSKwmltIUTqS2ny5zMLRGjAAkGtK9itiMCefR6df4ZA3NpHJCmcL/ytDZN2dQr 3xE+mBtLU2yUygVoYWGPo6WYeWjRFRbYEDFBfvp2B+GHhi+s2dLbdrAwJ4sLe8VhWOsM Uwo2WqkT9j/Aou0Nn49ik/GzjLGBId9As4BQd2upBa5wCk/x2CmEfa5GzJ8ntU0jedov xQHA== X-Gm-Message-State: AOJu0YyhQEw4XlW3mfl/hxDwcdvepqv76SwWC1Zn53InRKcMRpAuRVs9 c3xETW+x8SboqMBfrHzKGm2YtFcbcV4CnIVSp+7uqP5jPFhpCb+mFoPxAbWoLoMKRRRZxY0ODSC KWOFFfGqUMVL333QU5Plod8pYPJY3oLtygrIwjPs4kJgfMPUkWNLt2UYujw6dQC0A47PaOKiCHY 2MPT3hBe3b249PCCTrJs5YmFvVfW/s7J+e9CUAFbjexGNqPKw= X-Gm-Gg: AfdE7cmNRSj3crPetRX4Vx70wMWUeqj2Nnbi4mFCENHihJOqjjkk5j5V7L0DsSOCTWZ guoeaVqsNfwQ83KRL77B4JQ6a/wi7OEslhTEsWZXdIk91xEg8LHz+ms4G0yzUrlRymGFEc/2NvJ XPiGxd5qsgE8ibfaP83RqWq+zn74Esf9jDcEpoSM6HrQcMrv5Ao1AwwWNPlu+yYI72wdRILBCtK WHX6U6hNlxh/uqRcvLmTScMJr9MNlDay64WAVmHNLVWoARu1MqKgNHEsudt8n7hGQnXoGGQCZsx 8F61yxdjBMF9w554wb/rPCQcn0IcOivflPjvPJg9hz5HmuUE8rIUZxeCSx3YcgWoC0cmF9M8vVh sL1Q+6r8= X-Received: by 2002:a05:6000:4304:b0:46f:960b:b711 with SMTP id ffacd0b85a97d-47df0797962mr12233920f8f.45.1783676841757; Fri, 10 Jul 2026 02:47:21 -0700 (PDT) X-Received: by 2002:a05:6000:4304:b0:46f:960b:b711 with SMTP id ffacd0b85a97d-47df0797962mr12233877f8f.45.1783676841272; Fri, 10 Jul 2026 02:47:21 -0700 (PDT) Received: from localhost ([31.111.209.233]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa039ae44sm55950714f8f.23.2026.07.10.02.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 02:47:20 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 0/6] gdb/tui: fix debuginfod related crash Date: Fri, 10 Jul 2026 10:47:12 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: H-nuCXnY79HXtvuhOGmh5tZT5qECZuh3BdDNpx6tJUM_1783676842 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This series is an alternative to the latest patches proposed here: https://inbox.sourceware.org/gdb-patches/20260417075719.852558-1-tdevries@suse.de Patches #1, #2, and #3 cover changes that are not part of the above series, I suspect these will be reasonably non-contentious. Patch #4 is a small refactor to support the later patches. Patches #5 and #6 are my take on solving the problem covered by the above series. In v2: - Rebase to current HEAD. - Minor testsuite tweaks to avoid possible race condition where GDB might not spot if the test failed. - Some improvements to comments and commits messages to make things clearer. - Retested. Thanks, Andrew --- Andrew Burgess (6): gdb/tui: convert a window handle `if` into an `assert` gdb/testsuite: fix tuiterm linefeed scrolling new line content gdb/tui: prevent TUI activation from a secondary prompt gdb/tui: make tui_win_info::rerender public gdb/tui: fix for debuginfod prompt while enabling the TUI gdb/tui: fix debuginfod prompt using 'C-x C-a' to enter TUI .../gdb.tui/activate-from-secondary-prompt.c | 22 ++ .../activate-from-secondary-prompt.exp | 179 ++++++++++++ .../gdb.tui/activate-with-key-combo.c | 22 ++ .../gdb.tui/activate-with-key-combo.exp | 83 ++++++ gdb/testsuite/gdb.tui/debuginfod-query.c | 22 ++ gdb/testsuite/gdb.tui/debuginfod-query.exp | 267 ++++++++++++++++++ .../gdb.tui/tui-enable-failure-lib.c | 32 +++ gdb/testsuite/gdb.tui/tui-enable-failure.c | 22 ++ gdb/testsuite/gdb.tui/tui-enable-failure.exp | 133 +++++++++ gdb/testsuite/gdb.tui/tuiterm.exp | 2 +- gdb/testsuite/lib/gdb.exp | 27 ++ gdb/testsuite/lib/tuiterm.exp | 1 + gdb/tui/tui-data.h | 12 +- gdb/tui/tui-hooks.c | 21 +- gdb/tui/tui-layout.c | 3 +- gdb/tui/tui-regs.h | 4 +- gdb/tui/tui-wingeneral.c | 13 +- gdb/tui/tui-winsource.c | 2 + gdb/tui/tui-winsource.h | 4 +- gdb/tui/tui.c | 203 +++++++++---- gdb/tui/tui.h | 5 + 21 files changed, 1007 insertions(+), 72 deletions(-) create mode 100644 gdb/testsuite/gdb.tui/activate-from-secondary-prompt.c create mode 100644 gdb/testsuite/gdb.tui/activate-from-secondary-prompt.exp create mode 100644 gdb/testsuite/gdb.tui/activate-with-key-combo.c create mode 100644 gdb/testsuite/gdb.tui/activate-with-key-combo.exp create mode 100644 gdb/testsuite/gdb.tui/debuginfod-query.c create mode 100644 gdb/testsuite/gdb.tui/debuginfod-query.exp create mode 100644 gdb/testsuite/gdb.tui/tui-enable-failure-lib.c create mode 100644 gdb/testsuite/gdb.tui/tui-enable-failure.c create mode 100644 gdb/testsuite/gdb.tui/tui-enable-failure.exp base-commit: 32a7e94f84a3df0bcd08a2835e2c316f5ed07f77 -- 2.25.4