Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>, Simon Marchi <simark@simark.ca>
Subject: [PATCHv2 0/2] Some sentinel frame related cleanup in frame.c
Date: Mon, 22 Jun 2026 22:33:04 +0100	[thread overview]
Message-ID: <cover.1782163808.git.aburgess@redhat.com> (raw)
In-Reply-To: <f250af3c43a034f843afcb96488afa5df5cc75ad.1781802041.git.aburgess@redhat.com>

Based on Simon's feedback on the v1 patch, this new take goes in a
different direction.

Patch #1 removes a redundant sentinel frame check in frame_find_by_id,
and makes some other small, frame related cleanups in that function.

Patch #2 then stores the sentinel_frame as a frame_info_ptr object
rather than a raw frame_info pointer.  This requires reordering some
globals within the frame.c file.

Thanks,
Andrew


---

Andrew Burgess (2):
  gdb: remove sentinel frame check in frame_find_by_id
  gdb: convert sentinel_frame to a frame_info_ptr

 gdb/frame.c | 109 +++++++++++++++++++++++++---------------------------
 1 file changed, 52 insertions(+), 57 deletions(-)


base-commit: 60466ce68ac1a2d93c7f39b2638e24f48125fbf9
-- 
2.25.4


  parent reply	other threads:[~2026-06-22 21:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18 17:00 [PATCH] gdb: return raw frame_info pointer from create_sentinel_frame Andrew Burgess
2026-06-18 17:25 ` Simon Marchi
2026-06-18 17:27 ` Tom Tromey
2026-06-22 21:33 ` Andrew Burgess [this message]
2026-06-22 21:33   ` [PATCHv2 1/2] gdb: remove sentinel frame check in frame_find_by_id Andrew Burgess
2026-06-23  2:18     ` Simon Marchi
2026-06-23 10:52       ` Andrew Burgess
2026-06-22 21:33   ` [PATCHv2 2/2] gdb: convert sentinel_frame to a frame_info_ptr Andrew Burgess
2026-06-23  2:23     ` Simon Marchi
2026-06-23 10:55       ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1782163808.git.aburgess@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox