From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH 0/4] Fixes for tail call, until, and FinishBreakpoints
Date: Sat, 24 Jan 2026 11:29:10 +0000 [thread overview]
Message-ID: <cover.1769253423.git.aburgess@redhat.com> (raw)
I've been looking at places where we use get_frame_pc when we should
be using get_frame_address_in_block to handle tail calls correctly.
This got me looking at gdb.FinishBreakpoint, and I found a bunch of
things that needed fixing.
Thanks,
Andrew
---
Andrew Burgess (4):
gdb: fix frame_unwind_caller_WHAT functions for inline and tail calls
gdb/python: fix FinishBreakpoint.return_value for tail call functions
gdb/python: don't allow FinishBreakpoints for inline frames
gdb/python: fix gdb.FinishBreakpoint returning to a tail call frame
gdb/doc/python.texi | 3 +
gdb/frame.c | 35 +++--
gdb/python/py-finishbreakpoint.c | 17 +-
gdb/testsuite/gdb.base/until-in-tailcall.c | 53 +++++++
gdb/testsuite/gdb.base/until-in-tailcall.exp | 108 +++++++++++++
.../gdb.python/py-finish-breakpoint-inline.c | 58 +++++++
.../py-finish-breakpoint-inline.exp | 147 ++++++++++++++++++
.../gdb.python/py-finish-breakpoint-inline.py | 27 ++++
.../py-finish-breakpoint-tailcall.c | 45 ++++++
.../py-finish-breakpoint-tailcall.exp | 118 ++++++++++++++
.../py-finish-breakpoint-tailcall.py | 27 ++++
11 files changed, 623 insertions(+), 15 deletions(-)
create mode 100644 gdb/testsuite/gdb.base/until-in-tailcall.c
create mode 100644 gdb/testsuite/gdb.base/until-in-tailcall.exp
create mode 100644 gdb/testsuite/gdb.python/py-finish-breakpoint-inline.c
create mode 100644 gdb/testsuite/gdb.python/py-finish-breakpoint-inline.exp
create mode 100644 gdb/testsuite/gdb.python/py-finish-breakpoint-inline.py
create mode 100644 gdb/testsuite/gdb.python/py-finish-breakpoint-tailcall.c
create mode 100644 gdb/testsuite/gdb.python/py-finish-breakpoint-tailcall.exp
create mode 100644 gdb/testsuite/gdb.python/py-finish-breakpoint-tailcall.py
base-commit: 9810a515fe3aed6046760b8c1c1d3daa9ebc4334
--
2.25.4
next reply other threads:[~2026-01-24 11:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-24 11:29 Andrew Burgess [this message]
2026-01-24 11:29 ` [PATCH 1/4] gdb: fix frame_unwind_caller_WHAT functions for inline and tail calls Andrew Burgess
2026-01-27 16:37 ` Andrew Burgess
2026-01-24 11:29 ` [PATCH 2/4] gdb/python: fix FinishBreakpoint.return_value for tail call functions Andrew Burgess
2026-01-24 11:29 ` [PATCH 3/4] gdb/python: don't allow FinishBreakpoints for inline frames Andrew Burgess
2026-01-24 12:23 ` Eli Zaretskii
2026-01-24 11:29 ` [PATCH 4/4] gdb/python: fix gdb.FinishBreakpoint returning to a tail call frame Andrew Burgess
2026-03-05 13:37 ` [PATCHv2 0/4] Fixes for tail call, until, and FinishBreakpoints Andrew Burgess
2026-03-05 13:37 ` [PATCHv2 1/4] gdb: fix frame_unwind_caller_WHAT functions for inline and tail calls Andrew Burgess
2026-03-05 13:37 ` [PATCHv2 2/4] gdb/python: fix FinishBreakpoint.return_value for tail call functions Andrew Burgess
2026-03-05 13:37 ` [PATCHv2 3/4] gdb/python: don't allow FinishBreakpoints for inline frames Andrew Burgess
2026-03-05 13:37 ` [PATCHv2 4/4] gdb/python: fix gdb.FinishBreakpoint returning to a tail call frame Andrew Burgess
2026-03-05 15:59 ` [PATCHv2 0/4] Fixes for tail call, until, and FinishBreakpoints Tom Tromey
2026-03-05 17:49 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1769253423.git.aburgess@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox