From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +NKOLSy5MWlMQRkAWB0awg (envelope-from ) for ; Thu, 04 Dec 2025 11:39:08 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HxFS9HsA; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AE89C1E08D; Thu, 04 Dec 2025 11:39:08 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4F4101E08D for ; Thu, 04 Dec 2025 11:39:08 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C7FA04B1A367 for ; Thu, 4 Dec 2025 16:39:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C7FA04B1A367 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HxFS9HsA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 04DC64B1A366 for ; Thu, 4 Dec 2025 16:38:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 04DC64B1A366 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 04DC64B1A366 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764866308; cv=none; b=TMbDHLreQaUuZBlC5P8XZDugWilzHoIdaprCb7dYIqyJuZKhtFcFiReQFhb8/nKWJPzF+OxTU60WkYWRjl2IgNNguU6WbZAaYnzpHpFeafJeW3WibaPoNbmidsYUUCUbJhvlpKELACQmRWcW1ATuB44PlSanmHtjln5VWfku6mk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764866308; c=relaxed/simple; bh=4V89ilfjyTjWOxKSBXAucovG3fKDgYgXw0a72X+479M=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vHlo4ranzfucf8AdQsPx3gExGiKVC3k20mfP0BPJZRux4OtLRI2EKzNNscrB86cspoXy27x1vBhfwA3CJC8GKKKwNucrM2lMo6cKkkEaxYgZNZF18ls35iNI5c1lQa4d6rqLnoUp8jwdDY2vNn1acgz90Kmasmye2Md6XJSbfnc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 04DC64B1A366 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764866307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KKj/sT8S3CNuaEOaxnbJfZ+wlqSDQRpw6a6ALGh97pA=; b=HxFS9HsA/9tcmyR1lsjjfRJbn93KIZ6paIkHLHLjO0oUTLy9yP8v+GNsNcpkcj1Z0VKTJH eOyTYAxSs8FidbRE47v2oJOL+WroVXSA4CabS4WlcRjkUNav2XJOq22QmQzU/tEOs5AYxn 7d5RZ89FU00XHmSXtWG/2JcjLnrTE+8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-BzAr3BhrNu-CBiHyt1cHyg-1; Thu, 04 Dec 2025 11:38:26 -0500 X-MC-Unique: BzAr3BhrNu-CBiHyt1cHyg-1 X-Mimecast-MFC-AGG-ID: BzAr3BhrNu-CBiHyt1cHyg_1764866302 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-477cf25ceccso12214145e9.0 for ; Thu, 04 Dec 2025 08:38:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764866302; x=1765471102; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KKj/sT8S3CNuaEOaxnbJfZ+wlqSDQRpw6a6ALGh97pA=; b=Gz9D4H620aspmFx5i/jJfiC/Y8clpkkZlTfCWlbmbkns1dccBaufdNPwRM9BUsY7Oa 0QiKugRYP55KMNtTnclr+NBjA7T8MUfb1GETunKL2iF6uzlvKX/0DLQj3hqdB9zN5te1 xWI0jhwRyHITtHPGP2lh8TZwgAWW/2x808AZQJCgvV6Uhxwg7k3/uPCOKk/EUXXNhaih RYH2EoxN5zGFZtoXVBqPOhuhJu3BPROSshoniUg6SE6WirjN+IAmtoHFYTHqhmh2q2/y DXfs/TTZZkcIDRNA3DOO/iGezU+eo+L79gSPLWIhoy7YCra/gQb5TP9fDMx4iQeNpN5I XN4g== X-Gm-Message-State: AOJu0YwGlHDcAOSIMDzFBuWlBAQT26pCPe3ja2rZJs/8Oz9tn6/gZE1P VWUgG8LDAv3WmSZf/Dwg8tc37ry3KNy7YSoFsFiSqT8eS1c1SBAwOEHfg4yVk2Bp/ax+0N2qqpP zgFmOupGFyhdi82Cu4bw1q63J/WQT34JdgoQ1GPZT2RswyBjHUg4m5QVqYLrmLOspqIPTaDXNd2 2vt+hR69aE++674XssTu8ryjAs9NtfvCzZXscUIwisLNIY5cs= X-Gm-Gg: ASbGncumU43nfv9Bel2phkDiaRCuifTIIJDFfwbYJ75EQ0j/dXB3+4xzZWg2PXqPc8e FogbSumVGPbpeFGn1mOSkDp5loeq45dggjYHEVyRFYbh4a9Lzhmubvtx7Pn+NK4VkpEHT+Zu4rc WCMKk7+rXGGra1d4lXDuS3C3Xkg+ew0Zrpz4xVAYh61TiMl+9AOyH4TquY2fBdtIdU1+Z1kNAYa E8roKmsJ9AoBdE3C1f7YyK9uhVe+kFzqK3oZIbTeZcCvm7yX6W4x57vGIr0IAr+PzxFzxNBJf03 zCRLAFRsw91L++0AmkkDx5nxGM6cq3mS3XDMalWCdaxU8N7a2F2Z6eTBtf/g6D8TfKz5ouaDvwG 5wVWH X-Received: by 2002:a05:600c:3113:b0:477:89d5:fdac with SMTP id 5b1f17b1804b1-4792f39ccc1mr43197075e9.31.1764866301649; Thu, 04 Dec 2025 08:38:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IF3Lyr2k2MCRU/4GTDzVsj8J+QSo9h9HCeyL1Ok60CseX1XyELSf3yY0urb7nSybOQnputiLA== X-Received: by 2002:a05:600c:3113:b0:477:89d5:fdac with SMTP id 5b1f17b1804b1-4792f39ccc1mr43196575e9.31.1764866301097; Thu, 04 Dec 2025 08:38:21 -0800 (PST) Received: from localhost ([31.111.84.207]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479310a6d9dsm39123595e9.2.2025.12.04.08.38.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Dec 2025 08:38:20 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Guinevere Larsen , Andrew Burgess Subject: [PATCH 0/4] Fixes and tests related to new boxed hint startup text Date: Thu, 4 Dec 2025 16:38:13 +0000 Message-ID: X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dBiRhEkLLYGFJ6aat1SPLMZDRmltLMvNRJi7XFbVJLk_1764866302 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Started out with a minor fix for the new boxed hint start up text. Then I wrote some tests. Which exposed some bugs. Which required some additional fixes. First 2 patches are clean up. Final 2 are actual fixes. Thanks, Andrew --- Andrew Burgess (4): gdb: remove some unnecessary code from print_gdb_hints gdb: small white space fix in print_gdb_hints gdb: make get_chars_per_line return an unsigned value gdb: fix crashes and weird output from new boxed hint text gdb/cli-out.c | 4 +- gdb/main.c | 5 +- gdb/testsuite/gdb.base/startup-hints.exp | 144 +++++++++++++++++++++++ gdb/top.c | 28 +++-- gdb/utils.c | 3 +- gdb/utils.h | 5 +- 6 files changed, 170 insertions(+), 19 deletions(-) create mode 100644 gdb/testsuite/gdb.base/startup-hints.exp base-commit: a9304819899e9164c9550c601ed81d807df2c794 -- 2.47.1