From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QSuLJwWeHWk0xBIAWB0awg (envelope-from ) for ; Wed, 19 Nov 2025 05:37:57 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ya73zE2F; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9C7E41E08D; Wed, 19 Nov 2025 05:37:57 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2A12F1E08D for ; Wed, 19 Nov 2025 05:37:57 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B8E6B385275F for ; Wed, 19 Nov 2025 10:37:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B8E6B385275F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ya73zE2F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id BBDC8384D16A for ; Wed, 19 Nov 2025 10:32:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BBDC8384D16A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BBDC8384D16A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763548367; cv=none; b=rzfC8lcoaH39ktDsOIvtDAaOKtfvLgu/W5r8dCsqB1qmNpcKe54tZfTy+72whm9SNhH+OtcyFPid2p41edlZ0mutFl2Tkwjq2znGo31+c4REQIUqjmRr8eeW/P+MghvFR79MZhyOvQ4pqj5jToAZeEeQTEvw+LPxWKVjUneLrPA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763548367; c=relaxed/simple; bh=oOJq1MiBXzNDGWC6jjyMxhulV37GAJxgtdMUlyX64u4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=c/azxBG6oDrCCdJULJvd5OQ7a2r8iVtXuzd9Dob0TnLdDUcqwJaFQ0ELerps2Bek+PteVg/JAb0fbxLRU8L58S7bGRvKXrnqEhStAgUt90jC4J3DAKHuUKGwQopMut7bKCwVBUhg/0D8ah+vDN0MWjwP6Eg5dh7PfYeSSYn3Ivs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BBDC8384D16A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763548367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xs2r5fDCp/qvH6wD9cUlfnk/ZplWBCM3vkolAD+op7c=; b=Ya73zE2FMZEUefkfS60lKeheRgcrdN+lATC6vIXVhftI7HXhAGpkOPH0jGPor7OVIAXC5V QMKBMRlKxXQZWWA9pdsMyrbRIplHzVOiQgdWbBkeFksJG702t3StkfBd8N9nZQUkRbtBp+ 6JK7ajO9Sx4bWdfuiLNk9Yrz6tmW/VY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-503-edqoQtXoNy20gkiLaLNSQg-1; Wed, 19 Nov 2025 05:32:46 -0500 X-MC-Unique: edqoQtXoNy20gkiLaLNSQg-1 X-Mimecast-MFC-AGG-ID: edqoQtXoNy20gkiLaLNSQg_1763548365 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-429c5da68e5so434862f8f.1 for ; Wed, 19 Nov 2025 02:32:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763548365; x=1764153165; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xs2r5fDCp/qvH6wD9cUlfnk/ZplWBCM3vkolAD+op7c=; b=C3F6FuXNxM4iwXnZUEeSNplTihBcjQjQRn2NBIh/HiEGNyPKT4AVfTyELfOihH+bWk bnWeXuHI8zxX0FrmUPe6K1DTHZQKl9MII2QF4/LNlEYqButQIpNb6/7/nLqC0GEYlXzr c6LcVKwLgtKV3x/tC4/d1PmB1TZVuVUqZCkexEzV4lwMGFGkupH/v+wSYyXyhOLvwygi i7KJXUZOe8cgExiHRjRsRJ7ERzHxnvE1y98jw8l1E1Tfadpd2AHmFEqWp0wHh/O2jrpw No4ls5SV/IIAvhxsF/buYRxSlu3gIOEtYipmUG47UiCmE5kv/FWS8hXztww0j6q6Xl8m VW1A== X-Gm-Message-State: AOJu0Yz02QX0GRhf3elBLmAw1zGaXpPxnniL8KD5EdIjFu0o1PJMvgWQ wplRYhuPcLv9I9e2FPj2LzvO2/gMNIcjDMxfmwDZNOz27nvmlvUuGh4nup0SIBusCuFTbwInIwW F4POqOr3EE8XZGham5oCT5tFQTbBVZFvU6VOBi0GDjg16nhSGqhIyG/Qn/vyL6FkL4YInQLjyAx tVoQZ0UdbVcCATTZ0IsPFazYOjBwSxurUS6zmqQ3Cbkg82lMI= X-Gm-Gg: ASbGncsshKfalr0jyOEAklnxsUqEA3jBR+Abt4dLtjIRYtghJjhxpMwztvwcmDZvJZT 5AWZkje0iZW5vKxym8gRa2bxYsgdDSOPx2HAIQ6VAdlNZLKaZ7R1ocg9r/lBh7ijVDqhNxLdRwB Gm6/w6bKnUja6EKjE5Jsn/a2bJFKOCsA8k2GSX4zp5/vQhyHF0sTWFD8YjBtI5jSb5xG+vD9F94 AwzlF/sAlmT65+B5APG/sl83TrgcSKcTmDM1XLdIjRHqyVw/mRA/HgZjWPcmVM67/ymFJofu9GT 0WvQ3kkGnbItUI1M4hBs4VdOCZd2PJfGYdLla091PvDBSk/3Hr0e/c0+C6Ja7gbgOOuSsoUyxSZ CuQfZ X-Received: by 2002:a05:6000:40c8:b0:42b:39ee:2855 with SMTP id ffacd0b85a97d-42cb2094f4dmr2025640f8f.8.1763548364938; Wed, 19 Nov 2025 02:32:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IEVQ6Eh3sGof0oBODmIPnc2M+FyvMyRM6qnQoQyCJVUItk6JfmCcmxxqqUtAnKQdSw3TI4AHQ== X-Received: by 2002:a05:6000:40c8:b0:42b:39ee:2855 with SMTP id ffacd0b85a97d-42cb2094f4dmr2025587f8f.8.1763548364290; Wed, 19 Nov 2025 02:32:44 -0800 (PST) Received: from localhost ([31.111.84.207]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f19664sm38757827f8f.36.2025.11.19.02.32.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 02:32:43 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 0/2] Fix regression in 'list' command Date: Wed, 19 Nov 2025 10:32:36 +0000 Message-ID: X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: j63gfohKX8pome6UMQcs7VjB3cB5yug5WKEou8s5Rsw_1763548365 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org In v2: - Removed use of 'sed -i' as suggested by Andreas. - Updated the test in patch (1) to avoid failures on remote host boards. - Rebased to avoid merge conflicts with recently added styling in cli/cli-cmds.c. --- The first patch fixes a regression in the 'list' command which has been introduced since GDB 16, so should probably be fixed before GDB 17 is released. The second patch is an improvement, it's not part of the regression fix. If approved then I plan to backport the first patch only to the GDB 17 branch. Both patches would be applied to the master branch. Thanks, Andrew --- Andrew Burgess (2): gdb: fix 'list' for multiple source file results gdb: display a symbol more often in multi-file list output gdb/cli/cli-cmds.c | 8 ++ gdb/linespec.c | 15 ++- gdb/testsuite/gdb.base/list-multi-source.c | 60 +++++++++ gdb/testsuite/gdb.base/list-multi-source.exp | 129 +++++++++++++++++++ 4 files changed, 207 insertions(+), 5 deletions(-) create mode 100644 gdb/testsuite/gdb.base/list-multi-source.c create mode 100644 gdb/testsuite/gdb.base/list-multi-source.exp base-commit: d07e866442112d19511d7722014cff5e16e43413 -- 2.47.1