From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id jfPTF7WdHmc9jBwAWB0awg (envelope-from ) for ; Sun, 27 Oct 2024 16:08:21 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BmxtDiLR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 43C5E1E4FE; Sun, 27 Oct 2024 16:08:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1FEAD1E37A for ; Sun, 27 Oct 2024 16:08:20 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9D1863858D37 for ; Sun, 27 Oct 2024 20:08:19 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 8B1FB3858D26 for ; Sun, 27 Oct 2024 20:07:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B1FB3858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8B1FB3858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730059671; cv=none; b=mFiaXTG19aDevarhNieVTPnUKyrvnOTQ+ppFWxlZJ9h9ZfuTTb7vskAkOFAllLbwJSWve2MGuV9CMiP0I8U1F+h4OWakqgLvp3YGS8MDQhFTm7iul7ITkPyGcicma+6IA6G+uPbZikIb0gsmhB9IAusb45H8NV2WI7zX8GODk+4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730059671; c=relaxed/simple; bh=zdYjGq0bt2XG92DmG5NLwZGX37fFb7n4fqJx5qDlWj8=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=UQFvEwGHQSBpi9a7hA04wJRMbbBwwb2yEJy5HabEW6vDfCLpSGcGyVoOWLv9KVOKypz3I0IL3vqaDq+deuRdTRmRKXH/5zCMxi3FeVnGqQmfAVeMwHMNai/EXQogkN+Hn0GVTqJMUG7Llow7JqGrlUgEV3+djW4q61KEUfVg2TE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730059669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yX7O10PgxnJO7iFevyYJ07SZ8NtMmBbOnps9h0zuUqA=; b=BmxtDiLRWUoX5cgrcTt3dmcAdmve6mh36VBReng12X12sAJd1l95uBAup1Do+YiUlUqHvI Le26fyoY3fuCVfHcCcYT7cVH5NKpOYhBCnY9C7GtVjW4umPdCuUTevKB4DM1hv4FtgqCid +kgwPhV0TPvRRh6/4YhdZKn+FigR33o= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-270-VO-55aHFPo-vKIn_SjO6fQ-1; Sun, 27 Oct 2024 16:07:48 -0400 X-MC-Unique: VO-55aHFPo-vKIn_SjO6fQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-37d462b64e3so1889779f8f.3 for ; Sun, 27 Oct 2024 13:07:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730059665; x=1730664465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yX7O10PgxnJO7iFevyYJ07SZ8NtMmBbOnps9h0zuUqA=; b=FwfUNHn7HlQ8+JyRxIin5HEJovrvLuLeq0zXQfjx/4Y6Ik0/SUdthkCJAuN636P3hs 2/q+v2Psnjbh40weI8mt+gd9pHnsRyl6eEAWMSHk3IE6USnqFWs3vhmZ0uMjtz5+ut8n BRjyft1iTYgfi5RjL0vBQnStxoMulQJzwnPdnekIkuhOi7RpRLxleiq0bKYV63i6NW/h q3V3XzUg0M8Bkvd00NFq+wYAwoz7Mt7Ghkd41lK0TubAx9o2LZ5DTs2cSbUitj+IxnPd 2VL5zT2KpIr06Gw+nfQ90RvauUvrGXn6+YjH3fORRc/iEa0pTbmGDyTq4EIuwtPo6uqr SBmQ== X-Gm-Message-State: AOJu0YwtSgFYoyT7YkXCnMqrChr4/5F5u7vpFN2ndmjvkZDFJ0MCITPJ NDQlwwtLsHidmZDQ2i+hzLcWG7jluZEaddi2josLSqBt3BSLSPXWPVAoyzB5/tVaiWBsDVUnO4D 4H1bdE/exYV5B2jc6ND99PhvhXJ2fSp2eD7Z7Wv3nuA8/ZTclsD7KzMhtX1gsRUyBnB+bfd8Jkh sQRwV5h3de8mFcmJjwm8o1EWGqZUwX60PU1bgfnGhh0W4= X-Received: by 2002:a5d:4fcf:0:b0:37d:3973:cb8d with SMTP id ffacd0b85a97d-38061159fbdmr4500078f8f.24.1730059665551; Sun, 27 Oct 2024 13:07:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG7OVifF8tCYSrmL4TtDUOEjszIsMoYTsK8TCMk3qCHPldFRdI6XSA/6Etl1pbnAlstp7uQWA== X-Received: by 2002:a5d:4fcf:0:b0:37d:3973:cb8d with SMTP id ffacd0b85a97d-38061159fbdmr4500066f8f.24.1730059665039; Sun, 27 Oct 2024 13:07:45 -0700 (PDT) Received: from localhost (197.209.200.146.dyn.plus.net. [146.200.209.197]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38058b47aa8sm7543911f8f.51.2024.10.27.13.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 13:07:44 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv5 0/3] Returning osabi from gdbserer in more cases Date: Sun, 27 Oct 2024 20:07:39 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org In v5: - Rebased to current HEAD. - Retested. In v4: - Updated a default value of osabi in gdb/regformats/regdat.sh in patch #3 which fixed a build failure highlighted by the sourceware CI testing. - Rebased onto current master. --- This series replaces patch #5 which I posted here: https://inbox.sourceware.org/gdb-patches/77fa25e6f6fd213f89ebceb7c1fcf33010cc8e39.1728407374.git.aburgess@redhat.com I did merge that patch, but then CI testing flagged build errors on a number of targets. Unfortunately I'd overlooked that we have two ways of creating target_desc objects within gdbserver. The (I think) older approach that uses fixed xml files, and the newer (I think) features based approach. My changes handled the features based approach, but completely overlooked the fixed xml file approach. This series should fix that oversight. Patches #1 and #2 do some prep work. Then patch #3 makes the important change. The general approach is unchange from my original attempt, but thanks to the groundwork in the first two patches I'm now able to also update the fixed xml file targets too. I have done some testing of this version on a couple of targets that use the fixed xml approach, so I'm pretty confident this is now OK. But I have also pushed a try- branch for some additional confidence. Thanks, Andrew --- Andrew Burgess (3): gdb/features: set osabi in all Linux related features/*.xml files gdb/regformats: add osabi information to generated .dat files gdbserver: pass osabi to GDB in more target descriptions gdb/features/Makefile | 2 + gdb/features/mips64-dsp-linux.c | 2 + gdb/features/mips64-dsp-linux.xml | 1 + gdb/features/mips64-linux.c | 2 + gdb/features/mips64-linux.xml | 1 + gdb/features/print-osabi.xsl | 39 +++++++++++++++++++ gdb/features/s390-gs-linux64.c | 2 + gdb/features/s390-gs-linux64.xml | 1 + gdb/features/s390-linux32.c | 2 + gdb/features/s390-linux32.xml | 1 + gdb/features/s390-linux32v1.c | 2 + gdb/features/s390-linux32v1.xml | 1 + gdb/features/s390-linux32v2.c | 2 + gdb/features/s390-linux32v2.xml | 1 + gdb/features/s390-linux64.c | 2 + gdb/features/s390-linux64.xml | 1 + gdb/features/s390-linux64v1.c | 2 + gdb/features/s390-linux64v1.xml | 1 + gdb/features/s390-linux64v2.c | 2 + gdb/features/s390-linux64v2.xml | 1 + gdb/features/s390-te-linux64.c | 2 + gdb/features/s390-te-linux64.xml | 1 + gdb/features/s390-tevx-linux64.c | 2 + gdb/features/s390-tevx-linux64.xml | 1 + gdb/features/s390-vx-linux64.c | 2 + gdb/features/s390-vx-linux64.xml | 1 + gdb/features/s390x-gs-linux64.c | 2 + gdb/features/s390x-gs-linux64.xml | 1 + gdb/features/s390x-linux64.c | 2 + gdb/features/s390x-linux64.xml | 1 + gdb/features/s390x-linux64v1.c | 2 + gdb/features/s390x-linux64v1.xml | 1 + gdb/features/s390x-linux64v2.c | 2 + gdb/features/s390x-linux64v2.xml | 1 + gdb/features/s390x-te-linux64.c | 2 + gdb/features/s390x-te-linux64.xml | 1 + gdb/features/s390x-tevx-linux64.c | 2 + gdb/features/s390x-tevx-linux64.xml | 1 + gdb/features/s390x-vx-linux64.c | 2 + gdb/features/s390x-vx-linux64.xml | 1 + gdb/regformats/mips-dsp-linux.dat | 1 + gdb/regformats/mips-linux.dat | 1 + gdb/regformats/mips64-dsp-linux.dat | 1 + gdb/regformats/mips64-linux.dat | 1 + gdb/regformats/nios2-linux.dat | 1 + gdb/regformats/or1k-linux.dat | 1 + gdb/regformats/regdat.sh | 14 +++++-- gdb/regformats/rs6000/powerpc-32.dat | 1 + gdb/regformats/rs6000/powerpc-32l.dat | 1 + gdb/regformats/rs6000/powerpc-64l.dat | 1 + gdb/regformats/rs6000/powerpc-altivec32l.dat | 1 + gdb/regformats/rs6000/powerpc-altivec64l.dat | 1 + gdb/regformats/rs6000/powerpc-e500l.dat | 1 + gdb/regformats/rs6000/powerpc-isa205-32l.dat | 1 + gdb/regformats/rs6000/powerpc-isa205-64l.dat | 1 + .../rs6000/powerpc-isa205-altivec32l.dat | 1 + .../rs6000/powerpc-isa205-altivec64l.dat | 1 + .../rs6000/powerpc-isa205-ppr-dscr-vsx32l.dat | 1 + .../rs6000/powerpc-isa205-ppr-dscr-vsx64l.dat | 1 + .../rs6000/powerpc-isa205-vsx32l.dat | 1 + .../rs6000/powerpc-isa205-vsx64l.dat | 1 + .../rs6000/powerpc-isa207-htm-vsx32l.dat | 1 + .../rs6000/powerpc-isa207-htm-vsx64l.dat | 1 + .../rs6000/powerpc-isa207-vsx32l.dat | 1 + .../rs6000/powerpc-isa207-vsx64l.dat | 1 + gdb/regformats/rs6000/powerpc-vsx32l.dat | 1 + gdb/regformats/rs6000/powerpc-vsx64l.dat | 1 + gdb/regformats/s390-gs-linux64.dat | 1 + gdb/regformats/s390-linux32.dat | 1 + gdb/regformats/s390-linux32v1.dat | 1 + gdb/regformats/s390-linux32v2.dat | 1 + gdb/regformats/s390-linux64.dat | 1 + gdb/regformats/s390-linux64v1.dat | 1 + gdb/regformats/s390-linux64v2.dat | 1 + gdb/regformats/s390-te-linux64.dat | 1 + gdb/regformats/s390-tevx-linux64.dat | 1 + gdb/regformats/s390-vx-linux64.dat | 1 + gdb/regformats/s390x-gs-linux64.dat | 1 + gdb/regformats/s390x-linux64.dat | 1 + gdb/regformats/s390x-linux64v1.dat | 1 + gdb/regformats/s390x-linux64v2.dat | 1 + gdb/regformats/s390x-te-linux64.dat | 1 + gdb/regformats/s390x-tevx-linux64.dat | 1 + gdb/regformats/s390x-vx-linux64.dat | 1 + gdb/regformats/tic6x-c62x-linux.dat | 1 + gdb/regformats/tic6x-c64x-linux.dat | 1 + gdb/regformats/tic6x-c64xp-linux.dat | 1 + gdbserver/Makefile.in | 9 +++-- gdbserver/linux-aarch32-tdesc.cc | 2 +- gdbserver/linux-aarch64-tdesc.cc | 3 +- gdbserver/linux-arc-low.cc | 2 +- gdbserver/linux-arm-tdesc.cc | 2 +- gdbserver/linux-csky-low.cc | 2 +- gdbserver/linux-loongarch-low.cc | 2 +- gdbserver/linux-riscv-low.cc | 2 +- gdbserver/linux-x86-tdesc.cc | 15 ++++++- gdbserver/netbsd-aarch64-low.cc | 2 +- gdbserver/netbsd-amd64-low.cc | 2 +- gdbserver/netbsd-i386-low.cc | 2 +- gdbserver/tdesc.cc | 5 ++- gdbserver/tdesc.h | 6 ++- gdbserver/win32-i386-low.cc | 4 +- gdbserver/win32-low.h | 7 ++++ 103 files changed, 200 insertions(+), 25 deletions(-) create mode 100644 gdb/features/print-osabi.xsl base-commit: a723c56efb07c4f8b3f6a3ed4b878a2f8f5572cc -- 2.25.4