From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iWSOMIWmCWcvSQoAWB0awg (envelope-from ) for ; Fri, 11 Oct 2024 18:28:21 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OpAbyZ2M; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AD0E51E358; Fri, 11 Oct 2024 18:28:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C6E881E05C for ; Fri, 11 Oct 2024 18:28:19 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 54467385AC31 for ; Fri, 11 Oct 2024 22:28:19 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 128AC3858D26 for ; Fri, 11 Oct 2024 22:27:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 128AC3858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 128AC3858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728685669; cv=none; b=quCrVzT6wwrfA93YCWhzxeJqh5KEmrlDix79Tm9z542bkv+0K5y7hrB27jmvcPCbcUSx5nkx6uFqTcFBC1IxKNVWOFiRI9liBFaC46QX+bJQVX2T4GnA//QE7YdEdUXL2+ciSWr/7Ts/FeAWjtR4wF82T4jBlDTAZsdMbHCBczw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728685669; c=relaxed/simple; bh=4dfwUQe1uOFQSIWkOR13I24GuoK6Bih7/DwvXy2Pr54=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=TuadiDOKEHtPd9C5rBSxWQhauoS9HXQs2pzhFpq7sOpzj06pdB1HgadKXeAa3OLmhHrGCeS2gtMjxn7Ab+nT2QpLOM35vdmdCUkGa3dnNFaefwvdJY7ZeqlBDCIkkY9O/cb+dBmYucFCBKMpcFU/oaIC1vlN8+l+5bqWRIXirq8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728685666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=B+3IhnGMzUeFqeGKz3S4NEiM4FQW6XYuiBMDsXFwg3U=; b=OpAbyZ2MTTTjoUFZIFCNtfHkt1E7TLGLAlZqVKPIx3wspv+o6SkQ2o3laoEKq7AYKt0U1J LjmFlgq/z/3LthUbnj2yFNblUF8kV9QMM1UGYIuS/tjivjw37hespxKsF+pmIdG1rwD9H1 bs/5kP4e2KSTz/GRHCTMbXrhWbXWHbU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-zwq8-cuIMwaFG2PDk7-AZw-1; Fri, 11 Oct 2024 18:27:45 -0400 X-MC-Unique: zwq8-cuIMwaFG2PDk7-AZw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-37d462b64e3so938689f8f.3 for ; Fri, 11 Oct 2024 15:27:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728685663; x=1729290463; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B+3IhnGMzUeFqeGKz3S4NEiM4FQW6XYuiBMDsXFwg3U=; b=R0OGLXgZBOImmlBL1kVO6GqYK9ZDolfte/Vmr4Y6sVlDyQA9X0X49WfJ8kmg+LJ7cG SzBqFz4ItGpcgjpaw+dWVOLnpSgYjUgphx9qeTq3fRkiV2/AXpVFWzUIDaochpqj7f64 a9ffAZr+DdToQewTkt84EUe5rIOns1EmLEE1QxxfGxQg3jvXAfKQbCcr+jllnnRPRYUo OsG/olpCdrLhVKSp3uUflZfY43eEc0zN6NVDPToCsakMAxNqzpjK9bJwcS2iUFoCW8lC Pq5uh9YfLff62Fuegab8uS3Ebu0AElqP8yMdeU+tKFJOI5peHKl02TQoq+ye3OonAawU fjnA== X-Gm-Message-State: AOJu0Yyu+L813MOHd0sDMyFfX9eg/ObQFx7yP/0r4e85v+alzEWMS2sR tPCxYJrFkySG53zxZvLoD6OJe0G0Q42jb0/jICDEMrXNvvZP7z7LP4wmZV7yxSjcQwARxCgawG1 QDUbjkHjRTKq3FOLvXDBD1p1wCe01ODRL6BUuGehWjraBoZcm5ofZxQjiKgzBm7GgHkQZ5pWD4b 5Z52xdy5pB9DUkC4CZ4FNXRQuAu5iKU/G6It7OUrr+/WI= X-Received: by 2002:a5d:6311:0:b0:37d:37b2:385d with SMTP id ffacd0b85a97d-37d5fe9566amr653423f8f.12.1728685663308; Fri, 11 Oct 2024 15:27:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHka2Nj9zZdTcaodxsIM+wgGg24JGzXSBuK+kAIPn/n4hd3OFQrImdhK/vtW1EGHuqxWNSW/Q== X-Received: by 2002:a5d:6311:0:b0:37d:37b2:385d with SMTP id ffacd0b85a97d-37d5fe9566amr653416f8f.12.1728685662879; Fri, 11 Oct 2024 15:27:42 -0700 (PDT) Received: from localhost ([195.213.152.26]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4311835d784sm51878835e9.46.2024.10.11.15.27.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 15:27:42 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv3 0/3] Returning osabi from gdbserer in more cases Date: Fri, 11 Oct 2024 23:27:37 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This series replaces patch #5 which I posted here: https://inbox.sourceware.org/gdb-patches/77fa25e6f6fd213f89ebceb7c1fcf33010cc8e39.1728407374.git.aburgess@redhat.com I did merge that patch, but then CI testing flagged build errors on a number of targets. Unfortunately I'd overlooked that we have two ways of creating target_desc objects within gdbserver. The (I think) older approach that uses fixed xml files, and the newer (I think) features based approach. My changes handled the features based approach, but completely overlooked the fixed xml file approach. This series should fix that oversight. Patches #1 and #2 do some prep work. Then patch #3 makes the important change. The general approach is unchange from my original attempt, but thanks to the groundwork in the first two patches I'm now able to also update the fixed xml file targets too. I have done some testing of this version on a couple of targets that use the fixed xml approach, so I'm pretty confident this is now OK. But I have also pushed a try- branch for some additional confidence. Thanks, Andrew --- Andrew Burgess (3): gdb/features: set osabi in all Linux related features/*.xml files gdb/regformats: add osabi information to generated .dat files gdbserver: pass osabi to GDB in more target descriptions gdb/features/Makefile | 2 + gdb/features/mips64-dsp-linux.c | 2 + gdb/features/mips64-dsp-linux.xml | 1 + gdb/features/mips64-linux.c | 2 + gdb/features/mips64-linux.xml | 1 + gdb/features/print-osabi.xsl | 39 +++++++++++++++++++ gdb/features/s390-gs-linux64.c | 2 + gdb/features/s390-gs-linux64.xml | 1 + gdb/features/s390-linux32.c | 2 + gdb/features/s390-linux32.xml | 1 + gdb/features/s390-linux32v1.c | 2 + gdb/features/s390-linux32v1.xml | 1 + gdb/features/s390-linux32v2.c | 2 + gdb/features/s390-linux32v2.xml | 1 + gdb/features/s390-linux64.c | 2 + gdb/features/s390-linux64.xml | 1 + gdb/features/s390-linux64v1.c | 2 + gdb/features/s390-linux64v1.xml | 1 + gdb/features/s390-linux64v2.c | 2 + gdb/features/s390-linux64v2.xml | 1 + gdb/features/s390-te-linux64.c | 2 + gdb/features/s390-te-linux64.xml | 1 + gdb/features/s390-tevx-linux64.c | 2 + gdb/features/s390-tevx-linux64.xml | 1 + gdb/features/s390-vx-linux64.c | 2 + gdb/features/s390-vx-linux64.xml | 1 + gdb/features/s390x-gs-linux64.c | 2 + gdb/features/s390x-gs-linux64.xml | 1 + gdb/features/s390x-linux64.c | 2 + gdb/features/s390x-linux64.xml | 1 + gdb/features/s390x-linux64v1.c | 2 + gdb/features/s390x-linux64v1.xml | 1 + gdb/features/s390x-linux64v2.c | 2 + gdb/features/s390x-linux64v2.xml | 1 + gdb/features/s390x-te-linux64.c | 2 + gdb/features/s390x-te-linux64.xml | 1 + gdb/features/s390x-tevx-linux64.c | 2 + gdb/features/s390x-tevx-linux64.xml | 1 + gdb/features/s390x-vx-linux64.c | 2 + gdb/features/s390x-vx-linux64.xml | 1 + gdb/regformats/mips-dsp-linux.dat | 1 + gdb/regformats/mips-linux.dat | 1 + gdb/regformats/mips64-dsp-linux.dat | 1 + gdb/regformats/mips64-linux.dat | 1 + gdb/regformats/nios2-linux.dat | 1 + gdb/regformats/or1k-linux.dat | 1 + gdb/regformats/regdat.sh | 14 +++++-- gdb/regformats/rs6000/powerpc-32.dat | 1 + gdb/regformats/rs6000/powerpc-32l.dat | 1 + gdb/regformats/rs6000/powerpc-64l.dat | 1 + gdb/regformats/rs6000/powerpc-altivec32l.dat | 1 + gdb/regformats/rs6000/powerpc-altivec64l.dat | 1 + gdb/regformats/rs6000/powerpc-e500l.dat | 1 + gdb/regformats/rs6000/powerpc-isa205-32l.dat | 1 + gdb/regformats/rs6000/powerpc-isa205-64l.dat | 1 + .../rs6000/powerpc-isa205-altivec32l.dat | 1 + .../rs6000/powerpc-isa205-altivec64l.dat | 1 + .../rs6000/powerpc-isa205-ppr-dscr-vsx32l.dat | 1 + .../rs6000/powerpc-isa205-ppr-dscr-vsx64l.dat | 1 + .../rs6000/powerpc-isa205-vsx32l.dat | 1 + .../rs6000/powerpc-isa205-vsx64l.dat | 1 + .../rs6000/powerpc-isa207-htm-vsx32l.dat | 1 + .../rs6000/powerpc-isa207-htm-vsx64l.dat | 1 + .../rs6000/powerpc-isa207-vsx32l.dat | 1 + .../rs6000/powerpc-isa207-vsx64l.dat | 1 + gdb/regformats/rs6000/powerpc-vsx32l.dat | 1 + gdb/regformats/rs6000/powerpc-vsx64l.dat | 1 + gdb/regformats/s390-gs-linux64.dat | 1 + gdb/regformats/s390-linux32.dat | 1 + gdb/regformats/s390-linux32v1.dat | 1 + gdb/regformats/s390-linux32v2.dat | 1 + gdb/regformats/s390-linux64.dat | 1 + gdb/regformats/s390-linux64v1.dat | 1 + gdb/regformats/s390-linux64v2.dat | 1 + gdb/regformats/s390-te-linux64.dat | 1 + gdb/regformats/s390-tevx-linux64.dat | 1 + gdb/regformats/s390-vx-linux64.dat | 1 + gdb/regformats/s390x-gs-linux64.dat | 1 + gdb/regformats/s390x-linux64.dat | 1 + gdb/regformats/s390x-linux64v1.dat | 1 + gdb/regformats/s390x-linux64v2.dat | 1 + gdb/regformats/s390x-te-linux64.dat | 1 + gdb/regformats/s390x-tevx-linux64.dat | 1 + gdb/regformats/s390x-vx-linux64.dat | 1 + gdb/regformats/tic6x-c62x-linux.dat | 1 + gdb/regformats/tic6x-c64x-linux.dat | 1 + gdb/regformats/tic6x-c64xp-linux.dat | 1 + gdbserver/Makefile.in | 9 +++-- gdbserver/linux-aarch32-tdesc.cc | 2 +- gdbserver/linux-aarch64-tdesc.cc | 3 +- gdbserver/linux-arc-low.cc | 2 +- gdbserver/linux-arm-tdesc.cc | 2 +- gdbserver/linux-csky-low.cc | 2 +- gdbserver/linux-loongarch-low.cc | 2 +- gdbserver/linux-riscv-low.cc | 2 +- gdbserver/linux-x86-tdesc.cc | 15 ++++++- gdbserver/netbsd-aarch64-low.cc | 2 +- gdbserver/netbsd-amd64-low.cc | 2 +- gdbserver/netbsd-i386-low.cc | 2 +- gdbserver/tdesc.cc | 5 ++- gdbserver/tdesc.h | 6 ++- gdbserver/win32-i386-low.cc | 4 +- gdbserver/win32-low.h | 7 ++++ 103 files changed, 200 insertions(+), 25 deletions(-) create mode 100644 gdb/features/print-osabi.xsl base-commit: 5bc1b13676bc5eeefc50d25379991f5f9255eb80 -- 2.25.4