From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id B/maFtW4u2W/fA8AWB0awg (envelope-from ) for ; Thu, 01 Feb 2024 10:29:25 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aTyGGBuE; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4F46F1E0C3; Thu, 1 Feb 2024 10:29:25 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3EF991E092 for ; Thu, 1 Feb 2024 10:29:23 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 775AE385735D for ; Thu, 1 Feb 2024 15:29:22 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 26B783857B82 for ; Thu, 1 Feb 2024 15:28:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 26B783857B82 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 26B783857B82 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706801321; cv=none; b=UIKgKB2IefNjFvahVdOW1RM94YrWeB7b2hC6XdE3bGy3OmoYdIgIP+3fOoK+NEMGeHBw91KIm0lyf187i2RP5M7if+nq6Bas8enudJUnt/Rl3MG358vd3Hkbd65CqENBhz3bG4h+KrkTaRnIpPMko5Zmme+92ldYt1XgV73kBRY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706801321; c=relaxed/simple; bh=KAeZk+pEVPIY9oE4I6AUD/sjS4v7/VlsqzkjTeallV8=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=x8iKM5983vrkAvN8HTceVmfeXty+JPJKJOULUiLi1ENOROss1qGvFOF+N8J4ccT4rG8/3wkJkOGoleyjIW1FmBxt2YxfeFpnbDIdlKjBkAryqzNtQmQrHdxKYkbp5GXTS4ykcFIP43iApl4ruS4c2RcntE7BcbVR6s0ZiRixEyo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706801319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J3TAC+qGSb8xbrsM1PDr+3a0M9hYJubCGWOcfFQ2J2U=; b=aTyGGBuEjYD4mWIq6MKV+prS90Xins78PWVMl9CMQvwwVk+12CiuBYg+mv35h9c76lMJqi XiGhiNjt4a/e5/pgJBjSWHGJ1vvOwLIUtBU13iFjTSn5bDmakS98iOV0FY2udpQ8Q7IkH/ rRuz9669gp50FjH6IdLpELm3351doxA= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-410-xhllA0xlOn6ncNdEJsr4KQ-1; Thu, 01 Feb 2024 10:28:38 -0500 X-MC-Unique: xhllA0xlOn6ncNdEJsr4KQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5111b864decso860266e87.1 for ; Thu, 01 Feb 2024 07:28:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706801316; x=1707406116; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J3TAC+qGSb8xbrsM1PDr+3a0M9hYJubCGWOcfFQ2J2U=; b=eTcqQdc3aBKjHIIxdrn2cSNNow//ll9XMThSclEdngcOcKOnFqsUR4h76XcER/ppGP jny2aKQe4WV5+Uf04Xw0aEZbdURuhuBHySUwDJdfF7Nr+tQRZsoNyQc/JaxSgcP4MS7e 5iMy1UL1gmmkI207Zg7XryFCZd7djyc1O4ppesP9AuA+1Ah9veKAu6xhfo7q3fkbcPcf 82Nk9zzMCft9z4LqUhED841l7WTo3mG0lncIilVAmTWYUu0Jbl/qb/onQJxybN11UuV2 QMJTzqecSeg5NTtF71UhKmepPBvABQnrwHuLpuSvu6Tfv9wSNWEoz//UvyiCB5TJuU3v 0r7A== X-Gm-Message-State: AOJu0YyPT8DUrZCb+9cdBmly3l/+XIx7f4Y0IX0y9PVUUIm1xLUTdOOT KWYcilOnSy4xsLduMfo+ptmuzcJAFQEs4dVoKXnaN7y3UfdoZlfDVUtblggXXjgLJPjx5rmW7IV KrMI6IlnPeKZI6lL9pfaW/00uUTcYClcg2uCjkOc1TzgVrl/T9GQPSjeFX0rqCbPuVGHrq82Ae+ hY3+sjIS5/MOa6KVRe0oRcofCg/kbpm6IT2YGv6f2HFV0= X-Received: by 2002:a05:6512:e85:b0:510:544:78f with SMTP id bi5-20020a0565120e8500b005100544078fmr2371902lfb.14.1706801316767; Thu, 01 Feb 2024 07:28:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IHbxZFjOknV0LVvGyeARmjHbsCRWDQz3Tx4svzzZUnNQMvQtndA+rWjiec1O9VHXayjvYtcSA== X-Received: by 2002:a05:6512:e85:b0:510:544:78f with SMTP id bi5-20020a0565120e8500b005100544078fmr2371878lfb.14.1706801316365; Thu, 01 Feb 2024 07:28:36 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id h11-20020a05600c350b00b0040fb989f4bdsm2493738wmq.23.2024.02.01.07.28.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 07:28:36 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 0/7] x86/Linux Target Description Changes Date: Thu, 1 Feb 2024 15:28:27 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org This series started when I ran the test script gdb.server/connect-with-no-symbol-file.exp on an x86-64/Linux target (with the unix board file) and noticed that two core files were left behind. The test is a gdbserver test (even when the unix board is used), and the two core files are generated by the inferior as gdbserver detaches from them. I tracked the problem down to some issues with how gdbserver creates its target descriptions. Instead of just fixing gdbserver I think it would be good to share more of the target description creation code between GDB and gdbserver, the issue that gdbserver has is already fixed on the GDB side. By patch #5 enough code is shared that the problem mentioned above is fixed. Patches #6 and #7 try to share more code between GDB and gdbserver as I think this is a good thing. Thanks, Andrew --- Andrew Burgess (7): gdbserver: convert have_ptrace_getregset to a tribool gdb/x86: move reading of cs and ds state into gdb/nat directory gdbserver/x86: move no-xml code earlier in x86_linux_read_description gdb/gdbserver: share I386_LINUX_XSAVE_XCR0_OFFSET definition gdb/gdbserver: share some code relating to target description creation gdbserver: update target description creation for x86/linux gdb/gdbserver: share x86/linux tdesc caching gdb/Makefile.in | 1 + gdb/amd64-linux-tdep.c | 33 +-- gdb/amd64-linux-tdep.h | 6 - gdb/configure.nat | 4 +- gdb/i386-linux-tdep.c | 32 +-- gdb/i386-linux-tdep.h | 23 -- gdb/nat/x86-linux-tdesc.c | 405 +++++++++++++++++++++++++++++++++++ gdb/nat/x86-linux-tdesc.h | 115 ++++++++++ gdb/nat/x86-linux.c | 47 ++++ gdb/nat/x86-linux.h | 48 +++++ gdb/x86-linux-nat.c | 123 ++--------- gdbserver/Makefile.in | 4 + gdbserver/configure.srv | 4 + gdbserver/linux-amd64-ipa.cc | 45 +--- gdbserver/linux-arm-low.cc | 6 +- gdbserver/linux-i386-ipa.cc | 25 +-- gdbserver/linux-low.cc | 2 +- gdbserver/linux-low.h | 2 +- gdbserver/linux-x86-low.cc | 185 +++++----------- gdbserver/linux-x86-tdesc.cc | 141 +----------- gdbserver/linux-x86-tdesc.h | 56 ----- 21 files changed, 737 insertions(+), 570 deletions(-) create mode 100644 gdb/nat/x86-linux-tdesc.c create mode 100644 gdb/nat/x86-linux-tdesc.h delete mode 100644 gdbserver/linux-x86-tdesc.h base-commit: 05d1b4b4ad7d74a64cc71c53d621241fc393fcb6 -- 2.25.4