From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gKY9Nhr0pmXn/j0AWB0awg (envelope-from ) for ; Tue, 16 Jan 2024 16:24:42 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=jPLaV2Hv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D00171E0D0; Tue, 16 Jan 2024 16:24:42 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B5F3E1E098 for ; Tue, 16 Jan 2024 16:24:40 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1026F3858C42 for ; Tue, 16 Jan 2024 21:24:40 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 78C9A3858D1E for ; Tue, 16 Jan 2024 21:24:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 78C9A3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 78C9A3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705440251; cv=none; b=mRKKCBL+0OUZKsqRgq8vAoAVFM3HWxtaTKhnUlgqD0GyC+QKt3p0/w5IGkKo02cEYEd1o7t7lSwM1g65IbGWL16Q8suzredKOg163KmH7ZLjW9TrTTG41I/HwquqyiBvOwPOkcxrLll9UGnYaxV0f0WCsqgyUDIrw0U2qyJU6WQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705440251; c=relaxed/simple; bh=WTaOlbH3jcfb3EVyQgzMFK55FE3lPBDdMyYJSPkeGSI=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=PzZQn/ne/NJnHvNXEjh9RrQluwKOg/CaiNCWP7Pu6Cg3/WW5ZV7Ah7MP5Hm0PFh3FXhwmqr7oaAvcJAVilVAE8gKk8OB7GP5d3eyGf4eI/rN6+opgq0cJPcO0hcah1EKN0iiNy/u8MlZjea0QROsaaOp7w2aOuT97MRmnZF8VqA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705440248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6GGxNXf03KqdgrcWP/bQ7GBPPcmQZxZaFAkZOdNj0uo=; b=jPLaV2HvJUIj7IGTOy8VM3pgk04P3zISEBgr4CYLLucoJo7zIzgVFl4kbyZLMCTvIFZGB0 HFr4qjkpUOA/VNsx7WyJC6bKwPSq8EDRvbCqZUWruaCQT7dikJO+Cw9M4CtVEVEzCoxuy6 6wgHKkEgJf5ds7Vl7c8L7+OqrCEF+fo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-161-7tCKkAPSPpy20huqAthCpA-1; Tue, 16 Jan 2024 16:24:06 -0500 X-MC-Unique: 7tCKkAPSPpy20huqAthCpA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40e8609c36fso6378845e9.1 for ; Tue, 16 Jan 2024 13:24:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705440244; x=1706045044; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6GGxNXf03KqdgrcWP/bQ7GBPPcmQZxZaFAkZOdNj0uo=; b=Je8R/7biYHv6FW4oyLW0iBXYS58gtqQ2KISkENN1cC0E3X1wcKjTIaOHdJXBinzJJc NA8g+dYEjI6z9JhQfjx78mvF8JGJe6DM2dEOES+TxiPenQ7zBVx+0rdlvdt4r+eI2/Hf o3z55qJJB+dC5x48v03qyOIuRj1miGci4OcKK1kn8DJFdKaLKbPieCXXGKUdnJYGO4+Q +RY5RRdaSKo9x1TNnVwm1d3/y7RFFi7eZ4HilE1fFEyYUq08KA670CDr4j8VGvf/xm4S E2RQVa1REVTdjwgVi07qSiwSsSgsjtplB6kTG2opYd18vG0IUXA0gZcgpFS1nfvJpxQh oaLA== X-Gm-Message-State: AOJu0YxEKcae8/8E4WBAh7mUOyxOHnpAX9/e1/l2HxdQJrCPu1OaA3Dt 9gycsbSSQLQmU91wFcQ44M/uh575VJfeON1wLNiSB/tWonNALff2IsQREqRs7ef+yL5gY5FewN9 js0jZ/Kam2XH8WVgoTEydSLzZzetw3O0HgSFyIcueukW1MZTqyIYKioSGGi2sIPx1FfersV8fWz hswo2IgXx05VIS6w== X-Received: by 2002:a05:600c:63c3:b0:40e:4660:48f1 with SMTP id dx3-20020a05600c63c300b0040e466048f1mr2217807wmb.356.1705440244235; Tue, 16 Jan 2024 13:24:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IHY3WsGT3eEtZNb+9BHcslEIiLl2nIbW579U4vwJRtACA/yoGYe3cYQe/2Ou7ATGer6KWRCSQ== X-Received: by 2002:a05:600c:63c3:b0:40e:4660:48f1 with SMTP id dx3-20020a05600c63c300b0040e466048f1mr2217800wmb.356.1705440243909; Tue, 16 Jan 2024 13:24:03 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id n18-20020a05600c501200b0040e77ce8768sm8565869wmr.16.2024.01.16.13.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 13:24:03 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 0/5] Cleanup and changes for file name completion Date: Tue, 16 Jan 2024 21:23:57 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org I'm currently working on improving file name completion. I have more changes that I'm still working on, but I wanted to post what I have so far. There's some cleanup in here: patches #1, #4, and #5. There's a bug fix in patch #2. And there's some (minor) new functionality in patch #3. Thanks, Andrew --- Andrew Burgess (5): gdb: remove skip_quoted and skip_quoted_chars gdb: fix bug where quote characters would become nullptr gdb: allow double quotes for quoting filenames gdb: remove some dead code from completer.c gdb: remove special case completion word handling for filenames gdb/completer.c | 126 ++++-------------- gdb/completer.h | 7 - gdb/p-exp.y | 26 +++- .../gdb.base/filename-completion.exp | 66 ++++++--- gdb/top.c | 1 - 5 files changed, 98 insertions(+), 128 deletions(-) base-commit: 1b346e50485ee450e8103e4b1704b43f61bc39f7 -- 2.25.4