From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WZYGCSchlGUA+DAAWB0awg (envelope-from ) for ; Tue, 02 Jan 2024 09:43:51 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=R0fwPFh5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1682F1E0D0; Tue, 2 Jan 2024 09:43:51 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 04FFF1E0B9 for ; Tue, 2 Jan 2024 09:43:49 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8104E385840F for ; Tue, 2 Jan 2024 14:43:48 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 594013858D32 for ; Tue, 2 Jan 2024 14:43:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 594013858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 594013858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704206603; cv=none; b=aw+aY6N7ZUbVQw+ZeU4wcPRyLg1tUo4iW/g1C7ZRq4joDmxce8t8jlTMiyD+GeDCqyH4MH6/aivxHS9z7bM6CPDC5PR9xR5iAs3T4TzVGcUWMXtEJ47cD4pA0vCvtO8IZjkMABXnn3479sGzpsnP1QLWMpX8Ph2z2bIRJ3ckE0M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704206603; c=relaxed/simple; bh=6fVsTKjlbo2sxvh3D0n7DWsjIto7A+Rj3MAVIQBKe6M=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=jCzWtqwUUql8VyDEfXXsXnnyjQwcGBuDtfZFsf4D7EACuNJgnM7YTg313TWaCKzqsuAvmVyXSAuOpeQjmVBFh2nQsI16ooVB1EnasatxUTD/GqFP23thTWcq5ZFZR+KD8GQ2ha1XQIcNlAGDAa1nZjvrsY4G/KZUkePY399WbB8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704206602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WhdTpu1Gj/Rs/x1LOHxucotzzEaZClycuQxyUWEHmIg=; b=R0fwPFh5fYQFL3qZ43bpx8Id80z/vGklGvg6ISz25LZFCSw5DMpeQ7AXOXgRZEr3RKlMrE TWpNH7lSCAHxOFH756FcItVBHcQGNHf8RKvSFmocQvN/i7xGs3R5iSMpzlhJth1BuR4XBv 5K6xdqpPDmCcSFgvLoHVoqJXACMZyng= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-MX-l_vY7PAiNlbK13McamQ-1; Tue, 02 Jan 2024 09:43:20 -0500 X-MC-Unique: MX-l_vY7PAiNlbK13McamQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-336937af9e9so4300210f8f.0 for ; Tue, 02 Jan 2024 06:43:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704206599; x=1704811399; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WhdTpu1Gj/Rs/x1LOHxucotzzEaZClycuQxyUWEHmIg=; b=anNQRsoJRuilvYEUMwffKYJbJ8Z6Cx4KT/uCUk80ox8rX16bFkgpigc7UEluU+APNo OWSa2zKCFlf74D20mRfhXvSqDmaSa9VFIjH5RtNbzoKuDgEQWiUhoL7d0eFzRMRpl4Ab fhYKzaiefZHjqq7Lhoe5qFJrYi2WYCeY4tUp/GSkouYKSejpPtttfgIOo62G1vPViKMA lF0u0bP4v2JseAQ3eJSJE6uzhuAbHTmsdqdTTXXuSgo9IAi51sEIg8jUkGvlYNxckHh0 Fj8GLSpgNlVEu64z6tbZAx6/8Yag8u9zQZMPi2//k8hipzRzEJESQKuGHv/ggwoidRPb IBfw== X-Gm-Message-State: AOJu0YxaKPMyU9XE/PGI2qvF3SsqrVgYbsg5u7rOXKuVcbfDL0M13V42 a5DJREa0YTf2QXWFrP4QIv8hH0wN6fKw1LcvndBlApwaeAez+XaMtR9TxH8stTHHshc8++7Rtvs sJ4AEZ5kBUblsX5antw5FdF8JKOsijkb866yK1jNmV2kDj+MIFeMWdcidnWGGUlLHREOa2H1ZtN 1r2Z5VJ3mi/ULwLg== X-Received: by 2002:adf:e68e:0:b0:336:5b1e:ee66 with SMTP id r14-20020adfe68e000000b003365b1eee66mr9325222wrm.31.1704206598956; Tue, 02 Jan 2024 06:43:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IF9nwht9ueuYtgvFth+E/fpElGorAS7XsTp1CcCsyuifykpxvZdrqCK62vziStjO6nWkZZ9XQ== X-Received: by 2002:adf:e68e:0:b0:336:5b1e:ee66 with SMTP id r14-20020adfe68e000000b003365b1eee66mr9325213wrm.31.1704206598648; Tue, 02 Jan 2024 06:43:18 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id z4-20020a5d4d04000000b00336a1f6ce7csm24106202wrt.19.2024.01.02.06.43.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 06:43:18 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 0/3] Changes to error reporting from the expression parser Date: Tue, 2 Jan 2024 14:43:10 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org In V2: - Have split the "merging of error handling" into its own patch, adding the new error handling is in its own patch. - Reordered patches, the minor bug fix is now first, follow by the refactor, with the new functionality placed in the last patch. - Have dropped the whole marker idea, and gone with the simpler 'error at end of ....' style message. This means that no tests need updating -- I have added a couple of new tests, but everything else should continue to pass as before. --- While working on another patch I wished that the error reporting from the expression parser was better. This series is my attempt to make it better. --- Andrew Burgess (3): gdb: don't try to style content in error calls gdb: merge error handling from different expression parsers gdb: improve error reporting from expression parser gdb/ada-exp.y | 2 +- gdb/c-exp.y | 5 +---- gdb/d-exp.y | 5 +---- gdb/f-exp.y | 5 +---- gdb/go-exp.y | 5 +---- gdb/m2-exp.y | 5 +---- gdb/p-exp.y | 5 +---- gdb/parse.c | 15 +++++++++++++++ gdb/parser-defs.h | 9 +++++++++ gdb/procfs.c | 6 ++---- gdb/testsuite/gdb.base/exprs.exp | 8 ++++++++ 11 files changed, 41 insertions(+), 29 deletions(-) base-commit: 90827b4eefb06f6e0ab6cbac9eb94922e2cc8aee -- 2.25.4