From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rm/LI4x3PmPXdwYAWB0awg (envelope-from ) for ; Thu, 06 Oct 2022 02:37:00 -0400 Received: by simark.ca (Postfix, from userid 112) id 7F7341E112; Thu, 6 Oct 2022 02:37:00 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=dQU5rrXm; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 286C21E0CB for ; Thu, 6 Oct 2022 02:37:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3FEFB3865C29 for ; Thu, 6 Oct 2022 06:36:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3FEFB3865C29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665038219; bh=45C1m2ycyDQRQZDon4kUZtiMNCCIDe3HaTwc4N7Qh+k=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=dQU5rrXmqn8TiEXCSMkAbXyqIa+kXIMauxIof0kXgmTuAArEodDOOi1Nz/24gf2y7 bPbufNHKFTunRDRMmYHXgt0ln8p2Mey6p2Bv2/YhFcQjylfruY8EYgy0uu3gvOLB/L CecwAzZOwfHC1a/ha0Gjo0TA/3ssUI0SvDgFljBI= Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id 53EC03853543 for ; Thu, 6 Oct 2022 06:36:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 53EC03853543 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 0EEE4300089; Thu, 6 Oct 2022 06:36:36 +0000 (UTC) To: Tsukasa OI , Andrew Burgess , Mike Frysinger , Stephane Carrez , "Frank Ch . Eigler" Subject: [PATCH v2 0/7] sim, sim/ARCH: Add ATTRIBUTE_PRINTF Date: Thu, 6 Oct 2022 06:36:26 +0000 Message-Id: In-Reply-To: References: Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tsukasa OI via Gdb-patches Reply-To: Tsukasa OI Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hello, [Background] When we build Binutils and GDB with Clang, it causes a build failure due to warnings generated by Clang and the default -Werror configuration. I MOSTLY managed to make ALL ARCHITECTURE ENABLED Binutils and GDB -Werror-free on Clang 15.0.0 (note that this does not necessarily mean warning-free) and this patchset is a part of it (simulator: printf-like functions). - It still requires -Wno-implicit-function-declaration on the LatticeMicro32 and M32R simulators. Except them, most of Binutils / GDB components can be built with Clang by default with my tree. - I noticed that the assembler is not tested enough (because just with --enable-targets=all, it builds only host assembler). Full Clang 15.0.0 -Werror-free branch in development is available at: Tested configuration: - Ubuntu 22.04.1 LTS (x86_64) - LLVM / Clang 15.0.0 (built from source) - Configuration examples: $srcdir/configure \ --enable-targets=all \ --enable-multilib --enable-ld --enable-gold --enable-nls \ CC=clang CXX=clang++ CCLD=clang CXXLD=clang++ \ CFLAGS=' -O2 -g -Wno-implicit-function-declaration' \ CXXFLAGS='-O2 -g -Wno-implicit-function-declaration' $srcdir/configure \ --target=riscv64-unknown-linux-gnu \ --enable-multilib --enable-ld --enable-gold --enable-nls \ CC=clang CXX=clang++ CCLD=clang CXXLD=clang++ \ CFLAGS='-O2 -g' CXXFLAGS='-O2 -g' [About this Patchset] Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This patchset adds ATTRIBUTE_PRINTF to all functions that require ATTRIBUTE_PRINTF macro. [Changes: v1 -> v2] - We only append ATTRIBUTE_PRINTF at function declarations, not definitions (based on the feedback by Andrew Burgess). - Fixed indents - Removed ChangeLog from commit messages (based on the feedback [to another patchset by me] by Bruno Larsen). Thanks, Tsukasa Tsukasa OI (7): sim: Add ATTRIBUTE_PRINTF sim/cris: Add ATTRIBUTE_PRINTF sim/erc32: Add ATTRIBUTE_PRINTF sim/m32c: Add ATTRIBUTE_PRINTF sim/m68hc11: Add ATTRIBUTE_PRINTF sim/ppc: Add ATTRIBUTE_PRINTF sim/rl78: Add ATTRIBUTE_PRINTF sim/common/sim-utils.c | 2 +- sim/cris/traps.c | 2 +- sim/erc32/interf.c | 2 +- sim/erc32/sis.c | 2 +- sim/m32c/trace.c | 4 ++-- sim/m68hc11/m68hc11_sim.c | 2 +- sim/ppc/main.c | 2 +- sim/ppc/misc.c | 4 ++-- sim/ppc/sim_calls.c | 2 +- sim/rl78/trace.c | 4 ++-- 10 files changed, 13 insertions(+), 13 deletions(-) base-commit: a13886e2198beb78b81c59839043b021ce6df78a -- 2.34.1