From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AXQmBQCCTWLSMAAAWB0awg (envelope-from ) for ; Wed, 06 Apr 2022 08:05:20 -0400 Received: by simark.ca (Postfix, from userid 112) id 03AD31E787; Wed, 6 Apr 2022 08:05:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 41F181E787 for ; Wed, 6 Apr 2022 08:05:18 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A9D49385842E for ; Wed, 6 Apr 2022 12:05:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A9D49385842E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1649246716; bh=PhJu6z9xJEn6II+UL8bumygvuWfS5GFn4AWEvnPgFUE=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=UICboYnYHgD5RdPrFtYv1zN2SzCy58zPOK8Ho3qDha0LNx17ixFl0ELLpm0LxzILB yFiIeEgji/iOZO2M8AJhuDV3Jk/w1B91Uc31j1QXTfCs/P38WYi0EF4WcyJQr7h0J6 PwYGtatCnWMrHNkCrflAIcHuN2FRryYPz5Fekg34= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3543E385840C for ; Wed, 6 Apr 2022 12:04:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3543E385840C Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-537-Qg6aB204PdSoiBazO9sm_w-1; Wed, 06 Apr 2022 08:04:54 -0400 X-MC-Unique: Qg6aB204PdSoiBazO9sm_w-1 Received: by mail-wr1-f69.google.com with SMTP id u30-20020adfa19e000000b00206153b3cceso428514wru.1 for ; Wed, 06 Apr 2022 05:04:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PhJu6z9xJEn6II+UL8bumygvuWfS5GFn4AWEvnPgFUE=; b=YMt3lJPfbu1xPKddnQBcNGOqaYOx6R+7naWx6DBdAh3/yUcP+DSX6Sr+cdVyX9Vgv/ CQWQhAblKT0maAkpbflDVx56r+v8dVEDweMEJTONSOgcXRTfORsPlJ3Ny+7tS8/mcMhX cu1wkCzCq8Zy1Z74X+nKcSMF/d/A5Q1Okz21eoKATmSzssTffv86GCY6IwbbhBe2iZxo V0UekIHXuQUIOkUFE+CHl6ILMoUGQEqQcLQHsBY9UrhdYnxCY1khWa03P/cwF4QhY4z2 AErQJCcCFhwnAo1xkZ5tviZu99msbYc64AxZQBeUqoDKooFlQYSQtwmBqNoVS68QoUFD 7OcQ== X-Gm-Message-State: AOAM532dZUBLbuDLDGIPsOP7PQjJz6LsvbxqzckHFeiS6kgi98fefDho Bp5OACu/64dp5xPr76/qTm912u82Ooe1ySXGgEN4kqzm2ANg+A1OmPI6RpGRD3NgrK13mMAGJ1f Rmw49fkvIVc9WFuTLc7fAJjKc6NtcNOslUss/8130lzQYSUPJGpVm9Q8AWPJmHYkbtf4UMKl5lw == X-Received: by 2002:a05:600c:3c8d:b0:38e:4bc6:abde with SMTP id bg13-20020a05600c3c8d00b0038e4bc6abdemr7102577wmb.13.1649246693027; Wed, 06 Apr 2022 05:04:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz14QNlwWxF5SdWiFQF7hOg4wY7KyK1i5dFYNn4nvOXetsfuw264WPSctitRPNSrp/G4wvHYw== X-Received: by 2002:a05:600c:3c8d:b0:38e:4bc6:abde with SMTP id bg13-20020a05600c3c8d00b0038e4bc6abdemr7102545wmb.13.1649246692696; Wed, 06 Apr 2022 05:04:52 -0700 (PDT) Received: from localhost (host86-169-131-113.range86-169.btcentralplus.com. [86.169.131.113]) by smtp.gmail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm21248149wry.72.2022.04.06.05.04.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 05:04:51 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [PATCHv2 00/16] Default register groups, and general related cleanup Date: Wed, 6 Apr 2022 13:04:33 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Cc: Andrew Burgess Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" This work started with this thread: https://sourceware.org/pipermail/gdb-patches/2022-March/187071.html In which it was discovered that the ppc targets don't add the default register groups during gdbarch initialisation. I've run into this problem before, and every time I wonder why the default register groups aren't added by default in all cases. So, looked at doing just that. But the register group management code was feeling a bit crusty, so I thought I'd clean it up. Then I hit some bugs, which I figured I'd fix. Anyway, patch #9 is what I set out to do. Everything else is me trying to improve the register group handling code. Changes in v2: - Rebased onto current master, the changes I make to gdb.tui/regs.exp in one of the patches needed some small adjustments given recent tui changes, - Updated patch #11 based on Lancelot's feedback, this looks much better now. --- Andrew Burgess (16): gdb: don't try to use readline before it's initialized gdb: add some const in gdb/reggroups.c gdb: make gdbarch_register_reggroup_p take a const reggroup * gdb: switch to using 'const reggroup *' in tui-regs.{c,h} gdb: use 'const reggroup *' in python/py-registers.c file gdb: have reggroup_find return a const gdb/tui: avoid theoretical bug with 'tui reg' command gdb/tui: fix 'tui reg next/prev' command when data window is hidden gdb: always add the default register groups gdb: convert reggroups to use a std::vector gdb: remove reggroup_next and reggroup_prev gdb: more 'const' in gdb/reggroups.{c,h} gdb: make the pre-defined register groups const gdb: convert reggroup to a C++ class with constructor, etc gdb: move struct reggroup into reggroups.h header gdb: update comments throughout reggroups.{c,h} files gdb/aarch64-tdep.c | 19 +-- gdb/alpha-tdep.c | 2 +- gdb/amd64-linux-tdep.c | 2 +- gdb/arc-tdep.c | 17 -- gdb/arm-tdep.c | 2 +- gdb/completer.c | 8 +- gdb/csky-tdep.c | 14 +- gdb/gdbarch-components.py | 2 +- gdb/gdbarch-gen.h | 4 +- gdb/gdbarch.c | 2 +- gdb/i386-linux-tdep.c | 2 +- gdb/i386-tdep.c | 13 +- gdb/i386-tdep.h | 2 +- gdb/ia64-tdep.c | 2 +- gdb/infcmd.c | 14 +- gdb/lm32-tdep.c | 13 +- gdb/m32c-tdep.c | 9 +- gdb/m68hc11-tdep.c | 13 +- gdb/mep-tdep.c | 12 +- gdb/mips-tdep.c | 4 +- gdb/msp430-tdep.c | 2 +- gdb/nds32-tdep.c | 32 ++-- gdb/or1k-tdep.c | 14 +- gdb/python/py-registers.c | 32 ++-- gdb/regcache-dump.c | 9 +- gdb/reggroups.c | 298 ++++++++++++--------------------- gdb/reggroups.h | 94 +++++++---- gdb/riscv-tdep.c | 18 +- gdb/rl78-tdep.c | 2 +- gdb/rs6000-tdep.c | 2 +- gdb/s390-tdep.c | 2 +- gdb/sh-tdep.c | 2 +- gdb/target-descriptions.c | 6 +- gdb/target-descriptions.h | 2 +- gdb/testsuite/gdb.tui/regs.exp | 26 +++ gdb/tui/tui-regs.c | 107 ++++++------ gdb/tui/tui-regs.h | 9 +- gdb/utils.c | 17 +- gdb/xtensa-tdep.c | 25 +-- 39 files changed, 364 insertions(+), 491 deletions(-) -- 2.25.4