From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NhlbCROT9mD9UQAAWB0awg (envelope-from ) for ; Tue, 20 Jul 2021 05:10:43 -0400 Received: by simark.ca (Postfix, from userid 112) id 027551EDF2; Tue, 20 Jul 2021 05:10:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1E6231E54D for ; Tue, 20 Jul 2021 05:10:42 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5C9AE398801C for ; Tue, 20 Jul 2021 09:10:41 +0000 (GMT) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 97ED5385382C for ; Tue, 20 Jul 2021 09:10:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 97ED5385382C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wm1-x32e.google.com with SMTP id f190so10288400wmf.4 for ; Tue, 20 Jul 2021 02:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VBshmQUXloKg/QAOjvRcMwqzAeFsLRPz84z9cnERCQQ=; b=O1m+9G/pO86c2jCw3hzcP9PqVhr20U91El5Tybo3TJCbYfnr6tawo65bc1FiJsMZaV gEtK+OjXymsabsSz/TKSEepa61H1kmsNCv4KPKXxnfiRZ4VcLXsQ2JDJ48PgfZmnydOP 6ejW5vxOlDxkDm+dMu0Vdous3+k1zUZT7fp9GzlFkd1h1ztPfeY8GCeD3kmpQZv+mV/j LHk361QuuQohH8022YPihPEco2sWqxLkPP4Di/4wizdl/SlrhiE2cYCIz9oL/gjK/FJp U/+ikkWiNZmscqN/F4MdOv937PbqMRA1Fhh8j8SxqW9Z3ZO0k73W0606Rt3hzDJ59XS2 Rndw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VBshmQUXloKg/QAOjvRcMwqzAeFsLRPz84z9cnERCQQ=; b=U7OCGiN9dLWAufXt9SS9n//iSiun/jRYE9cEc/nSA+G4hWfAehKbX3UXf4fHb/a2QR pl/lB8JdVX8nOQfCn7qQYDXdS5E8ADiFGnUkc9pANExtRrPZz2lRWIieb5XhDwkzHKeE ZsD2Ed5CfEv/rO6PzDa2kuAfs4WPGpszDJ01GpUiZ4DESTfHfvGDzzZKMLR+46+jiKuu jQ+sslm627TYmIiRlR/LkIbp9n9PM2a/GeAlXX2+LPP6KstRvqKDgcr33GPicfQkBZl2 UQZjULfVF+pzoD7e/KBa7qj7C0KMZOwNpmgpjP0BZnAERSrP5v/0bao5gP3G3hipQ+vi aoiA== X-Gm-Message-State: AOAM533FVr1BGmAeEPb2LdWifr2EsHjQ0TsUsS5UxIJ4X46eJyjq0rdS UzXagkGR2dxhhnjoIBpr9UhQRPOlGYQJDQ== X-Google-Smtp-Source: ABdhPJwO7x3YyNMiqpVze9fHWxOD0HXPlmy4BXXbQZnvQShZgFMvBwz4BX4CIT5iXQJFU3Scm9ptAw== X-Received: by 2002:a05:600c:3ba7:: with SMTP id n39mr1728080wms.164.1626772228600; Tue, 20 Jul 2021 02:10:28 -0700 (PDT) Received: from localhost (host109-151-14-57.range109-151.btcentralplus.com. [109.151.14.57]) by smtp.gmail.com with ESMTPSA id y197sm2012969wmc.7.2021.07.20.02.10.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 02:10:28 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: [PATCHv3 0/2] Fix for an assertion when unwinding with inline frames Date: Tue, 20 Jul 2021 10:10:22 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Thanks for the feedback on v2. In v3 I have: - Addressed all of Pedro's feedback on the test in patch #1. - Rewritten how the problem in patch #1 is fixed based on Simon's exception based approach. Thanks, Andrew --- Andrew Burgess (2): gdb: prevent an assertion when computing the frame_id for an inline frame gdb: remove VALUE_FRAME_ID gdb/frame.c | 57 ++++--- gdb/frame.h | 4 - gdb/inline-frame.c | 31 +++- .../gdb.base/inline-frame-cycle-unwind.c | 58 +++++++ .../gdb.base/inline-frame-cycle-unwind.exp | 145 ++++++++++++++++++ .../gdb.base/inline-frame-cycle-unwind.py | 85 ++++++++++ gdb/valops.c | 17 +- gdb/value.c | 5 +- gdb/value.h | 6 - gdbsupport/common-exceptions.h | 5 + 10 files changed, 373 insertions(+), 40 deletions(-) create mode 100644 gdb/testsuite/gdb.base/inline-frame-cycle-unwind.c create mode 100644 gdb/testsuite/gdb.base/inline-frame-cycle-unwind.exp create mode 100644 gdb/testsuite/gdb.base/inline-frame-cycle-unwind.py -- 2.25.4