[PATCHv2 0/2] gdb/guile: perform tilde expansion when sourcing guile scripts

[Andrew Burgess <andrew.burgess@embecosm.com>]

* Tom Tromey <tom@tromey.com> [2021-05-05 13:11:37 -0600]:

> >>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
> 
> Andrew> This is because the path is not tilde expanded.  In contrast, when
> Andrew> sourcing a .py or .gdb script the path is tilde expanded.
> 
> Andrew> This commit fixes this oversight, and allows the above source command
> Andrew> to work as expected.
> 
> It seems a little strange to me that each extension language must do
> this, rather than the caller doing it.

I believe that this is the right solution though.  I have updated the
commit message (in patch #1) to better explain why I think this.  If
you still disagree, just let me know and I'll move the logic.

> 
> Andrew> +  gdb::unique_xmalloc_ptr<char> msg
> Andrew> +    (gdbscm_safe_source_script (full_path.c_str ()));
> 
> I suppose gdbscm_safe_source_script could return a unique_xmalloc_ptr,
> and this could just use the '=' form.

That would be better, then all of the users would be forced to change
(which would be a good thing).  I span this out into patch #2.

Thanks,
Andrew

---

Andrew Burgess (2):
  gdb/guile: perform tilde expansion when sourcing guile scripts
  gdb/guile: Have gdbscm_safe_source_script return a unique_ptr

 gdb/ChangeLog                     | 17 +++++++++++++++++
 gdb/guile/guile-internal.h        |  3 ++-
 gdb/guile/guile.c                 |  7 ++-----
 gdb/guile/scm-objfile.c           |  9 ++-------
 gdb/guile/scm-safe-call.c         |  8 +++++---
 gdb/testsuite/ChangeLog           |  4 ++++
 gdb/testsuite/gdb.guile/guile.exp |  7 +++++++
 7 files changed, 39 insertions(+), 16 deletions(-)

-- 
2.25.4