RE: [PATCH 3/4] gdb/breakpoint: add a 'force_condition' parameter to 'create_breakpoint'

Aktemur, Tankut Baris via Gdb-patches
2021-04-08T14:20:08Z

On Thursday, April 8, 2021 4:00 PM, Simon Marchi wrote:
> On 2021-04-08 3:44 a.m., Aktemur, Tankut Baris wrote:
> > Ack. The other test functions also refer to hardcoded breakpoint numbers.
> > Fiddling with the breakpoint list by deleting/adding new breakpoints
> > caused the other tests to fail, and thus I simply opted for the easier
> > solution of hardcoding.
>
> And I don't want to put on you the burden of doing this change, so I
> think your patch is OK. But this would be an item on the wishlist, and
> I mentioned it because it can perhaps influence the future tests you
> write from scratch (if you agree with the idea).
>
> Simon

Thank you for your empathy. Yes, I agree with the idea -- it's hard
to argue against it :)

-Baris

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928