RE: [PATCH v4 2/2] gdb/mi: add a '--force' flag to the '-break-condition' command

Aktemur, Tankut Baris via Gdb-patches
2021-05-06T08:50:14Z

On Thursday, May 6, 2021 4:47 AM, Simon Marchi wrote:
> > + /* There must be at least two more args: a bpnum and a condition
> > + expression. */
> > + if (oind + 1 >= argc)
> > + error (_("-break-condition: Missing arguments"));
>
> I don't know what the standard is for MI commands, but it would be handy
> for somebody trying this by hand to say what are the expected arguments
> in the error message.
>
> Otherwise, LGTM, thanks!
>
> Simon

I updated the error message and pushed both patches.
Thanks!

-Baris

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928