From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KC2vKDcSbl8SIgAAWB0awg (envelope-from ) for ; Fri, 25 Sep 2020 11:52:23 -0400 Received: by simark.ca (Postfix, from userid 112) id A4BEB1EF55; Fri, 25 Sep 2020 11:52:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A15FC1EF4B for ; Fri, 25 Sep 2020 11:52:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4155639F6EC8; Fri, 25 Sep 2020 15:52:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4155639F6EC8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1601049142; bh=eARWX4UR3+YVR0n3O+QzzkD0+Piiwxwk+WP9i1vJejM=; h=To:Subject:Date:In-Reply-To:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:From; b=EJfMBnIsBxDpxr1z0x+E4wM5QinBZuvZrlIjqwYPgq2QLYLJl1mmgkRNJSnEgcFys ij41/bYLfRJPmFFxSgac+14Qvop4PPKkC9yEKYwvA8RjIgm48UXGoe6aXOhp5r15QC TKIVxam0kfoXZi5IraUCHkC1uYpV54ii3lVts5o4= Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by sourceware.org (Postfix) with ESMTPS id C39AF396ECFA for ; Fri, 25 Sep 2020 15:52:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C39AF396ECFA IronPort-SDR: VO33asF7Y9Gfnqbn58rrStjiIoQgcCtLOtW1o/yQOvFpIENrD5oKURm2sOy7l2L1tuH+lQKGQG Qfw96Vssw59Q== X-IronPort-AV: E=McAfee;i="6000,8403,9755"; a="225723286" X-IronPort-AV: E=Sophos;i="5.77,302,1596524400"; d="scan'208";a="225723286" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 08:52:10 -0700 IronPort-SDR: bvow5myP+btrcip8i3HQXQE4HMkdJ8o7IkEeWXWpuWifhkXpocK+XZGLbTdy8YRsIiFW8Gkj1x XQyLxD+OZ92w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,302,1596524400"; d="scan'208";a="343655992" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga002.fm.intel.com with ESMTP; 25 Sep 2020 08:52:08 -0700 Received: from ulvlx001.iul.intel.com (ulvlx001.iul.intel.com [172.28.207.17]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 08PFq7R7030920; Fri, 25 Sep 2020 16:52:07 +0100 Received: from ulvlx001.iul.intel.com (localhost [127.0.0.1]) by ulvlx001.iul.intel.com with ESMTP id 08PFq7ah010480; Fri, 25 Sep 2020 17:52:07 +0200 Received: (from taktemur@localhost) by ulvlx001.iul.intel.com with LOCAL id 08PFq72E010476; Fri, 25 Sep 2020 17:52:07 +0200 To: gdb-patches@sourceware.org Subject: [PATCH v3 0/2] Breakpoint conditions at locations with differing contexts Date: Fri, 25 Sep 2020 17:51:37 +0200 Message-Id: X-Mailer: git-send-email 1.7.0.7 In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tankut Baris Aktemur via Gdb-patches Reply-To: Tankut Baris Aktemur Cc: simark@simark.ca Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, This is a follow-up of https://sourceware.org/pipermail/gdb-patches/2020-July/170984.html which is a short series about conditional breakpoints where the condition may be invalid at some breakpoint locations because of their context. Currently, GDB does not allow defining a condition if it's not valid at all locations. This series aims at bringing more flexibility: the locations at which the condition expression is invalid are disabled automatically. In v2, I extended Patch 2/2 with the '-force-condition' flag for the break command, added test cases and more documentation. In this revision (v3), warning messages are updated based on Simon Marchi's comments at https://sourceware.org/pipermail/gdb-patches/2020-September/171970.html. I also revised the documentation changes. Regards. Baris Tankut Baris Aktemur (2): gdb/breakpoint: disable a bp location if condition is invalid at that location gdb/breakpoint: add flags to 'condition' and 'break' commands to force condition gdb/ada-lang.c | 2 +- gdb/breakpoint.c | 260 ++++++++++++++---- gdb/breakpoint.h | 12 +- gdb/doc/gdb.texinfo | 64 +++++ gdb/guile/scm-breakpoint.c | 2 +- gdb/linespec.c | 18 +- gdb/python/py-breakpoint.c | 2 +- .../gdb.base/condbreak-multi-context.cc | 54 ++++ .../gdb.base/condbreak-multi-context.exp | 237 ++++++++++++++++ gdb/testsuite/gdb.linespec/cpcompletion.exp | 12 +- gdb/testsuite/gdb.linespec/explicit.exp | 1 + gdb/testsuite/lib/completion-support.exp | 2 +- 12 files changed, 599 insertions(+), 67 deletions(-) create mode 100644 gdb/testsuite/gdb.base/condbreak-multi-context.cc create mode 100644 gdb/testsuite/gdb.base/condbreak-multi-context.exp -- 2.17.1