From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by sourceware.org (Postfix) with ESMTPS id 297E93861823 for ; Wed, 8 Jul 2020 08:55:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 297E93861823 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x444.google.com with SMTP id s10so47952237wrw.12 for ; Wed, 08 Jul 2020 01:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=b9XnW9MagL1q2MNnqnJ+EeD7L3BEVO0hOyMj7pP+JNM=; b=A0QaIuQWbSHpvnuWVpSolBWf2nERGcxUw/rNESrGebWhJRQet32Y0m8zJ4t4MFn6Qo Nk8jrBnp3gPBVeN2vx7bSUQqTWnZPyDj9HWA+vGMMVZ2t+U6TdmaJPZ9/L1K96Z2EomC oMLzDHRU9z0N93AeZt4WxKmr9tQqIoq8b0HmvJox7625zCAXDdVLYmp5vbKfc5Ipgz8k 8BylOqqkuN9Y9j9nhfC8GkOTzzwubI5Iy6lMFhquS0FFBSkL8VA+FZmP5r3ijE6kds/6 WiHq4xxytn8j4mLwcr5oAs8z8dgNk7B28BlZNQkgzij0NyHlUtW9rn1ORjqgQMI/XXg5 lIDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=b9XnW9MagL1q2MNnqnJ+EeD7L3BEVO0hOyMj7pP+JNM=; b=s8xQX6BlECgalTLJykZNESvOR69m8axNVXouA73UXFtqt3mWDgjcSmz4Cl9nrTNvZ7 5fKKDW/3/Bx+ElNVBA1E3UJbnPXcU5VNGXAxuZ9hUZ2y/88odisgvOO8s1vItXKbAyWc Nq/VfcKWu5YJxERUaFA/sbNkOZ0L0QaBQdkyM8Fe6kqsaqFXJAdLXzsB/1tGJ8xS0Suj CJis6H9hJ7QUF3dFf1VMYixMlkONVSjTy/yJT84uu98Q/7SxspkJKme0GjA3h+JWyn4w UsiyhKadq9jnfCvHkl7/RSLhKHYHqd2PN8NFdEXMa64h+JQ78M52Ayr3RGbQKg9q23ka 3v0w== X-Gm-Message-State: AOAM531PNUW30Dh0iGQ1Z+khIUQQKHHaevWANODRs3Fq+PdvXDDejeVG FtrOdZCZt5KWidnfMT1EWJZu4xlnG3A= X-Google-Smtp-Source: ABdhPJzNcCchi0l2hz9xcl69qqG++Ye3hV1kt5u/nLOOD8/VNBb9vVRENQrFNmV5ySdKzLycrCy0bg== X-Received: by 2002:adf:f54b:: with SMTP id j11mr57948784wrp.206.1594198498977; Wed, 08 Jul 2020 01:54:58 -0700 (PDT) Received: from localhost (host109-154-20-168.range109-154.btcentralplus.com. [109.154.20.168]) by smtp.gmail.com with ESMTPSA id w16sm2086940wrg.95.2020.07.08.01.54.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 01:54:58 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: [PATCH 0/2] Changes to show architecture/endian message Date: Wed, 8 Jul 2020 09:54:53 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2020 08:55:01 -0000 I was recently debugging some issues around architecture selection so had cause to use the 'show architecture' command. The output from this command seemed ... not ideal to me, for example: (gdb) set architecture mips The target architecture is assumed to be mips (gdb) show architecture The target architecture is assumed to be mips (gdb) I don't like the use of 'assumed to be', this (to me) seems to imply that GDB is making some assumptions on the users behalf. Even if we interpret this to mean, GDB is assuming because the user told it, I don't know why we don't just say: (gdb) set architecture mips The target architecture is set to "mips". (gdb) show architecture The target architecture is set to "mips". (gdb) Just say what you mean, the architecture was set to this value. So, I made this and some other clean ups to the 'show architecture' output. Then while I was testing this I noticed that 'show endian' is basically the same, so I changed that in a similar way. Does the new output seem like an improvement to anyone else? Or does anyone else prefer the old output? Thanks, Andrew --- Andrew Burgess (2): gdb: Improve formatting of 'show architecture' messages gdb: Improve formatting of 'show endian' messages gdb/ChangeLog | 4 +++ gdb/arch-utils.c | 14 ++++---- gdb/testsuite/ChangeLog | 8 +++++ gdb/testsuite/gdb.arch/amd64-osabi.exp | 2 +- .../gdb.base/all-architectures.exp.tcl | 6 ++-- gdb/testsuite/gdb.base/attach-pie-noexec.exp | 4 +-- gdb/testsuite/gdb.base/catch-syscall.exp | 4 +-- gdb/testsuite/gdb.base/endian.exp | 34 +++++++++---------- gdb/testsuite/gdb.xml/tdesc-arch.exp | 6 ++-- 9 files changed, 47 insertions(+), 35 deletions(-) -- 2.25.4