From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by sourceware.org (Postfix) with ESMTPS id 8AC6E388E803 for ; Mon, 29 Jun 2020 13:48:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8AC6E388E803 IronPort-SDR: SdwBU9TvpD5HBq/lySc6EPowU0XLZLSKHNlgibdbOqZMn85mIdT7oSkJWxWBUv66BVBSVwZShu tjArMkFZmGQw== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="145027401" X-IronPort-AV: E=Sophos;i="5.75,294,1589266800"; d="scan'208";a="145027401" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 06:48:56 -0700 IronPort-SDR: OvVH3+5Ebo88rW4jMLGaKLKeHyMhnLRewGologPckdd0XkC5v94cAiEk++4jmqcY3TEIAoC3pX ONLIpB76PDHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,294,1589266800"; d="scan'208";a="480571432" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga006.fm.intel.com with ESMTP; 29 Jun 2020 06:48:55 -0700 Received: from ulvlx001.iul.intel.com (ulvlx001.iul.intel.com [172.28.207.17]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 05TDms9X027745; Mon, 29 Jun 2020 14:48:54 +0100 Received: from ulvlx001.iul.intel.com (localhost [127.0.0.1]) by ulvlx001.iul.intel.com with ESMTP id 05TDmsiM025796; Mon, 29 Jun 2020 15:48:54 +0200 Received: (from taktemur@localhost) by ulvlx001.iul.intel.com with LOCAL id 05TDmrFk025792; Mon, 29 Jun 2020 15:48:54 +0200 From: Tankut Baris Aktemur To: gdb-patches@sourceware.org Subject: [PATCH 0/3] Prevent bad conditions from putting breakpoints into broken state Date: Mon, 29 Jun 2020 15:48:25 +0200 Message-Id: X-Mailer: git-send-email 1.7.0.7 X-Spam-Status: No, score=-14.2 required=5.0 tests=AC_FROM_MANY_DOTS, BAYES_00, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2020 13:49:00 -0000 Hi, If the condition of a breakpoint is "bad" (e.g. has unresolved symbols, syntax errors, etc.), the breakpoint goes into a broken state where the condition string or the condition expressions are updated inadvertently. This small series attempts to fix that. Regards. Baris Tankut Baris Aktemur (3): gdb/breakpoint: do not update the condition string if parsing the condition fails gdb/breakpoint: set the condition exp after parsing the condition successfully gdb/breakpoint: refactor 'set_breakpoint_condition' gdb/breakpoint.c | 70 ++++++------- gdb/testsuite/gdb.base/condbreak-bad.c | 24 +++++ gdb/testsuite/gdb.base/condbreak-bad.exp | 128 +++++++++++++++++++++++ 3 files changed, 183 insertions(+), 39 deletions(-) create mode 100644 gdb/testsuite/gdb.base/condbreak-bad.c create mode 100644 gdb/testsuite/gdb.base/condbreak-bad.exp -- 2.17.1