Re: [PATCH 3/3] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p

Stafford Horne
2017-06-08T05:01:58Z

On Thu, Jun 08, 2017 at 05:40:34AM +0300, Eli Zaretskii wrote:
> > From: Stafford Horne <shorne@gmail.com>
> > Cc: Stafford Horne <shorne@gmail.com>
> > Date: Thu, 8 Jun 2017 07:15:47 +0900
> >
> > --- a/gdb/NEWS
> > +++ b/gdb/NEWS
> > @@ -3,6 +3,10 @@
> >
> > *** Changes since GDB 8.0
> >
> > +* GDB now supports dynamically creating arbitrary register groups specified
> > + in xml target descriptors. This allows for finer grain grouping of
> > + registers on systems with a large amount of registers.
> > +
>
> I'm confused: in the commentary for the patch to the manual you said
> the feature existed, but wasn't documented. So why is it mentioned in
> NEWS as a new feature? Should we have more documentation changes, if
> it's new?

Thanks for reviewing.

Sorry, you are right its a bit confusing and this second part probably
needs some more document changes.

There are 2 things going on in those 2 patches.
1. Add docs for the existing feature (listing registers by group name)
2. Add feature to be able to defined more groups based on the XML target
description.

Ill add docs for (2) and try to make it a bit more clear in my next cover
letter.

Is the single NEWS entry ok in the end?

-Stafford